From nobody Mon Nov 17 09:50:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603710205; cv=none; d=zohomail.com; s=zohoarc; b=Q8HOXN9IIb4ysq+bqrLspr1K+GNdsEnJGcRyByHLL76uyM1nDfz+zl0oQJX3/Mbgy0VV8dbqeQj8HRTAArbn9dsawNTg58DdFXFAQWX6PZZs2zVLHCdb6qfZfqM6OzheOykKcauk8NVzpDMrIWaCyIKkR4Rtl0C6+WCjQoJYyrw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603710205; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yrIfSe6YicHcmNa56yOajmgv3h3ly3b3aUGVmAig4lI=; b=S2iP3AqNy0T1R99LoWTFVgDSd32aPGkFDS4SKBC+KCQgtHr7VBKlPTtT7I/2lMeTCzSKv+bZH5PY3lDd2zDeMTCKDr2sBVanfjBc0u4w087mDWH+HXQTzUpRp7jvK2o49W7WLfH7fMUOJDYguS3UA9PXgmcuB9Z2voRKeiwW8/I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1603710205148183.81453214901205; Mon, 26 Oct 2020 04:03:25 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id h5so11880987wrv.7 for ; Mon, 26 Oct 2020 04:03:24 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id x64sm19263766wmg.33.2020.10.26.04.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 04:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yrIfSe6YicHcmNa56yOajmgv3h3ly3b3aUGVmAig4lI=; b=kjc/4RFE5iK3HHoKlDbqjcnlyim9wIhQpf5LzbcLMfBew2cg/MEkszynKYCplZMMdv BiDNzy8oZbG3x72qf4q30ypL9xM81FvkUt7GdIBBHbTUjppYGBF6d2pCRdtMYO46yNCq HEOSAfbyaElweX2waulKR1jQ/BhIXv6gcw70mdaI/YDnz0UMxobvebs9O1fnM7aLdDMe bdvz2+qxuSVuK3h96seYoo7hxSj0p8bkTsqiqZgcE4MB3z5dMeAH6syRcrdrSp50E86h TOu6xmhVtsmnq1RqB8jV6NsJWSiPrndylItjmatwh41r48DbsM26tW4Bq6S49Ri4Igfl nRGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=yrIfSe6YicHcmNa56yOajmgv3h3ly3b3aUGVmAig4lI=; b=nwJacJ22tLevURUagHNL1sLUTZ13PxV1oKCPiXs8+0Yyp1zgIIp6Cl+rnT4AW0lgb3 W6lnqxef+Mst1qALLkMILzhqHPJHU9rZ94RtnaEFEbJv7UUBawBPfbM6YQRad7tX8zbt G3/0G0b5anKT2oCx09DLj9uYpM2FYYh0cQCVmXNt/6nNsk0gglHSelEXwJNm9RAKT/qQ 2L7373tFGlqOm9tZe4nHCuF2X2MsGmLpUm6t3tNnTYYcJCPyh4J0k2JXRbuiONXc1vN4 a7NY1v3W1nDewtEK74Mg9Y7f71tHyiOE/Wu5VZUQOyD5JvjhC8shpfgq2a2Fs+s43uDj th4w== X-Gm-Message-State: AOAM530Pa+CP1KM9mX6xOulFrlZPBRS4S4ZiFLUTyNgtcQxN9/w3qTzV Byfi6rzPO9GmX0PXry5E97w= X-Google-Smtp-Source: ABdhPJzCxwyFqVQw/x5Cl5hWncgMKCklk4TYvbavJ3Vxcq64FiMZgKkzI7R5qC1Rs8NKZbXH+2YLqQ== X-Received: by 2002:adf:f44d:: with SMTP id f13mr16484159wrp.385.1603710202607; Mon, 26 Oct 2020 04:03:22 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, Peter Maydell , Alistair Francis Subject: [PULL 1/5] hw/sd/sdcard: Update the SDState documentation Date: Mon, 26 Oct 2020 12:03:11 +0100 Message-Id: <20201026110315.4026183-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026110315.4026183-1-f4bug@amsat.org> References: <20201026110315.4026183-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Add more descriptive comments to keep a clear separation between static property vs runtime changeable. Suggested-by: Peter Maydell Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Message-Id: <20200630133912.9428-12-f4bug@amsat.org> --- hw/sd/sd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index c3febed2434..9b53053527e 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -102,11 +102,14 @@ struct SDState { uint32_t card_status; uint8_t sd_status[64]; =20 - /* Configurable properties */ + /* Static properties */ + uint8_t spec_version; BlockBackend *blk; bool spi; =20 + /* Runtime changeables */ + uint32_t mode; /* current card mode, one of SDCardModes */ int32_t state; /* current card state, one of SDCardStates */ uint32_t vhs; --=20 2.26.2