From nobody Tue Feb 10 01:16:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603709735; cv=none; d=zohomail.com; s=zohoarc; b=jPaJeNpD+r5FTB3tOc1zdWumVhy+gge1jDx6adPdiEr9WSo+8PlOD6mULLratIoEevjTdNXhUteNlrw1PL1VNl0WcOsrMzEFDO44ZRT7mJGVHWZyb3JPwPsGfpVnauz5/XC2mPzhkSJiTl+Yq5F6CPYvGbI90OWa9Jk+k3D1zVE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603709735; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=v40hj3qY78whRoPdfOU/jnlm9Vu0+VmOWNSL1HaIBaY=; b=EoteR7q+VfJBC+CGdynQUjAfQdPWtNmEKRJnUdqD41+lJC0lnZy7qnywGpSKX0oOxKMuuKSV7e9Yn7DiPK6DPQJvMYM5UiP1yF6l2TlGgFmd3sRT2Dn4I6ssiS8G5PJnTt9KJ1dY9atjjHvZpU0NsNuxeb9g8VMxrMZOnZHHxpw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1603709735088145.22751126791013; Mon, 26 Oct 2020 03:55:35 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-JpxlU-gyObyxJOEU5LRhvg-1; Mon, 26 Oct 2020 06:55:32 -0400 Received: by mail-wr1-f71.google.com with SMTP id i6so8168504wrx.11 for ; Mon, 26 Oct 2020 03:55:32 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id v19sm18878384wmj.31.2020.10.26.03.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 03:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603709734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v40hj3qY78whRoPdfOU/jnlm9Vu0+VmOWNSL1HaIBaY=; b=ePl2R3KqIeerkAl03ElWG+flDa7PG2vR7mg82IH0nxOyyJGFEWJtfsDnz4JsVH3JYDtvll hnASa1rbaodVbmIKzNmfSlHqXGswWCQ+vW7MUXQQ0CcB/dlB6ylo+Nfb6O6XTaV0FlNsm4 XompFkGHDlZH+GEDIyTvaTEi0UikUjo= X-MC-Unique: JpxlU-gyObyxJOEU5LRhvg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v40hj3qY78whRoPdfOU/jnlm9Vu0+VmOWNSL1HaIBaY=; b=ZT4//xkCi01ZvS+aeAq9ybgJ1aCESTC+6X30HnBZ9qH3emCF2mAMvkM19wAblYswFm i9qODPgtXVxEz6+dG6a/7+4HBE6Pcvi9KUNAW4vNA6ApYqhAndI5/jNbzPcLNwXwP0vG feh0autQRyIuZAeiB8ZkT+eKPhNGpmpCYsiMh2n5y8wdqxgI7GTNIHHQ1PLUnFsMeuSh wK04TZ3jZLbAJ5Ot1G09emAkEVDuUlmggaqpSydzQGqj+xjrbxiZMNfvqDhiIZ/SVdUr 4P5rp+rfGcoTw37c+QpTkDyAKcAay2OZTI3dz5wQrw24sHERIoxTriS08nh2bbi3ZfOQ IINw== X-Gm-Message-State: AOAM532dMiLWA93ixHrFXubDGgmtpelzeOBdmCzygVotnmZ/k7CMOz38 GuRwFL7pcryx+rNmkQcS36Fe8WOPJQTVaRQKLXD3YL5c1dwwNQe0nV9s2eqPRAagw4elQjUdLcx 7Lz/y0R8qDpWRyA== X-Received: by 2002:adf:b787:: with SMTP id s7mr18080750wre.390.1603709731141; Mon, 26 Oct 2020 03:55:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxArnquS83MoKMOGB9wkQvP/rs0d4NxPjydeloJhB2Mh9ZkwP/gL2SCIvEIBjtZbOso4aloNw== X-Received: by 2002:adf:b787:: with SMTP id s7mr18080737wre.390.1603709730967; Mon, 26 Oct 2020 03:55:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eric Auger , Alex Williamson , qemu-block@nongnu.org, Fam Zheng , Max Reitz , Stefan Hajnoczi , Kevin Wolf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 05/19] util/vfio-helpers: Improve reporting unsupported IOMMU type Date: Mon, 26 Oct 2020 11:54:50 +0100 Message-Id: <20201026105504.4023620-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026105504.4023620-1-philmd@redhat.com> References: <20201026105504.4023620-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Change the confuse "VFIO IOMMU check failed" error message by the explicit "VFIO IOMMU Type1 is not supported" once. Example on POWER: $ qemu-system-ppc64 -drive if=3Dnone,id=3Dnvme0,file=3Dnvme://0001:01:00.0= /1,format=3Draw qemu-system-ppc64: -drive if=3Dnone,id=3Dnvme0,file=3Dnvme://0001:01:00.0/= 1,format=3Draw: VFIO IOMMU Type1 is not supported Suggested-by: Alex Williamson Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- util/vfio-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c index c469beb0616..14a549510fe 100644 --- a/util/vfio-helpers.c +++ b/util/vfio-helpers.c @@ -300,7 +300,7 @@ static int qemu_vfio_init_pci(QEMUVFIOState *s, const c= har *device, } =20 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) { - error_setg_errno(errp, errno, "VFIO IOMMU check failed"); + error_setg_errno(errp, errno, "VFIO IOMMU Type1 is not supported"); ret =3D -EINVAL; goto fail_container; } --=20 2.26.2