From nobody Mon Feb 9 16:19:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603709732; cv=none; d=zohomail.com; s=zohoarc; b=SxnD9uvtj4vVfIQGzsqHNf9KS9c91Y5hKF/I/0hJfLOzpYi3hGUR5KlSvOPrqyB/8a3dOfA4G5pqaCDyk/RL2E6dz3oP6dBbSK09x2xLRtPV1eNaFi0BKx4VaiMHytwz08TXX+s/W0uX0luiynX0jgb3MoSYnjV+D3bjWBAzR9M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603709732; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=W5p4tPu2TXjCzyH8ugJtEh2K4jonp6V4FsAYE5GR61Q=; b=Vx11DIutp8fa4ilVU9tLO1cp0iePB6evBRrMg/JfjFdt8GCqr9ZsykOzzb34aTWGeu6cl763X7DCSjFOZ0rT2u2UNQuKQy8URpL8Qu1LbD8TiTRG8pBREH4geQV3x/ha++7vx4ZOyYdeSJLp3rXQmEFcZMwQFe5r/BUjcwDlK50= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1603709732351877.806322269094; Mon, 26 Oct 2020 03:55:32 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-z0IhbgkIMbeX9FZQbyLg_w-1; Mon, 26 Oct 2020 06:55:27 -0400 Received: by mail-wm1-f69.google.com with SMTP id s140so146653wme.3 for ; Mon, 26 Oct 2020 03:55:27 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id s2sm22714740wmf.45.2020.10.26.03.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 03:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603709731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W5p4tPu2TXjCzyH8ugJtEh2K4jonp6V4FsAYE5GR61Q=; b=W3msZQBxSYG9rhkQbnp3zJCd6RAT3Esl3SC6ukG2rI2Wob1TRCUHicEdIIVnMx8gqXgNi2 TdzUzymPQPLXN5O/HKCeHsZXZAuRj4dF12u/rdR2VibPJJs28AfStBNsi7qFmqrmMq6LDk fk+34X+lxjgOGFPWW3TKfXFPelGoPME= X-MC-Unique: z0IhbgkIMbeX9FZQbyLg_w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W5p4tPu2TXjCzyH8ugJtEh2K4jonp6V4FsAYE5GR61Q=; b=qsN8n43TIIhD2UUndnjEwVmX+LIF+cntLgiFnJUcy1YF/a7gwfdROBTAcmNBuIyHki QNYWdLXHK3cLWH1Ffs5ATPt88r5IzGLj6qmCGNsbi0EJFzMOusUCdJv1dv7tpeNzNV62 2RjC1q/rrPfmQPxOaXPcJGSxkhyJ4q0BCniKpBk9CGtG/WFu5hR9GgXvsJOp+jvoKu9I 5jzS63OKSqFB80yW/leuzXI/pL1HnY3wFWh1Hg9A5RZOmR/DZJZaCWaSfxhB7Hmkkge6 D6rs5hi5eAxpc+JYziAsg4oDSF174zr0vlxfl1LmifOQpjM/ycD+LiiE6W016ee8ryf3 E3fQ== X-Gm-Message-State: AOAM5303CYYOYFM8F2KmsnibOvT8F/N2A6Zj4YFUnoFP/i4UhZAX0rtW hhc4kLbnpDh31lOJBo1mQs3IoIGwPsBUJK/+Jva7SOvd9ynO9+D0AVxYRgJpZYzYdHNqLr/lflc thBzrWsjSBsRqZg== X-Received: by 2002:a5d:4c4f:: with SMTP id n15mr16563048wrt.137.1603709726445; Mon, 26 Oct 2020 03:55:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVe+9JTZp3qp5jWBddiD8ybrIJ6tz51eInzL2wyLjC2LjAT3R04O9eDZwCyFG6bb89m+Rmmg== X-Received: by 2002:a5d:4c4f:: with SMTP id n15mr16563021wrt.137.1603709726215; Mon, 26 Oct 2020 03:55:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eric Auger , Alex Williamson , qemu-block@nongnu.org, Fam Zheng , Max Reitz , Stefan Hajnoczi , Kevin Wolf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 04/19] block/nvme: Trace controller capabilities Date: Mon, 26 Oct 2020 11:54:49 +0100 Message-Id: <20201026105504.4023620-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026105504.4023620-1-philmd@redhat.com> References: <20201026105504.4023620-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Controllers have different capabilities and report them in the CAP register. We are particularly interested by the page size limits. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefan Hajnoczi --- block/nvme.c | 10 ++++++++++ block/trace-events | 1 + 2 files changed, 11 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index 5abd7257cac..3b6d3972ec2 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -720,6 +720,16 @@ static int nvme_init(BlockDriverState *bs, const char = *device, int namespace, * Initialization". */ =20 cap =3D le64_to_cpu(regs->cap); + trace_nvme_controller_capability("Maximum Queue Entries Supported", + NVME_CAP_MQES(cap)); + trace_nvme_controller_capability("Contiguous Queues Required", + NVME_CAP_CQR(cap)); + trace_nvme_controller_capability("Subsystem Reset Supported", + NVME_CAP_NSSRS(cap)); + trace_nvme_controller_capability("Memory Page Size Minimum", + NVME_CAP_MPSMIN(cap)); + trace_nvme_controller_capability("Memory Page Size Maximum", + NVME_CAP_MPSMAX(cap)); if (!NVME_CAP_CSS(cap)) { error_setg(errp, "Device doesn't support NVMe command set"); ret =3D -EINVAL; diff --git a/block/trace-events b/block/trace-events index 0e351c3fa3d..3f141dc6801 100644 --- a/block/trace-events +++ b/block/trace-events @@ -134,6 +134,7 @@ qed_aio_write_postfill(void *s, void *acb, uint64_t sta= rt, size_t len, uint64_t qed_aio_write_main(void *s, void *acb, int ret, uint64_t offset, size_t le= n) "s %p acb %p ret %d offset %"PRIu64" len %zu" =20 # nvme.c +nvme_controller_capability(const char *desc, uint64_t value) "%s: %"PRIu64 nvme_kick(void *s, int queue) "s %p queue %d" nvme_dma_flush_queue_wait(void *s) "s %p" nvme_error(int cmd_specific, int sq_head, int sqid, int cid, int status) "= cmd_specific %d sq_head %d sqid %d cid %d status 0x%x" --=20 2.26.2