From nobody Mon Nov 17 09:46:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603708216; cv=none; d=zohomail.com; s=zohoarc; b=C6gRqzIijsWlyvzLGyimVD6+rMzqWkYH4XE2hnxhNHATEZyhZCLz5nHiRQqpFlIFlBFSZ1TBp9mBT1lls1xrj6e6AuuE3teqqcDPOCB6UGxbeOi0M9/T6AF9tinm0/bzVM8xWUhrR7MmDSTHQZG6TG6bNLSL2kV4VMn3FiAyCws= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603708216; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9Zbrf/7MIKoxLr6GRVvazu/PJkW22ZqrIAHcrpYs15I=; b=JaSYdu2yXQCDOLd4nm0YvDkqHKnzRIsf3+tNeqcJeBElukVSYTdW88DX1649JXTTt63S0d5TpwEGdW6XcKQppkQqbdqVBpkZqDDec1rPBNdx+XDYSdnP+4wFp14TYVSs/W/1SD+FzuxlgVW0Vasaac+b1Rk9t/CXP6LX6REXJ4c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603708216733791.1795500247977; Mon, 26 Oct 2020 03:30:16 -0700 (PDT) Received: from localhost ([::1]:47488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWzlX-0000OZ-Cm for importer@patchew.org; Mon, 26 Oct 2020 06:30:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWzSR-0007yT-Fv for qemu-devel@nongnu.org; Mon, 26 Oct 2020 06:10:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:31123) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kWzSF-0007xD-DP for qemu-devel@nongnu.org; Mon, 26 Oct 2020 06:10:31 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-pO-bLKsXOou7oaYQtG7HJQ-1; Mon, 26 Oct 2020 06:10:11 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8FDA3188C136; Mon, 26 Oct 2020 10:10:10 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 493815C1DC; Mon, 26 Oct 2020 10:10:07 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C41181138468; Mon, 26 Oct 2020 11:10:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603707013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Zbrf/7MIKoxLr6GRVvazu/PJkW22ZqrIAHcrpYs15I=; b=Q7V6xsHu2SATIbaHFzvhUGdNLoHt+ePDYsntsh7BwCTYdOthAiQRiW/FggBnxD3tOrZPSE 5QVDJbVVuNoEh/SqjblON7+zIes8jKpkV1Xt21mVV1Y9oh3zEjLBEvMAhKpLZlxf63pktQ Jb0qP05yI31QaaDKOSBzgZcZapw9QKk= X-MC-Unique: pO-bLKsXOou7oaYQtG7HJQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 2/4] char: Factor out qemu_chr_print_types() Date: Mon, 26 Oct 2020 11:10:03 +0100 Message-Id: <20201026101005.2940615-3-armbru@redhat.com> In-Reply-To: <20201026101005.2940615-1-armbru@redhat.com> References: <20201026101005.2940615-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/25 21:03:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, marcandre.lureau@redhat.com, qemu-block@nongnu.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Kevin Wolf We'll want to call the same from a non-QemuOpts code path. Signed-off-by: Kevin Wolf Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Markus Armbruster Message-Id: <20201023161312.460406-3-kwolf@redhat.com> --- include/chardev/char.h | 1 + chardev/char.c | 16 ++++++++++------ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/include/chardev/char.h b/include/chardev/char.h index db42f0a8c6..3b91645081 100644 --- a/include/chardev/char.h +++ b/include/chardev/char.h @@ -212,6 +212,7 @@ void qemu_chr_be_update_read_handlers(Chardev *s, */ void qemu_chr_be_event(Chardev *s, QEMUChrEvent event); =20 +void qemu_chr_print_types(void); int qemu_chr_add_client(Chardev *s, int fd); Chardev *qemu_chr_find(const char *name); =20 diff --git a/chardev/char.c b/chardev/char.c index 78553125d3..4d188bfa6f 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -633,6 +633,15 @@ ChardevBackend *qemu_chr_parse_opts(QemuOpts *opts, Er= ror **errp) return backend; } =20 +void qemu_chr_print_types(void) +{ + g_autoptr(GString) str =3D g_string_new(""); + + chardev_name_foreach(help_string_append, str); + + qemu_printf("Available chardev backend types: %s\n", str->str); +} + Chardev *qemu_chr_new_from_opts(QemuOpts *opts, GMainContext *context, Error **errp) { @@ -644,12 +653,7 @@ Chardev *qemu_chr_new_from_opts(QemuOpts *opts, GMainC= ontext *context, char *bid =3D NULL; =20 if (name && is_help_option(name)) { - GString *str =3D g_string_new(""); - - chardev_name_foreach(help_string_append, str); - - qemu_printf("Available chardev backend types: %s\n", str->str); - g_string_free(str, true); + qemu_chr_print_types(); return NULL; } =20 --=20 2.26.2