From nobody Sat May 18 22:15:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603444128; cv=none; d=zohomail.com; s=zohoarc; b=diMnHG5RwK/WQbQCkZD+A11b3kdbqnfXo+oCVPUxwd2eMoYUWU6fbiycsFJyeRB+Y4fPHGcLl9YVNfUS0ujqXZlU9Wrd954Brkd1XYEY84AIeYfWOze7dQoHm9p2o/csx8dCHqiVG8+NdXBWSMf0cuGApOjKXY/w7FrJdxShPVk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603444128; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=bGehozWOyYnPhODUvXdRzkh+Yr5G8Nv7yQYe+wDM3Q8=; b=P5jF+/9gfwgA4KR+/ayWt0yCzqyoFu8gozN1joDgRd4LH2eiwtJOLXYgbuhsahAECgn1Xk1srEXF7IRAfivtXD4ekonUmp6i+8KbBb4YYSlcHzTo7OhPvp4pIbK8g4JbOunlhp2fRRu7bzBeV6EjfU5obKVxhwQcBLPSPrAn7W4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603444128691373.1929488467638; Fri, 23 Oct 2020 02:08:48 -0700 (PDT) Received: from localhost ([::1]:34992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVt42-0002ZK-Sr for importer@patchew.org; Fri, 23 Oct 2020 05:08:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVt3J-0001yW-CE for qemu-devel@nongnu.org; Fri, 23 Oct 2020 05:08:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kVt3F-0002tD-I5 for qemu-devel@nongnu.org; Fri, 23 Oct 2020 05:08:00 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-bxdQMCi2MZe8gK3lh16KOA-1; Fri, 23 Oct 2020 05:07:52 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF3681006CB1; Fri, 23 Oct 2020 09:07:51 +0000 (UTC) Received: from laptop.redhat.com (ovpn-12-21.pek2.redhat.com [10.72.12.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3D4C5D9CC; Fri, 23 Oct 2020 09:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603444075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bGehozWOyYnPhODUvXdRzkh+Yr5G8Nv7yQYe+wDM3Q8=; b=e+DgnR1iAP5waNxLACigFVjZKDSOhaeYvG+gKFlYVQOauatQQMqvdF06UFs7n3rnj2vX8N 02I539zXKbDHgeADyoAy6RxNlfvumlTHdHWGmCNbFT1DwRgOEGONgI+UGIpLkV6PXLoX0A /WEppBhm+9PaLnBwfkZXz/889L/JNKA= X-MC-Unique: bxdQMCi2MZe8gK3lh16KOA-1 From: Cindy Lu To: mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org Subject: [PATCH] virtio-net: Add check for mac address while peer is vdpa Date: Fri, 23 Oct 2020 17:07:43 +0800 Message-Id: <20201023090743.3023-1-lulu@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lulu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=lulu@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/23 01:44:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-stable@nongnu.org, Cindy Lu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Sometime vdpa get an all 0 mac address from the hardware, this will cause t= he traffic down So we add the check for this part. if we get an 0 mac address we will use the default mac address instead --- hw/net/virtio-net.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 9179013ac4..f1648fc47d 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -126,6 +126,7 @@ static void virtio_net_get_config(VirtIODevice *vdev, u= int8_t *config) VirtIONet *n =3D VIRTIO_NET(vdev); struct virtio_net_config netcfg; NetClientState *nc =3D qemu_get_queue(n->nic); + static const MACAddr zero =3D { .a =3D { 0, 0, 0, 0, 0, 0 } }; =20 int ret =3D 0; memset(&netcfg, 0 , sizeof(struct virtio_net_config)); @@ -151,7 +152,11 @@ static void virtio_net_get_config(VirtIODevice *vdev, = uint8_t *config) ret =3D vhost_net_get_config(get_vhost_net(nc->peer), (uint8_t *)&= netcfg, n->config_size); if (ret !=3D -1) { - memcpy(config, &netcfg, n->config_size); + if (memcmp(&netcfg.mac, &zero, sizeof(zero)) !=3D 0) { + memcpy(config, &netcfg, n->config_size); + } else { + error_report("Get an all zero mac address from hardware"); + } } } } --=20 2.21.3