From nobody Tue Feb 10 15:46:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) client-ip=209.85.128.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603301708; cv=none; d=zohomail.com; s=zohoarc; b=gWHIwwG2b7I2TQ9rJm6+YjNfnPKSKlwk+gjZjHJA9hCe5jnNnlCjrFMooHtyPiSyqoFRWEKn22UjyfYgcVB2dsl0D7EnPcoFZHaqAB790ni7ACWI8VWHI4SP4BLS2sbxWhurA/Cf9zduCZfjEUtqEfqs46T9+jXeCJWjTnlJZ8g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603301708; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5sS64GiSnmfXDwPIZCoMSvNhCEcsO6wIvPcArhV3+yo=; b=nV9A99QWh8wcEjrPOO3SigEs7nSJbX242L2y9j3A2k4unA6Bcq5RQjgdTh5IWOB7/scLMBX+JbS8lMcsqFnOhotG6ulNucTqZikuhFSyLAr/fXKvImM86vRfF8yOCa0fRs4bxvOsh/jtSKQ7z2zMDvbk5m2isC+2lV6bAjj4Y0w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.zohomail.com with SMTPS id 1603301708710610.1791629636394; Wed, 21 Oct 2020 10:35:08 -0700 (PDT) Received: by mail-wm1-f45.google.com with SMTP id q5so3460411wmq.0 for ; Wed, 21 Oct 2020 10:35:08 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id k6sm4770610wmk.16.2020.10.21.10.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 10:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5sS64GiSnmfXDwPIZCoMSvNhCEcsO6wIvPcArhV3+yo=; b=qqOIURXFloBEn82NoV8gQANlT9mqefCoMan0WiMmhQHNdPP0hGC6hLI7iPr3eV1HJV vczs4pQOxNgUUJJzMcCiK7BqLhv+5nWfXV9mw92A8wHX4pbOkJGTsqAw/4feQl4jwOJv IiwLdB8oZJSy09i+Px6Qmmi8cMVxw4sYmFeLJGcUg1xMFkRWaatDVwoKOaHymeh4zk2R i6Wmnc/XnidT0HCk+0LJUetrf6TIuJFjZtMCDaBskkx4DT7ikhoRQTGC0arPiTb/oU+w 1amfTjJ17V2L0SyyOah34UcZL/kSMCxl4WP1u0l7zzTE5P97jb3TZkN+YtksIlw9w6Gs rNWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5sS64GiSnmfXDwPIZCoMSvNhCEcsO6wIvPcArhV3+yo=; b=uBf8b033GaRrtyXgdG631LxksRDJLgt6EG/2VkLFmpryWYz4rqnmZH0KJmxJnYqANk TYuYPzJKveS28BZohoA4a9FT9QdxU+d+MJOLegXk913pkIPBR4T7nBdevTHlNeYm6GpC 1eTxmapP77ItFC3PkufDm+rjKsjWRd9J9PhxPtyz48mkrKtE9S65B3qbour6orqoBQmb 0g5uF7pAWoMHLS93m5DmjyXE3Nckhz04QYGdkXvsdgITTTG192U8ETxE8xU9vCXPTq6f VDjC01tnMO40wkmjPCmM5P6lZ5p/izsvfJoE6YRGQNTJLqSnq2GZH6G7cWZqTen0Ny3K qIhw== X-Gm-Message-State: AOAM5333fYnG/8NNWrdyQJaUG9oZAZln5IXD8LJuv5v3z/mwyd0CBj1c /b/mMPzovioVJXiIQuxwB2Vc3OMUJfY= X-Google-Smtp-Source: ABdhPJxELr3Os9sKHjCQIcYuZ2miiyJBdHWWbX0zykRyqwVxoDhrxTd+WhoTaGUjIMdkcz02f1Greg== X-Received: by 2002:a1c:4c05:: with SMTP id z5mr4666672wmf.122.1603301706778; Wed, 21 Oct 2020 10:35:06 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alexander Bulekov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-stable@nongnu.org, Prasad J Pandit Subject: [PULL 03/13] hw/sd/sdhci: Fix DMA Transfer Block Size field Date: Wed, 21 Oct 2020 19:34:40 +0200 Message-Id: <20201021173450.2616910-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201021173450.2616910-1-f4bug@amsat.org> References: <20201021173450.2616910-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The 'Transfer Block Size' field is 12-bit wide. See section '2.2.2. Block Size Register (Offset 004h)' in datasheet. Two different bug reproducer available: - https://bugs.launchpad.net/qemu/+bug/1892960 - https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=3D%2Fsdhci_oob_w= rite1 Cc: qemu-stable@nongnu.org Buglink: https://bugs.launchpad.net/qemu/+bug/1892960 Fixes: d7dfca0807a ("hw/sdhci: introduce standard SD host controller") Reported-by: Alexander Bulekov Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Prasad J Pandit Tested-by: Alexander Bulekov Message-Id: <20200901140411.112150-3-f4bug@amsat.org> --- hw/sd/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index ed717ab549b..c849c3d99b8 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1107,7 +1107,7 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val= , unsigned size) break; case SDHC_BLKSIZE: if (!TRANSFERRING_DATA(s->prnsts)) { - MASKED_WRITE(s->blksize, mask, value); + MASKED_WRITE(s->blksize, mask, extract32(value, 0, 12)); MASKED_WRITE(s->blkcnt, mask >> 16, value >> 16); } =20 --=20 2.26.2