From nobody Tue Feb 10 02:54:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.67 as permitted sender) client-ip=209.85.128.67; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f67.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1603301749; cv=none; d=zohomail.com; s=zohoarc; b=g+GHcUM4Vru1Iwro1M8SBlLwlJS5n5QOBzWH1jHgsEEgKm89vOI6uJczUtloxJs0TG9X4uyFB5ky+McE48g+KGgc0OupZYG5QYaYSUmViWOUvfZMbCjs3s+fe8FAy++mvJxCPfkkgfhRsXmGsGOpCKjXdGUs8BSZ8WeWWEngZQc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603301749; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=p6WWIsaS0I3UntqPKdZpY4UhujIkCcQKP7e4gj992fw=; b=noPKQugtT0teGgX9X1eB4wOcLEUHzdKh9n5QKbkL7c1QvOVys3Ga4KtdIccOUYtfmmG2cUgwPKVZzUtD+FNLiZDY1kzQn6pBFajYZw3+7FMmHuNX+gw9Gf3vrTc6vG3T1GoEeBCRDyHS282QPZY/pW6v4U+QUeQkYhqQcRp84UQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.zohomail.com with SMTPS id 1603301749729450.05664227906425; Wed, 21 Oct 2020 10:35:49 -0700 (PDT) Received: by mail-wm1-f67.google.com with SMTP id c77so2990258wmd.4 for ; Wed, 21 Oct 2020 10:35:49 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id j7sm5150707wrn.81.2020.10.21.10.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 10:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p6WWIsaS0I3UntqPKdZpY4UhujIkCcQKP7e4gj992fw=; b=XMcvC8yPcH2DqQ0sZMxPYfcTa/pHDgm6brwx7QDW247J4Q4vNCJOSJ0RlfHoRqmECS UBgK71S/JGHsz1wGj4e2hO0wVXjqC8c4cADVY1S1liSc8fxDiNSFAaAgfIMGZYl5oEad ew2ljuNIQp/xhDjs4LXuKvzWZfaoMaJGwjv93v8aBycHV+El5i7DfNLunIILae/oBmJD wCfGbqWy6Vg/U8ccDwF+HZrCttruQIfq3aRUjcdvHHULjtUtLotQe8CH074eax1UUPNt VaHrNcuLoT+Eo+PXp/4XfMheVI20OgAlU4vAE+mdYrh6VrzopoAkGx5nZxmKL69eKACk 3Ksw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=p6WWIsaS0I3UntqPKdZpY4UhujIkCcQKP7e4gj992fw=; b=uGs87KDZrvqHkPnds4urkTYLpsybOD2+0145gm9txXw0ecHmwz0LLFqwBJyEMYypY1 OUeOrNLjxDGQdidzUZyh2duO19rbXBAzYrtGUQwg6OL7zbhpJ4rzQJ8Irz5FnLfVov4O 1ZcBu+za+SugJ2KSWfrzS8tQIvpO9+CoyDxt9MEwzWZuCrlBSdTe7jqvvypFQQcf+hUY nGFuEO9PQNZi25kQO/p5AJYj2Pd4SMp/jjRLCO4P/uEGj/U7Du1HJ+vrWQc8JPg6PFQZ XGHV3+mVBy33tZ9vQ8XQMY1mg5sAqzIPfKNuhBrCDYZAdvOLEJW6+RbS7Ah+1e5J8LtW QgIA== X-Gm-Message-State: AOAM532qV36pE9fHzXXLCdluQzyDzf2/eJs0Ym/JF7qpVH4NU5KTbfNY Jba1xi67G2M2/1c/bCG/3lp5rntMXEI= X-Google-Smtp-Source: ABdhPJxo1UigovYRWF8fiNhKTbGbLDxlaK/ujDfESF2lS7IbEhMIoRZP0vI1NAl/iZU+Chx33VrxvA== X-Received: by 2002:a1c:2d53:: with SMTP id t80mr4451258wmt.125.1603301747614; Wed, 21 Oct 2020 10:35:47 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alexander Bulekov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 12/13] hw/sd/sdcard: Do not attempt to erase out of range addresses Date: Wed, 21 Oct 2020 19:34:49 +0200 Message-Id: <20201021173450.2616910-13-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201021173450.2616910-1-f4bug@amsat.org> References: <20201021173450.2616910-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) While the Spec v3 is not very clear, v6 states: If the host provides an out of range address as an argument to CMD32 or CMD33, the card shall indicate OUT_OF_RANGE error in R1 (ERX) for CMD38. If an address is out of range, do not attempt to erase it: return R1 with the error bit set. Buglink: https://bugs.launchpad.net/qemu/+bug/1895310 Reported-by: Alexander Bulekov Signed-off-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Alexander Bulekov Message-Id: <20201015063824.212980-6-f4bug@amsat.org> --- hw/sd/sd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index ee7b64023aa..4454d168e2f 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -766,6 +766,13 @@ static void sd_erase(SDState *sd) erase_end *=3D 512; } =20 + if (sd->erase_start > sd->size || sd->erase_end > sd->size) { + sd->card_status |=3D OUT_OF_RANGE; + sd->erase_start =3D INVALID_ADDRESS; + sd->erase_end =3D INVALID_ADDRESS; + return; + } + erase_start =3D sd_addr_to_wpnum(erase_start); erase_end =3D sd_addr_to_wpnum(erase_end); sd->erase_start =3D INVALID_ADDRESS; --=20 2.26.2