From nobody Mon Feb 9 04:59:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603224259; cv=none; d=zohomail.com; s=zohoarc; b=IqIz3M85i7zqVCBzvWk1iybHuuGRfCXF1x2hwfwH8CEfI4GYrCtBxdI7PWKESSiwTPIdxnkQLlPBlb5hFQ4+K2OVNxFVtYiPJ5paazLbwreNvTjr6zrlati1eyOIyy5W/SFPihjQOwmLIsqGsZebaxSLGoJFOeeaVTIhWZ/rmj0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603224259; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nSCNn6U47unXRp32ExTx0m5GJHVMstFbnczz9MU5ByM=; b=fwPx+IWlDVWQrgyWvy/3gVtdv8VYLL3WfiqxzfcfhYYzoRlwWWgiqo6ZfAX1tB3Gy6y3ndyjXX2E78eOXqiLp60mmT/0KAPx1GpegGsTjPTiN371LRm7PVnStshPHndUsYGFeueKiaKZcDamDJl66/GwT0RdMPuSZtg4kPIv8v0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603224259254956.6569239309449; Tue, 20 Oct 2020 13:04:19 -0700 (PDT) Received: from localhost ([::1]:41410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUxrm-0004p0-Gr for importer@patchew.org; Tue, 20 Oct 2020 16:04:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUxqR-0003Yt-Mm for qemu-devel@nongnu.org; Tue, 20 Oct 2020 16:02:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUxqM-0004GG-FO for qemu-devel@nongnu.org; Tue, 20 Oct 2020 16:02:55 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-517-lrGGcsh4Pt-s1prRpVd8Dg-1; Tue, 20 Oct 2020 16:02:47 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B538387505D; Tue, 20 Oct 2020 20:02:46 +0000 (UTC) Received: from scv.redhat.com (ovpn-115-172.rdu2.redhat.com [10.10.115.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15CBB1001281; Tue, 20 Oct 2020 20:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603224169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nSCNn6U47unXRp32ExTx0m5GJHVMstFbnczz9MU5ByM=; b=RqHyAtnVq/yn/Ek++lezkW7a7svyED+RV9ul1F39lSnK+BlNYX3gXKb5dvAZnmi2AyB6dR Ui8W5+3ysEXOerXCRq+JiusX0bjOFCnXUHkd2fuvH+Xs34G8tqJkiC98yV5m/TN92HGNeI Q0iQjUMGwFc4Kk06DPgLz1uLqgBYEJg= X-MC-Unique: lrGGcsh4Pt-s1prRpVd8Dg-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH 3/3] ide: clear SRST after SRST finishes Date: Tue, 20 Oct 2020 16:02:42 -0400 Message-Id: <20201020200242.1497705-4-jsnow@redhat.com> In-Reply-To: <20201020200242.1497705-1-jsnow@redhat.com> References: <20201020200242.1497705-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 01:16:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The SRST protocol states that after diagnostics are complete and the status is posted, we should clear the SRST bit if it should so happen to be set. The reset method itself should handle this, but just in case -- make our intention explicit here. Signed-off-by: John Snow --- hw/ide/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index 98cea7ad45..e85821637c 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2268,6 +2268,8 @@ static void ide_bus_perform_srst(void *opaque) s =3D &bus->ifs[i]; ide_perform_srst(s); } + + bus->cmd &=3D ~IDE_CTRL_RESET; } =20 void ide_ctrl_write(void *opaque, uint32_t addr, uint32_t val) --=20 2.26.2