From nobody Mon Feb 9 20:35:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) client-ip=209.85.221.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1603218016; cv=none; d=zohomail.com; s=zohoarc; b=Abl4VnTmOhziKtwUluTlLvjM/Ee72mkb62hM4TFId0RbLz25fC3Wiptyhjba08yQLj9WBOj43wXSWuF7iEOzoQPNiI1DQzHcnT71EGlxOiOVRB0QgCGyws6hWcuqyfqsFUPU7MiFT6KGp+GzZA+9qbb1iRW4e8pyPUIxWQs6+6s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603218016; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6rbwkEpyi/KBr1JflrTSauoQCOoSH88ZHs4jFJdadLY=; b=hK2WHF3pmvMIrm0RK4QaJFO3NK6V0fh566f3Ikj1KCgERWMgot2dA010pRxFGtY/37UpS+mX8zcPhlpeN7/OcJmWK3Gn6taa4fh/4/csk2sejXq4yJ2usKqdsCOuivz2aSf3JdEjSvTHBQrjQCFF//AJo1ASbppIgv2itgafmfY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.zohomail.com with SMTPS id 16032180166391014.0253294930228; Tue, 20 Oct 2020 11:20:16 -0700 (PDT) Received: by mail-wr1-f66.google.com with SMTP id b8so3374728wrn.0 for ; Tue, 20 Oct 2020 11:20:16 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id f14sm4254328wrr.80.2020.10.20.11.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 11:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6rbwkEpyi/KBr1JflrTSauoQCOoSH88ZHs4jFJdadLY=; b=n24E9+xhkh9MrByR5MozzwrcTs0OvFhmmKqxdRGH9X2ffwdz+R9EfGxGSYqXiyU7jn vxbMoEJLQHBatb6jS5goc3XWgDibMd5rdlb/vUZuxKcNutZtdn1if9Y3P0HUYK4DsQTs 15MHj3PHlwaP2ZaduFeJIBeam3iXd5mw4ai5oXzs2wjQP4Q4SZovzWVs8fRFEtKomp7P fXq48Z4SRGW5SnUBVKaduriygCItDskxD9xHW6qNmcAxXw8FJ32eFbOYRHZ7lOF48xCn ZBiy3YwINRrPx3nWTDuMAqmkcT2ydCAt+WRPQ3YHGM9grb1e8rqFiMVGXfcf6il16Cw9 dY8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=6rbwkEpyi/KBr1JflrTSauoQCOoSH88ZHs4jFJdadLY=; b=OQ23oNNH40OLiG53kQe1tT5DkhQr2q2Y5pL4KQBUQjyOEazcJbroc3+AL1gCAF2GkU E6gHwgct1KizQC5MxUEc7hTDol9cL4QCtOT7Dlh8gT5WfQXA5RjXlozRsDrZ9FnT/cSX amW8RLPJbvthZXyr0KhrNHErfizqed1MijwiEx5kPoqkneFbo3Y1v6PkbN3tHQF+VI8l eFg/XsLDuJdrJHWQj5LKrHr8wIGp2eKkABPSchfpVGM6JNc2l0zXJVUErw1csKwS5YnA OvhdTSXiXHpk5oWhn6VaWz7Iiqyc4gQlSTbHYzNUz2qBEkMpRZt2QbIXcNEENCobYdLy bk0A== X-Gm-Message-State: AOAM533lLzRaDx1OeIJYJQALDoi247nPAw02gkttv0YNc1jQzig10/f6 y78hmPMjG7dly1k3QjCWEGE= X-Google-Smtp-Source: ABdhPJzvwZsia23Py+FB4CSB7KBEzY4PeneAkRECN47o3hJO+3qvV26MpElNdqBbCuWPZ0QFPnWi9g== X-Received: by 2002:adf:ec0e:: with SMTP id x14mr5407603wrn.204.1603218015232; Tue, 20 Oct 2020 11:20:15 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , Luc Michel , Damien Hedde , Eduardo Habkost , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Luc Michel , Alistair Francis Subject: [PATCH 1/4] qdev-monitor: Display frequencies scaled to SI unit Date: Tue, 20 Oct 2020 20:20:05 +0200 Message-Id: <20201020182008.2240590-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201020182008.2240590-1-f4bug@amsat.org> References: <20201020182008.2240590-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Since commit 9f2ff99c7f2 ("qdev-monitor: print the device's clock with info qtree") we can display the clock frequencies in the monitor. Use the recently introduced freq_to_str() to display the frequencies using the closest SI unit (human friendlier). Before: (qemu) info qtree [...] dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=3D3.333333e+07 mmio 00000000f8000000/0000000000001000 After: dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=3D33.3 MHz mmio 00000000f8000000/0000000000001000 Reviewed-by: Luc Michel Reviewed-by: Damien Hedde Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- softmmu/qdev-monitor.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c index bcfb90a08f3..1c5b509aea2 100644 --- a/softmmu/qdev-monitor.c +++ b/softmmu/qdev-monitor.c @@ -747,11 +747,13 @@ static void qdev_print(Monitor *mon, DeviceState *dev= , int indent) } } QLIST_FOREACH(ncl, &dev->clocks, node) { - qdev_printf("clock-%s%s \"%s\" freq_hz=3D%e\n", + g_autofree char *freq =3D NULL; + + freq =3D freq_to_str(clock_get_hz(ncl->clock)); + qdev_printf("clock-%s%s \"%s\" freq_hz=3D%s\n", ncl->output ? "out" : "in", ncl->alias ? " (alias)" : "", - ncl->name, - CLOCK_PERIOD_TO_HZ(1.0 * clock_get(ncl->clock))); + ncl->name, freq); } class =3D object_get_class(OBJECT(dev)); do { --=20 2.26.2