From nobody Sat Feb 7 06:20:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603214699; cv=none; d=zohomail.com; s=zohoarc; b=ZYKF7rgitu/zhkCVCnlZpZbGh9Hvpsme/eVv1/Y8EeBRNXmpApKasqVNxaXWdZhkwri0FEKkjf7zR/4FuAqkfHL7UWFvQ0DqZEpoctKuiP6SKMKcCQ5y0etn657UGa8zCaNGvBfh0EPtgEa3qf0sY1Spb8cWTHgouA6CHI4Mjlg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603214699; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=2LI/wka4VE+L12Rc09SXXqxJoCU9ZXTyFpCDUD5ks9I=; b=Wuei+DJD3luuw2DcefTMyd9NmJQ7YPSriX99FlajbHVoz2NI8FFaEvqxxohhH/SfUn6//+XRiyYugrRc4X/58JNiUvzCit2Dx/T+qw1oQE6fz7DFkl0LeuIrpdJqMF0rkivEpkbfBEU9p/UiF26hALU0KPNqzGYLGp4uemn9Zbw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1603214699890823.5510914170646; Tue, 20 Oct 2020 10:24:59 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-4DANXmSZMbOj5qtfY5-rIg-1; Tue, 20 Oct 2020 13:24:57 -0400 Received: by mail-wm1-f72.google.com with SMTP id s25so697636wmj.7 for ; Tue, 20 Oct 2020 10:24:57 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id v9sm3550439wmh.23.2020.10.20.10.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 10:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603214699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2LI/wka4VE+L12Rc09SXXqxJoCU9ZXTyFpCDUD5ks9I=; b=VLfqR1jNJ/9JtMKM1G4C29ZQCoB8ZzAhl4gd38VzwaUAJJtd6pYrW0ydfo3PUl81bRYz59 3l1gy0l026ZmIbKjq025DzJnkR93TebQs2cADukKyUQX9qwTxx6VOavHOAFcW7XPlrsRsU k4xtBpVHRz1/aLFLW+wVaA05kDm8KGQ= X-MC-Unique: 4DANXmSZMbOj5qtfY5-rIg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2LI/wka4VE+L12Rc09SXXqxJoCU9ZXTyFpCDUD5ks9I=; b=VEBf6l7J0KHQnrG5M/weI0/EDit8sgmdM34apaHk8jOJovhf1RnpliCyk33pAsq4rS AIhozudvhRTc0Kovskmfd5XwkXLKcgIvlkwXFFtOlwCcHdyKLLm9l3I7qmktqYQ+S0rG yBkVmXyrTozLpBKcKcSlEq/aDBU46f9d2SSQM9ItuJaj0H79PfLMy8bcFjq7IXjhR6Fl 5Qh4IHVjdtF6ZP4Iw3WLegLSYcPQkxfo71PLRMFqvpz9BW+jm9mikF8/V3skCP89eBAv QZLqQNN3AgDMaoD2twkS7j1+6yZW3ltZzanbZiM1fO0DYHxO/dHUNI2T26FW1Dw0tUo3 V1uw== X-Gm-Message-State: AOAM531jAwzlEwGMzwYOENzJJ7Hh+MlIw7f+y6icgxS8l8xZdD30qPd5 xAIXd/sCMHPMUismdL5VoexpEjb5Zh5j4Q0LhfnftxchOjFx/V73WVsuI7lF2KmjP5OikNGlzEf jBNRdGPdAZhS/Nw== X-Received: by 2002:a05:600c:296:: with SMTP id 22mr3943797wmk.134.1603214696116; Tue, 20 Oct 2020 10:24:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeIB4TYfcnfxJqfsuyXCCVmFl0lEuz5mTeZ2Scrwh2ag0Nbi1WMje8I8bII3WNJdYbqt9MuQ== X-Received: by 2002:a05:600c:296:: with SMTP id 22mr3943783wmk.134.1603214695879; Tue, 20 Oct 2020 10:24:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , Alex Williamson , Stefan Hajnoczi , Max Reitz , Fam Zheng , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 05/16] util/vfio-helpers: Trace PCI I/O config accesses Date: Tue, 20 Oct 2020 19:24:17 +0200 Message-Id: <20201020172428.2220726-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201020172428.2220726-1-philmd@redhat.com> References: <20201020172428.2220726-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We sometime get kernel panic with some devices on Aarch64 hosts. Alex Williamson suggests it might be broken PCIe root complex. Add trace event to record the latest I/O access before crashing. In case, assert our accesses are aligned. Reviewed-by: Fam Zheng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefan Hajnoczi --- util/vfio-helpers.c | 8 ++++++++ util/trace-events | 2 ++ 2 files changed, 10 insertions(+) diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c index bce2cdb2f3c..ac9cc20ce29 100644 --- a/util/vfio-helpers.c +++ b/util/vfio-helpers.c @@ -228,6 +228,10 @@ static int qemu_vfio_pci_read_config(QEMUVFIOState *s,= void *buf, { int ret; =20 + trace_qemu_vfio_pci_read_config(buf, ofs, size, + s->config_region_info.offset, + s->config_region_info.size); + assert(QEMU_IS_ALIGNED(s->config_region_info.offset + ofs, size)); do { ret =3D pread(s->device, buf, size, s->config_region_info.offset += ofs); } while (ret =3D=3D -1 && errno =3D=3D EINTR); @@ -238,6 +242,10 @@ static int qemu_vfio_pci_write_config(QEMUVFIOState *s= , void *buf, int size, int { int ret; =20 + trace_qemu_vfio_pci_write_config(buf, ofs, size, + s->config_region_info.offset, + s->config_region_info.size); + assert(QEMU_IS_ALIGNED(s->config_region_info.offset + ofs, size)); do { ret =3D pwrite(s->device, buf, size, s->config_region_info.offset = + ofs); } while (ret =3D=3D -1 && errno =3D=3D EINTR); diff --git a/util/trace-events b/util/trace-events index 19f03f14a33..b697d2d5429 100644 --- a/util/trace-events +++ b/util/trace-events @@ -86,3 +86,5 @@ qemu_vfio_do_mapping(void *s, void *host, size_t size, ui= nt64_t iova) "s %p host qemu_vfio_dma_map(void *s, void *host, size_t size, bool temporary, uint64= _t *iova) "s %p host %p size 0x%zx temporary %d iova %p" qemu_vfio_dma_unmap(void *s, void *host) "s %p host %p" qemu_vfio_iommu_iova_pgsizes(uint64_t iova_pgsizes) "iommu page size bitma= sk: 0x%08"PRIx64 +qemu_vfio_pci_read_config(void *buf, int ofs, int size, uint64_t region_of= s, uint64_t region_size) "read cfg ptr %p ofs 0x%x size %d (region ofs 0x%"= PRIx64" size %"PRId64")" +qemu_vfio_pci_write_config(void *buf, int ofs, int size, uint64_t region_o= fs, uint64_t region_size) "write cfg ptr %p ofs 0x%x size %d (region ofs 0x= %"PRIx64" size %"PRId64")" --=20 2.26.2