From nobody Sat Feb 7 06:21:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603214687; cv=none; d=zohomail.com; s=zohoarc; b=Dg/kS6jUWXsgUKuKsP0ycOlCS22D+liVA/MmEjG8doYiuEWXZOTv+jmaDcLcuGf2/kz+d8W7XL2+kc4Gk1nYzxtDWPHv7YPRq2qH13dyt6hjlDGyEH4H7OjRqXTPwfaWfhTLLrKSMnNl4s8OmAEv2oxZHg2fFkwQYH1DeuKvtFQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603214687; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=2wTH3wc2I2rRV2/wVEdRkSxgLY/gmXgNT0mExNm6R6I=; b=RS1YWBeDKbjo/QOgG3hoxuQAsaPSzDNt8khCDClGtcvseV8Cskc2XeAZTjtyb+xhfm7h5A8Her6aveG8u+uvEJDxGsq8Pq34t6uO+stwWcLSaJxZnMQmKwXwaYsY9NCnv9ALSv8SDBO0m5SZ5r+sYJRC6BcgFxmuhLGd52FpyO8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1603214687644590.1251313040152; Tue, 20 Oct 2020 10:24:47 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-2z5wZyYLPnqSTubYwPSnrA-1; Tue, 20 Oct 2020 13:24:42 -0400 Received: by mail-wm1-f69.google.com with SMTP id z7so702282wmi.3 for ; Tue, 20 Oct 2020 10:24:42 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id y185sm3676545wmb.29.2020.10.20.10.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 10:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603214684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2wTH3wc2I2rRV2/wVEdRkSxgLY/gmXgNT0mExNm6R6I=; b=FXn+604HCbVLxbVk0I8eM+rbX9txiBSyra9we7o6Mrva2qiqOJI6djaw5+keBZWkJzkBmv TcjZ01XDTGneJ7FBtsiw1nWWIEgem1FD8FRJMK6MsvRzTDyboXCYc9cu+tFP8qphPwM3Sq 6njpoN156BKMoz79CnvEP+HH0Zahwjg= X-MC-Unique: 2z5wZyYLPnqSTubYwPSnrA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2wTH3wc2I2rRV2/wVEdRkSxgLY/gmXgNT0mExNm6R6I=; b=RlhSXQLePamrzR2fQb+erjEXHg9jIsa2V23X5z7ak1jOXs3Qa6Lfrmdiz5sSpIX01h RFFs1v3FhjEDs1+B/A7dLW94ff6fxGmkjyUAm9bjNI/dKOa4hPMInxJ7IRDN/woyq88u wDkW6CGJkD9su5KMg6beqr9krLYzngVbNnc0bZ7+rrVhssxATVFdrCJFYJqMweQOFUD3 hZpgOjDR4WulV7Gaf/n+h60Wp6ZVr8N0U8rqUY6DuIEkwhTOIfYwO2Tyd/ljCCdntfbB HdqYNXnNoELrAXfGo0xmZhqZLHKp5GtZCLQXAIR0AGsRRL+M2xi98VphtGppAqs0GuKw yXFA== X-Gm-Message-State: AOAM533M9yzmRIvnTAJITS95Z00XeEEBXZLiU7CJhabEsCLjwufaZ7zS pyq+g+M974V2e+1f97oz/ujK9R7veFlBkbQSYHoZA9B9mLcVMmU+MYk5l1yM0QVzqJ1dFW+AUfM qAf18ITRAoDPXJg== X-Received: by 2002:adf:e412:: with SMTP id g18mr4641260wrm.211.1603214681014; Tue, 20 Oct 2020 10:24:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBNhKVmJ/kwz/H/9cX3uBa72fxsg1FHIIl+2JBiGA8x9BVJUC4kBEDX0YVj0zyn0Xb8jdImA== X-Received: by 2002:adf:e412:: with SMTP id g18mr4641246wrm.211.1603214680850; Tue, 20 Oct 2020 10:24:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , Alex Williamson , Stefan Hajnoczi , Max Reitz , Fam Zheng , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 02/16] util/vfio-helpers: Improve reporting unsupported IOMMU type Date: Tue, 20 Oct 2020 19:24:14 +0200 Message-Id: <20201020172428.2220726-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201020172428.2220726-1-philmd@redhat.com> References: <20201020172428.2220726-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Change the confuse "VFIO IOMMU check failed" error message by the explicit "VFIO IOMMU Type1 is not supported" once. Example on POWER: $ qemu-system-ppc64 -drive if=3Dnone,id=3Dnvme0,file=3Dnvme://0001:01:00.0= /1,format=3Draw qemu-system-ppc64: -drive if=3Dnone,id=3Dnvme0,file=3Dnvme://0001:01:00.0/= 1,format=3Draw: VFIO IOMMU Type1 is not supported Suggested-by: Alex Williamson Reviewed-by: Fam Zheng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefan Hajnoczi --- util/vfio-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c index c469beb0616..14a549510fe 100644 --- a/util/vfio-helpers.c +++ b/util/vfio-helpers.c @@ -300,7 +300,7 @@ static int qemu_vfio_init_pci(QEMUVFIOState *s, const c= har *device, } =20 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) { - error_setg_errno(errp, errno, "VFIO IOMMU check failed"); + error_setg_errno(errp, errno, "VFIO IOMMU Type1 is not supported"); ret =3D -EINVAL; goto fail_container; } --=20 2.26.2