From nobody Sun Feb 8 05:47:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603208493; cv=none; d=zohomail.com; s=zohoarc; b=DDWosMXEMGhlxSPiONhrQJqKGLwoz/P0hcA5BW7G1ee7BCsVKubMgUjQ5qdxfB5jjeKwI40rwAj93E0lsv6TKwetX33ZOh30AnSeFGrT860/bqMQ4P7FSOmBiY8KOZlZvdmSU18vrNOrDv3BfOkxvq9bxLRY/tCIazLAIhm6oQI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603208493; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=UBOl59CC6PSV0y+gfj/cKx84JPBfLEjyiObAXqSlGr4=; b=ia2gxkPZ69ZtDicnqHPs2W8vI0x+pmWjxMeCscxN5G6hw9/qubz5Kly9LT1Aqsz8uTsyhmtMLVxLfLlhxMlfbwzRCoOZIK1FMoPDRpp+ULbvGp1zFH+itvQvENAf15AO47/t8FUZhXc1f/iXxCxeaL/uZewoiz/UdzLesaWzP60= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603208493072159.58731246145953; Tue, 20 Oct 2020 08:41:33 -0700 (PDT) Received: from localhost ([::1]:55448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUtlU-0008LK-BM for importer@patchew.org; Tue, 20 Oct 2020 11:41:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUtjm-0006di-Cb for qemu-devel@nongnu.org; Tue, 20 Oct 2020 11:39:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40900) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUtjk-0001QN-IU for qemu-devel@nongnu.org; Tue, 20 Oct 2020 11:39:46 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-dvCEExDBMC2XYO8esT529Q-1; Tue, 20 Oct 2020 11:39:40 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 029B518A8224; Tue, 20 Oct 2020 15:39:39 +0000 (UTC) Received: from thuth.com (dhcp-192-238.str.redhat.com [10.33.192.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 170925B4B3; Tue, 20 Oct 2020 15:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603208383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=UBOl59CC6PSV0y+gfj/cKx84JPBfLEjyiObAXqSlGr4=; b=R5alIm209h7eL3pZYdMY990m0aSOmxbOrnJuhZPNO36IY6kbIN5lSMF7FDLDRI7cE7FPP1 pHuXgzJOVqZeW9MT2weNt2K+mdAS3ga/CPtO+C7xzn0qiCDc8oolAZmx52QFd7hM7iA4TI /iA+4XGtAmlxqE8PYTBYyncpzauunjU= X-MC-Unique: dvCEExDBMC2XYO8esT529Q-1 From: Thomas Huth To: Yoshinori Sato , qemu-devel@nongnu.org Subject: [PATCH 1/3] hw/timer/sh_timer: Coding style clean-up Date: Tue, 20 Oct 2020 17:39:33 +0200 Message-Id: <20201020153935.54315-2-thuth@redhat.com> In-Reply-To: <20201020153935.54315-1-thuth@redhat.com> References: <20201020153935.54315-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 01:16:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Magnus Damm Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Replace TAB characters with spaces, put code after case-statement on separate lines and add some curly braces in related lines to keep checkpatch.pl happy. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/timer/sh_timer.c | 89 +++++++++++++++++++++++++++++---------------- 1 file changed, 57 insertions(+), 32 deletions(-) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index bb0e1c8ee5..b09e30f938 100644 --- a/hw/timer/sh_timer.c +++ b/hw/timer/sh_timer.c @@ -117,35 +117,55 @@ static void sh_timer_write(void *opaque, hwaddr offse= t, case 2: freq >>=3D 6; break; case 3: freq >>=3D 8; break; case 4: freq >>=3D 10; break; - case 6: - case 7: if (s->feat & TIMER_FEAT_EXTCLK) break; - default: hw_error("sh_timer_write: Reserved TPSC value\n"); break; + case 6: + case 7: + if (s->feat & TIMER_FEAT_EXTCLK) { + break; + } + default: + hw_error("sh_timer_write: Reserved TPSC value\n"); + break; } switch ((value & TIMER_TCR_CKEG) >> 3) { - case 0: break; + case 0: + break; case 1: case 2: - case 3: if (s->feat & TIMER_FEAT_EXTCLK) break; - default: hw_error("sh_timer_write: Reserved CKEG value\n"); break; + case 3: + if (s->feat & TIMER_FEAT_EXTCLK) { + break; + } + default: + hw_error("sh_timer_write: Reserved CKEG value\n"); + break; } switch ((value & TIMER_TCR_ICPE) >> 6) { - case 0: break; + case 0: + break; case 2: - case 3: if (s->feat & TIMER_FEAT_CAPT) break; - default: hw_error("sh_timer_write: Reserved ICPE value\n"); break; + case 3: + if (s->feat & TIMER_FEAT_CAPT) { + break; + } + default: + hw_error("sh_timer_write: Reserved ICPE value\n"); + break; } - if ((value & TIMER_TCR_UNF) =3D=3D 0) + if ((value & TIMER_TCR_UNF) =3D=3D 0) { s->int_level =3D 0; + } =20 - value &=3D ~TIMER_TCR_UNF; + value &=3D ~TIMER_TCR_UNF; =20 - if ((value & TIMER_TCR_ICPF) && (!(s->feat & TIMER_FEAT_CAPT))) + if ((value & TIMER_TCR_ICPF) && (!(s->feat & TIMER_FEAT_CAPT))) { hw_error("sh_timer_write: Reserved ICPF value\n"); + } =20 - value &=3D ~TIMER_TCR_ICPF; /* capture not supported */ + value &=3D ~TIMER_TCR_ICPF; /* capture not supported */ =20 - if (value & TIMER_TCR_RESERVED) + if (value & TIMER_TCR_RESERVED) { hw_error("sh_timer_write: Reserved TCR bits set\n"); + } s->tcr =3D value; ptimer_set_limit(s->timer, s->tcor, 0); ptimer_set_freq(s->timer, freq); @@ -158,8 +178,8 @@ static void sh_timer_write(void *opaque, hwaddr offset, case OFFSET_TCPR: if (s->feat & TIMER_FEAT_CAPT) { s->tcpr =3D value; - break; - } + break; + } default: hw_error("sh_timer_write: Bad offset %x\n", (int)offset); } @@ -241,8 +261,9 @@ static uint64_t tmu012_read(void *opaque, hwaddr offset, #endif =20 if (offset >=3D 0x20) { - if (!(s->feat & TMU012_FEAT_3CHAN)) - hw_error("tmu012_write: Bad channel offset %x\n", (int)offset); + if (!(s->feat & TMU012_FEAT_3CHAN)) { + hw_error("tmu012_write: Bad channel offset %x\n", (int)offset); + } return sh_timer_read(s->timer[2], offset - 0x20); } =20 @@ -272,33 +293,36 @@ static void tmu012_write(void *opaque, hwaddr offset, #endif =20 if (offset >=3D 0x20) { - if (!(s->feat & TMU012_FEAT_3CHAN)) - hw_error("tmu012_write: Bad channel offset %x\n", (int)offset); + if (!(s->feat & TMU012_FEAT_3CHAN)) { + hw_error("tmu012_write: Bad channel offset %x\n", (int)offset); + } sh_timer_write(s->timer[2], offset - 0x20, value); - return; + return; } =20 if (offset >=3D 0x14) { sh_timer_write(s->timer[1], offset - 0x14, value); - return; + return; } =20 if (offset >=3D 0x08) { sh_timer_write(s->timer[0], offset - 0x08, value); - return; + return; } =20 if (offset =3D=3D 4) { sh_timer_start_stop(s->timer[0], value & (1 << 0)); sh_timer_start_stop(s->timer[1], value & (1 << 1)); - if (s->feat & TMU012_FEAT_3CHAN) + if (s->feat & TMU012_FEAT_3CHAN) { sh_timer_start_stop(s->timer[2], value & (1 << 2)); - else - if (value & (1 << 2)) + } else { + if (value & (1 << 2)) { hw_error("tmu012_write: Bad channel\n"); + } + } =20 - s->tstr =3D value; - return; + s->tstr =3D value; + return; } =20 if ((s->feat & TMU012_FEAT_TOCR) && offset =3D=3D 0) { @@ -314,8 +338,8 @@ static const MemoryRegionOps tmu012_ops =3D { =20 void tmu012_init(MemoryRegion *sysmem, hwaddr base, int feat, uint32_t freq, - qemu_irq ch0_irq, qemu_irq ch1_irq, - qemu_irq ch2_irq0, qemu_irq ch2_irq1) + qemu_irq ch0_irq, qemu_irq ch1_irq, + qemu_irq ch2_irq0, qemu_irq ch2_irq1) { tmu012_state *s; int timer_feat =3D (feat & TMU012_FEAT_EXTCLK) ? TIMER_FEAT_EXTCLK : 0; @@ -324,9 +348,10 @@ void tmu012_init(MemoryRegion *sysmem, hwaddr base, s->feat =3D feat; s->timer[0] =3D sh_timer_init(freq, timer_feat, ch0_irq); s->timer[1] =3D sh_timer_init(freq, timer_feat, ch1_irq); - if (feat & TMU012_FEAT_3CHAN) + if (feat & TMU012_FEAT_3CHAN) { s->timer[2] =3D sh_timer_init(freq, timer_feat | TIMER_FEAT_CAPT, - ch2_irq0); /* ch2_irq1 not supported */ + ch2_irq0); /* ch2_irq1 not supported */ + } =20 memory_region_init_io(&s->iomem, NULL, &tmu012_ops, s, "timer", 0x100000000ULL); --=20 2.18.2 From nobody Sun Feb 8 05:47:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603208513; cv=none; d=zohomail.com; s=zohoarc; b=MFxWzZY5fo41zLjfFWZC/71RyxODUu8QsvvZu33iL2xDVMtw7EdFXkXc+VVgw1GPxTUSfPLde8+uSuzlJ7XVoWFZo47BlRg2xBnfvWj86pRLoDvI+Fu0iXICtPnNuGW22h3x/dC+V+sZO8n4C46D1H3lyBZUy08SwVeX74AWoR0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603208513; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=ON/re6l/Dv6x0V1ypsA/2QI8DNbvfVaMF39pigVEdMg=; b=JEU/IUN/an8T+Dt238UmCE1r0KXcv9z0WToWCl5fBqR8Oyy7xOX/sTRiwSBLlPN42oqP2ZDSsIy+H7MAhWg9vxfxnC4phBV4EOR8/U72o7UKOEX5+JBIIPHI5rqP8V5g+dmWkD/U/pf3sMzNawoTzxJLuCwvXt2CUkQCKf6wnTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603208513398132.61528709165464; Tue, 20 Oct 2020 08:41:53 -0700 (PDT) Received: from localhost ([::1]:56268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUtlo-0000Hr-IU for importer@patchew.org; Tue, 20 Oct 2020 11:41:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUtjn-0006gr-PZ for qemu-devel@nongnu.org; Tue, 20 Oct 2020 11:39:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59091) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUtjl-0001QL-2j for qemu-devel@nongnu.org; Tue, 20 Oct 2020 11:39:47 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-Y4oR3-4OPq2mmubDsPObNw-1; Tue, 20 Oct 2020 11:39:41 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5AE558049DD; Tue, 20 Oct 2020 15:39:40 +0000 (UTC) Received: from thuth.com (dhcp-192-238.str.redhat.com [10.33.192.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F2A15B4A1; Tue, 20 Oct 2020 15:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603208383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=ON/re6l/Dv6x0V1ypsA/2QI8DNbvfVaMF39pigVEdMg=; b=PG0EtB1bL8SnFT5H2O+wU9+BUC7UhduQuPbPllQbOkpp1t3hQcaPg2Rpwcxj4M20Bg+ItG xWQztp8/G8AxX69Sbk/CckRsSwV1SrpR70FYF1CWNNjoiKKfh5IGhFaby/QlHhrwubMIN1 ucNdWl9j8AkRnHyiZi2W51Z6eTq9cxU= X-MC-Unique: Y4oR3-4OPq2mmubDsPObNw-1 From: Thomas Huth To: Yoshinori Sato , qemu-devel@nongnu.org Subject: [PATCH 2/3] hw/timer/sh_timer: Silence warnings about missing fallthrough statements Date: Tue, 20 Oct 2020 17:39:34 +0200 Message-Id: <20201020153935.54315-3-thuth@redhat.com> In-Reply-To: <20201020153935.54315-1-thuth@redhat.com> References: <20201020153935.54315-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 01:15:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Magnus Damm Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When compiling with -Werror=3Dimplicit-fallthrough, gcc complains about missing fallthrough annotations in this file. Looking at the code, the fallthrough is very likely intended here, so add some comments to silence the compiler warnings. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/timer/sh_timer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index b09e30f938..934daaa7dc 100644 --- a/hw/timer/sh_timer.c +++ b/hw/timer/sh_timer.c @@ -122,6 +122,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, if (s->feat & TIMER_FEAT_EXTCLK) { break; } + /* fallthrough */ default: hw_error("sh_timer_write: Reserved TPSC value\n"); break; @@ -135,6 +136,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, if (s->feat & TIMER_FEAT_EXTCLK) { break; } + /* fallthrough */ default: hw_error("sh_timer_write: Reserved CKEG value\n"); break; @@ -147,6 +149,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, if (s->feat & TIMER_FEAT_CAPT) { break; } + /* fallthrough */ default: hw_error("sh_timer_write: Reserved ICPE value\n"); break; @@ -180,6 +183,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, s->tcpr =3D value; break; } + /* fallthrough */ default: hw_error("sh_timer_write: Bad offset %x\n", (int)offset); } --=20 2.18.2 From nobody Sun Feb 8 05:47:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603208646; cv=none; d=zohomail.com; s=zohoarc; b=Hg5Ud/hx78kZV8b9wUa4MVf6E/1dVHmX/nIshrjnlMix6o4NvlN/Fol8KX2JlWqyuu+A6WfpybK/Z0+8iSPfqUjd3tkYcvYTccn3iTYQtyyboY61B8ihpfIVMae90MuD3zi0rwUv9FDPKSnJd1TmqYpd+EqALnAzOTTxgE2aStU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603208646; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=00KM4f2VWpsnzdCiWTlBAYahGIiw9FH66M8ACJQmM70=; b=BmeHE/zqQaCFhzOplxaixD7wXD09/x8WJt53nqySOIRfDcati0bfa4TQcp//dq6AlHhFd83FW2UOUahB1r3WqMpvH2nx5zUojti2Xi8jvLlwhnDUUri+D4bG0nxH2gmbWDGlmKpCiWg7fTVwd/BJyX08/iGvheHyVP/vv3b609Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603208646970772.0738771681464; Tue, 20 Oct 2020 08:44:06 -0700 (PDT) Received: from localhost ([::1]:35046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUtny-0003Dd-8u for importer@patchew.org; Tue, 20 Oct 2020 11:44:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUtjo-0006jQ-S1 for qemu-devel@nongnu.org; Tue, 20 Oct 2020 11:39:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUtjn-0001Qx-AF for qemu-devel@nongnu.org; Tue, 20 Oct 2020 11:39:48 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-589-a2LShN4dNhySGnNI3pyN4w-1; Tue, 20 Oct 2020 11:39:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8BCF757084; Tue, 20 Oct 2020 15:39:41 +0000 (UTC) Received: from thuth.com (dhcp-192-238.str.redhat.com [10.33.192.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FF965B4A1; Tue, 20 Oct 2020 15:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603208386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=00KM4f2VWpsnzdCiWTlBAYahGIiw9FH66M8ACJQmM70=; b=KdLSzu+FBCw9L2l4c8QIdrC0ecFWliY4VRtPjkSa9A1ux7T8RQkM9845FvmS9gJQt8yrk+ +yEM5VHCvojE0ipie9AHcjpaQKtyI0aeN3IAcchNEuHf0Gb3W/G1me4e7Cgf1yKjXECFnd twk3fNB+YVQjP1aAuNu7IjPOWChDOl0= X-MC-Unique: a2LShN4dNhySGnNI3pyN4w-1 From: Thomas Huth To: Yoshinori Sato , qemu-devel@nongnu.org Subject: [PATCH 3/3] hw/timer/sh_timer: Remove superfluous "break" statements Date: Tue, 20 Oct 2020 17:39:35 +0200 Message-Id: <20201020153935.54315-4-thuth@redhat.com> In-Reply-To: <20201020153935.54315-1-thuth@redhat.com> References: <20201020153935.54315-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 01:16:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Magnus Damm Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" hw_error() is marked as QEMU_NORETURN, so the "break" statements after this function are just dead code. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/timer/sh_timer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index 934daaa7dc..58af1a1edb 100644 --- a/hw/timer/sh_timer.c +++ b/hw/timer/sh_timer.c @@ -125,7 +125,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved TPSC value\n"); - break; } switch ((value & TIMER_TCR_CKEG) >> 3) { case 0: @@ -139,7 +138,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved CKEG value\n"); - break; } switch ((value & TIMER_TCR_ICPE) >> 6) { case 0: @@ -152,7 +150,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved ICPE value\n"); - break; } if ((value & TIMER_TCR_UNF) =3D=3D 0) { s->int_level =3D 0; --=20 2.18.2