From nobody Sat May 18 23:23:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603100235; cv=none; d=zohomail.com; s=zohoarc; b=UZk4hFtsycaBxOLUnsqqQJGjfq37W8v4q44ZOQFeKNBvdgm7JmjkGw05o+qGPkXrNx38iLIa5wPHD9MeAK5ykSc494RvLzwsac20lJQ453fcOOHVeKr2Tka9b8hkUL4Q7UZVUgoGriiGTcCBngtWJdZ5yfBHxDKbQeMvalMVzgE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603100235; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=CIj93W4pV1dWctQ5mtDW8fnniDqeMwESM2dRSB9KQmQ=; b=SJzFa0NxroiLBuh8XLoiKkFRQLymKMCU4GOX96BnfNfCnxs0+rNH5rTpzoY86uwd2yeDnNRZ2CjhrTZD50FtvEzrMLccUymnEYT5jhObJP9ui8C3Ijs+wj7o+COvFXWcGw3iv6OLwSrUMszhCkMh9rMSDm6EluksroiSyPFC1fY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603100235328832.2565199111231; Mon, 19 Oct 2020 02:37:15 -0700 (PDT) Received: from localhost ([::1]:57020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kURbO-0000nP-2V for importer@patchew.org; Mon, 19 Oct 2020 05:37:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kURaH-0000B0-CQ; Mon, 19 Oct 2020 05:36:05 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5182 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kURaF-0000t7-OI; Mon, 19 Oct 2020 05:36:05 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 146F8C4630B1EF47DB76; Mon, 19 Oct 2020 17:36:00 +0800 (CST) Received: from localhost.localdomain (10.175.124.27) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 19 Oct 2020 17:35:50 +0800 From: Peng Liang To: , Subject: [PATCH] microbit_i2c: Fix coredump when dump-vmstate Date: Mon, 19 Oct 2020 17:34:01 +0800 Message-ID: <20201019093401.2993833-1-liangpeng10@huawei.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=liangpeng10@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/19 05:36:00 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liangpeng10@huawei.com, peter.maydell@linaro.org, joel@jms.id.au, xiexiangyou@huawei.com, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" VMStateDescription.fields should be end with VMSTATE_END_OF_LIST(). However, microbit_i2c_vmstate doesn't follow it. Let's change it. Fixes: 9d68bf564e ("arm: Stub out NRF51 TWI magnetometer/accelerometer dete= ction") Reported-by: Euler Robot Signed-off-by: Peng Liang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i2c/microbit_i2c.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i2c/microbit_i2c.c b/hw/i2c/microbit_i2c.c index 802473982082..e92f9f84ea81 100644 --- a/hw/i2c/microbit_i2c.c +++ b/hw/i2c/microbit_i2c.c @@ -83,6 +83,7 @@ static const VMStateDescription microbit_i2c_vmstate =3D { .fields =3D (VMStateField[]) { VMSTATE_UINT32_ARRAY(regs, MicrobitI2CState, MICROBIT_I2C_NREGS), VMSTATE_UINT32(read_idx, MicrobitI2CState), + VMSTATE_END_OF_LIST() }, }; =20 --=20 2.26.2