From nobody Tue Feb 10 02:54:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.65 as permitted sender) client-ip=209.85.221.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603053262; cv=none; d=zohomail.com; s=zohoarc; b=bSyV2pwGcMD5QnAtrQy4D8/dcRnrVSvZdsdLe77Wpwv6JFK3ZtA5w9blKjaegvkC/wv/l4DNFD6mmXmhom+lZV06unSloJnqK1jkx7wppka9KIFTp4UAA0IgRZUwZlo9mwMkxacNRvZJkgQfgGGTOdxJV8UiJ2GA/aaKShUr/fM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603053262; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QcjhrFqjAYV+Q6plgNPayGWcmQofCNspcYhj6aIa8BM=; b=YaoDWhytVjnqJ2EF8BSI6XC6Vx+nMeRi1l0/1pwhvU19CriJfUCBiC/CrrajjYP4yOUkG6Sy9nEvM4NO3b0jGZOehM6OGrPIhJ26CbbZ4USAyayfxRqo9YWT0yMEiCXovM/D5zkb/m02N+zwIYY7lV2PVtk5QTvcarTssJ4kO0s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.zohomail.com with SMTPS id 1603053262055226.683377555437; Sun, 18 Oct 2020 13:34:22 -0700 (PDT) Received: by mail-wr1-f65.google.com with SMTP id s9so9108890wro.8 for ; Sun, 18 Oct 2020 13:34:21 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (117.red-83-52-172.dynamicip.rima-tde.net. [83.52.172.117]) by smtp.gmail.com with ESMTPSA id v189sm14080474wmg.14.2020.10.18.13.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2020 13:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QcjhrFqjAYV+Q6plgNPayGWcmQofCNspcYhj6aIa8BM=; b=S88fHOt4fYPvKKEH0xh2S14khv8CZREiBDQPhGjwnuTTVinBOHQ51NeCHg5RPOOvfG 0pevdhh7TcViZiHr/cvt13uSjrr4NPuYtYrFHEiHmcwcsN7BksRlm0gpJpQ04EgRYvTL Pf3FC30Ll1STlF5D1COoMzQcuWg7rZ4FrD+7cMU0LmoNcLWyuoNrvCYzTzt4222McDwU Pj03gq84PPRq6+1wS8Zqk31ZePLYNdbs2bXQypzc/uyL14WsbwiSnlnCvs3k/9FX1Cd7 XNNOiWUQZ74lMk0lPjpys3T5t0dnGhKP6Cfz1PA+e2qjzQDn7anHdIwtyDPlK5nOJJdg iPTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=QcjhrFqjAYV+Q6plgNPayGWcmQofCNspcYhj6aIa8BM=; b=HIkXZskcwUNxE4f6m244XAovuRugXCtJ2pqxDTwgkYfSQtsmDTxI3rQFBvv8TbR7Jf F607rquoHwlNP+lfdaK4iLWqMqT0j/rlFJql2OwwBQqC9g2XQf5AQdYJxDrAPF95Bqnk naz0UvGhI6EapElv7Ia1iEfldCp+OpQSLnANHIc0EQMBAx8G5T/9W4LT4WhYde7w2U4Y eelg9qsLgifF7UF6q9hMkSFgIF/SkNwa//AiVtfcBLwtzsB3fQmCmpImbCQ/SZ1VKPOJ m5ciFH3jNFrdeLh6L5a2kNfr+NrLXN4XM9rM4icZNpxrb+WAsIF7JD5NC7YmgdUKW8/G 8erw== X-Gm-Message-State: AOAM530ULh+XR6V51nBYDrHWaqG8QI4oPEV1WjTLQ2BCbgQMtcr8oF/v 4y4T/rfaK3B0kT/MTDYvUq4= X-Google-Smtp-Source: ABdhPJyMxOLmcmB6MgHjtw4hORwQBemfFcIetNda0xBwwM8Lmg5GkLkFvVwmmWJc1EuRJyIixrqq9g== X-Received: by 2002:adf:eb41:: with SMTP id u1mr15593621wrn.94.1603053260138; Sun, 18 Oct 2020 13:34:20 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Luc Michel , Andrew Baumann , qemu-arm@nongnu.org, Luc Michel Subject: [PATCH v3 4/9] hw/arm/bcm2836: Only provide "enabled-cpus" property to multicore SoCs Date: Sun, 18 Oct 2020 22:33:53 +0200 Message-Id: <20201018203358.1530378-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201018203358.1530378-1-f4bug@amsat.org> References: <20201018203358.1530378-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) It makes no sense to set enabled-cpus=3D0 on single core SoCs. Reviewed-by: Luc Michel Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/bcm2836.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index c5d46a8e805..fcb2c9c3e73 100644 --- a/hw/arm/bcm2836.c +++ b/hw/arm/bcm2836.c @@ -34,6 +34,9 @@ typedef struct BCM283XClass { #define BCM283X_GET_CLASS(obj) \ OBJECT_GET_CLASS(BCM283XClass, (obj), TYPE_BCM283X) =20 +static Property bcm2836_enabled_cores_property =3D + DEFINE_PROP_UINT32("enabled-cpus", BCM283XState, enabled_cpus, 0); + static void bcm2836_init(Object *obj) { BCM283XState *s =3D BCM283X(obj); @@ -44,6 +47,10 @@ static void bcm2836_init(Object *obj) object_initialize_child(obj, "cpu[*]", &s->cpu[n].core, bc->cpu_type); } + if (bc->core_count > 1) { + qdev_property_add_static(DEVICE(obj), &bcm2836_enabled_cores_prope= rty); + qdev_prop_set_uint32(DEVICE(obj), "enabled-cpus", bc->core_count); + } =20 object_initialize_child(obj, "control", &s->control, TYPE_BCM2836_CONT= ROL); =20 @@ -130,12 +137,6 @@ static void bcm2836_realize(DeviceState *dev, Error **= errp) } } =20 -static Property bcm2836_props[] =3D { - DEFINE_PROP_UINT32("enabled-cpus", BCM283XState, enabled_cpus, - BCM283X_NCPUS), - DEFINE_PROP_END_OF_LIST() -}; - static void bcm283x_class_init(ObjectClass *oc, void *data) { DeviceClass *dc =3D DEVICE_CLASS(oc); @@ -155,7 +156,6 @@ static void bcm2836_class_init(ObjectClass *oc, void *d= ata) bc->ctrl_base =3D 0x40000000; bc->clusterid =3D 0xf; dc->realize =3D bcm2836_realize; - device_class_set_props(dc, bcm2836_props); }; =20 #ifdef TARGET_AARCH64 @@ -170,7 +170,6 @@ static void bcm2837_class_init(ObjectClass *oc, void *d= ata) bc->ctrl_base =3D 0x40000000; bc->clusterid =3D 0x0; dc->realize =3D bcm2836_realize; - device_class_set_props(dc, bcm2836_props); }; #endif =20 --=20 2.26.2