From nobody Tue Feb 10 15:45:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) client-ip=209.85.221.67; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f67.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602958065; cv=none; d=zohomail.com; s=zohoarc; b=IenPHsC4kDM7QPmbFq+tBAhFeolPs9gPsJC3dZYJNFrtQ99fWQ8aVVArW0pGYTtvqp7vnNXTRuO7txpLPXrFeLFusfKNpV4Gs94hmahpQ/Gq8uTdEZ/eNJp7red4x4yxjQqhheaujskrVnIF8zKH7Mw6HdNJu4hiIjuz+AMm5T0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602958065; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fV1sc6OWYGYAEKTgUKDN1x3UErFGbkghLLV029wOF5g=; b=NsV0htKDbS/bjeCdfFQ/0T1y3MMp9aL4tKgIeXUyxs0bfX4s/lghqKFMR5QxYclD8W/z8XBQcdsgtFtk4f+JHrKavyrMgCr3Fen5O/e88zCTjoXRu3VP1dep/zDNes/PC08J7N/GvKXk4y4iPHO6EuAP8Txhbv5KxRsWY7ENCaA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.zohomail.com with SMTPS id 1602958065710796.8170832028896; Sat, 17 Oct 2020 11:07:45 -0700 (PDT) Received: by mail-wr1-f67.google.com with SMTP id e17so6939612wru.12 for ; Sat, 17 Oct 2020 11:07:45 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (117.red-83-52-172.dynamicip.rima-tde.net. [83.52.172.117]) by smtp.gmail.com with ESMTPSA id 205sm8753097wme.38.2020.10.17.11.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2020 11:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fV1sc6OWYGYAEKTgUKDN1x3UErFGbkghLLV029wOF5g=; b=YUFg92JVjU8rwd9lMc/qsrM++qm1N9XutE5OAb2vJg8hfMZhFmMKvAGXxIDB/o7FrV liqv7DUE2rrR4c9RUgglY6gPvc7w4QTTA7iwGgptg3RTorg07NYZEBxXjj8DZ0wRise8 KHwQ+BBVpxLz4mQ8diPXSh9BXVpqIFXL+mLP3RDZ4fNuLVE9hbn+0JoHKWFz561Wv49c EgJWq1vL+J1JI/pDheP/kWf8zFgOEIJkiybomMth8TtaQ/Y95Qj1xiwIAAvjNF65YWo4 Ryddfk00/A7Z8508c1tRO7kIym2KsDe9HtfwSvSwi1xMfu/FpodI1OqU0ScygUS+Kz4b 7s0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fV1sc6OWYGYAEKTgUKDN1x3UErFGbkghLLV029wOF5g=; b=tY465c5sk3g2Cmdgc+fwGr1NwA3opyGGaj/Y306y8pfk8KncZC8hu2/co/S364waqE TgkxRpSSpbxg62xRKZ8uGzBsnAy7VHLUsL+VPn0DHurwB50UvFdcHfNlBeIjZt8OHZL+ NTQVfUu2mPoW+LorC9mJb+XSJMsmjwBIG0H2n8Jde93qYk/+UG/6cDRMHRCM/RlA6AEN wBCjZKC7nGvlkklkpUZdZW1sT3Eonb13dKjH3ztrSSMjnzaHMVOxJQwyxgX5AOIzA4i+ Gxf6QHU390qZrcYBsj/52APonDcp5xjy53DK1OQzk3ymP1nUy4AZ788qA4k25ieC5RGW dSUw== X-Gm-Message-State: AOAM530F/RnhezG5/ha766FI++106FLcaJV0Im0lsym6Wlos2ls1OWzp JwStPFdNBUxm5cVcMcdoqCY= X-Google-Smtp-Source: ABdhPJxxrKR+iCGvHgSjlD0e5FmfzDocqvlIoWg23mQOwOUBJ9NErlWgqsyWxca+b7oneVDvgB0ntA== X-Received: by 2002:adf:e6c4:: with SMTP id y4mr11531583wrm.423.1602958063882; Sat, 17 Oct 2020 11:07:43 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Luc Michel , Peter Maydell , Andrew Baumann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/2] hw/intc/bcm2836_control: Use IRQ definitions instead of magic numbers Date: Sat, 17 Oct 2020 20:07:31 +0200 Message-Id: <20201017180731.1165871-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201017180731.1165871-1-f4bug@amsat.org> References: <20201017180731.1165871-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The IRQ values are defined few lines earlier, use them instead of the magic numbers. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/intc/bcm2836_control.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/intc/bcm2836_control.c b/hw/intc/bcm2836_control.c index 53dba0080ca..2ead76ffdce 100644 --- a/hw/intc/bcm2836_control.c +++ b/hw/intc/bcm2836_control.c @@ -157,22 +157,22 @@ static void bcm2836_control_set_local_irq(void *opaqu= e, int core, int local_irq, =20 static void bcm2836_control_set_local_irq0(void *opaque, int core, int lev= el) { - bcm2836_control_set_local_irq(opaque, core, 0, level); + bcm2836_control_set_local_irq(opaque, core, IRQ_CNTPSIRQ, level); } =20 static void bcm2836_control_set_local_irq1(void *opaque, int core, int lev= el) { - bcm2836_control_set_local_irq(opaque, core, 1, level); + bcm2836_control_set_local_irq(opaque, core, IRQ_CNTPNSIRQ, level); } =20 static void bcm2836_control_set_local_irq2(void *opaque, int core, int lev= el) { - bcm2836_control_set_local_irq(opaque, core, 2, level); + bcm2836_control_set_local_irq(opaque, core, IRQ_CNTHPIRQ, level); } =20 static void bcm2836_control_set_local_irq3(void *opaque, int core, int lev= el) { - bcm2836_control_set_local_irq(opaque, core, 3, level); + bcm2836_control_set_local_irq(opaque, core, IRQ_CNTVIRQ, level); } =20 static void bcm2836_control_set_gpu_irq(void *opaque, int irq, int level) --=20 2.26.2