From nobody Tue Feb 10 09:57:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) client-ip=209.85.221.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602943502; cv=none; d=zohomail.com; s=zohoarc; b=nPvCtXGLmSgD29fCk3oK1zNnDDakoooQSv6sf3DpJvV168Ifj4PZXPeGIJjbSbCK3m/CF5LHw6Yfa1y+FdVJa8k2WxV4iivCp7U4bcI+UyHxIj89I/LVV0z25G99ZDsZ8S843cMLMXI85bWMRXUwBsCkKFtazNGxAioafsTu8t4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602943502; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MrdAokW/C4AyEAhV1+Tvr+zY4ZVMVcUDy6Uk4AJ14vA=; b=G+OxreR0d6s9tf7FouGM0APonMraSRmzVvqGadOahBIOzlGEJC8igOJGRY6VtIpmpbS1+fVMLWGHWOZN6LEX6+2dsaUki4YCX0yDEQiEvlj9T4795nVtUFN2J0YHZHpChGFT9XHPctsNenHTmyVRqn4wKphObJW97T+vw8H2DV8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.zohomail.com with SMTPS id 1602943502952742.7727378519448; Sat, 17 Oct 2020 07:05:02 -0700 (PDT) Received: by mail-wr1-f68.google.com with SMTP id e17so6544328wru.12 for ; Sat, 17 Oct 2020 07:05:02 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (117.red-83-52-172.dynamicip.rima-tde.net. [83.52.172.117]) by smtp.gmail.com with ESMTPSA id z6sm8889134wrm.33.2020.10.17.07.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2020 07:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MrdAokW/C4AyEAhV1+Tvr+zY4ZVMVcUDy6Uk4AJ14vA=; b=Ji2rC32Y2ZhtUQDPGgnqxT/A56h/CA+3sa7py4H/Hg2PojiWS/T569JE/dwXmnLis+ p0fMGb0QWXM2huk0m6JAIlUSccFH+a3wX90S83DsQWNExFaH0X7n57a7pdVvY+Ac6nRk INjNWQGzyQYx0afrb3hZSbUnQX8gK5VsjmpBQ4LL94KIw4nNl26tI7qNCc2okaxJcptX rWfqJIm0Yvctm5PI0QMDS5L3Sh0pOu6L+vTAmLz4AFoV86KlnDoRejh5FqHm8guUlpR4 wg67i4qzocBg2NOUAFhD8Aomo7pBB1l0zsKRYsGfOJAI++1KwD3BQoEl/zjqVwPCxOyH d15A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MrdAokW/C4AyEAhV1+Tvr+zY4ZVMVcUDy6Uk4AJ14vA=; b=fens984B+SqZeDRNLv6EP8nPWIyL7/Imo7CPfb/275fIZD/8pfth6PLIuQq9d4Gs4J YYSzc8NvAO/s4KwitkWMEWW7OuRnoykItPmQyZeQ2rd4mx+nwZ69XsOOu+TCumXVmiT+ 75jLop4/6LTvQUPkUMOXde7+CEC3LKol5s8ZdLi2bqZwp2mcoKMHCnSqLGOkwwqVUMdf 5nwLF7xsrwqHjhlBXySmiE52DqlJda4qlSODJt1orU7mMnV/isg/+Xe1hbOgKzZL9u+u 0f4sRPlRj4GnWO8sNxD3J9Qz0DFt+k7hZu+sUrMvwjt2hvDMs/o7h3a3/PAP7XtuaIEm 6OdA== X-Gm-Message-State: AOAM533Nn3hh8SVMyVfQR6Is+XX6GkwDYoVp0s8uuq9bAMRBiQTGMJwu wloESYROdYEt/7b24b0XGRs= X-Google-Smtp-Source: ABdhPJyB10aovnv031nwtdowCH9lRTV13eAP3rPKsY/3S2axFbiCqtIBImIbjgg3GtbtSA4ksdZuRQ== X-Received: by 2002:adf:fb8b:: with SMTP id a11mr10129084wrr.407.1602943501126; Sat, 17 Oct 2020 07:05:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Huacai Chen , Paul Burton , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 29/44] hw/mips/cps: Do not allow use without input clock Date: Sat, 17 Oct 2020 16:02:28 +0200 Message-Id: <20201017140243.1078718-30-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201017140243.1078718-1-f4bug@amsat.org> References: <20201017140243.1078718-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Now than all QOM users provides the input clock, do not allow using a CPS without input clock connected. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201012095804.3335117-21-f4bug@amsat.org> --- hw/mips/cps.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/mips/cps.c b/hw/mips/cps.c index af7b58c4bdd..c624821315a 100644 --- a/hw/mips/cps.c +++ b/hw/mips/cps.c @@ -74,6 +74,11 @@ static void mips_cps_realize(DeviceState *dev, Error **e= rrp) bool itu_present =3D false; bool saar_present =3D false; =20 + if (!clock_get(s->clock)) { + error_setg(errp, "CPS input clock is not connected to an output cl= ock"); + return; + } + for (i =3D 0; i < s->num_vp; i++) { cpu =3D MIPS_CPU(object_new(s->cpu_type)); =20 --=20 2.26.2