From nobody Tue Feb 10 17:30:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.66 as permitted sender) client-ip=209.85.128.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602943376; cv=none; d=zohomail.com; s=zohoarc; b=PF0QLSzKYo6AZn3HL2IrKvyfD25QDUhWUoxlTi33OwDMLjKj1dke0nvNwaLDTRXldmTDbC3ORssUFqMaxzfkhmJEpOwpfzmmi0aFXJHwlTZiVef79Oq17EVQETuKlqLDJRzw9En1WPzWmCjsgTLhMmpJe3r3DH2m+mTpD/a7Pao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602943376; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ckhgHIzetD2FmHEm0FTTUKRnqskZdYevul/a5BWHNys=; b=J+R/6tnjP7JoTFIWZQpr/4P70P/TFhlRGjYrctrJbCi7o6l/1uwng64r+USRHOjaY4cSdKLNdrSQo3Bv52sOQK1kTRrQ9DZropXssI+Uy3J5J9gnNbP0iJs95E624e1uqNMlKxDZ5mqRhr2xsm3F8SMj6ZnxiUURui/fo88oBws= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.zohomail.com with SMTPS id 1602943376954760.9659269400795; Sat, 17 Oct 2020 07:02:56 -0700 (PDT) Received: by mail-wm1-f66.google.com with SMTP id d81so6153554wmc.1 for ; Sat, 17 Oct 2020 07:02:56 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (117.red-83-52-172.dynamicip.rima-tde.net. [83.52.172.117]) by smtp.gmail.com with ESMTPSA id b189sm7279971wmb.37.2020.10.17.07.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2020 07:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ckhgHIzetD2FmHEm0FTTUKRnqskZdYevul/a5BWHNys=; b=MwhIzd9vmKrNrMQcJ4xyTdGkBMDODFCRnuLvsNjbU1/TLj/fr3P0cRjdLTbxkg2QZ0 zETo7T9j/B1RF2DjsFcKSrwoBiYKBpndj9Hn6/J7H9EAwAIPQTO7Ktbb2vaV+G+V00mw ZmmYucRGaXnM6gNFVskqJe/1esoAxkBSjB2nYA0xMsNB2G6CgYVrK5UnZhN1ujab7m+p bB4acVFxaKLLW+27yBHQnnd7cnJq4vl5WJi/3dQ2pMB9aGT6mOlpctjlecWYH7+PFJuv SXsnDXTYSG4QA5CYK7S+7DjWs7Qo5YI9j56liOq1B8uWB1qMK9g9Hoa/foiOFK7C0Bdc WnQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ckhgHIzetD2FmHEm0FTTUKRnqskZdYevul/a5BWHNys=; b=KWanZjCeaw23X7zcDJtHRO8wrWTqE8DL/Mzi+tdn793iesnvO/HOU+pXb7wWvQutv/ 7B30XE3dD7WuJ+iy+sH4R6781rMEfFsou67EcTMyGf8LHD9wPrEPiXrnrjt/ycOj33p4 J6fu+yFt8MzBLKg66myhZAViegQ7tve2mv6yG9df5YyyhJqYp9H3Mf4ISEiWLLcwmLx5 GFltgA0LG5emZvXB20V4IAeSVA/7FoAlGMjh1j7MblwvqgltZMOMlqNAovAxlseojqdw /B3TfShHMZM8UczUNTJ4rZlo5vCLlyMaXo7fCf13spBveT9CRSgLBgEgBMHUurbA61ql 7H2g== X-Gm-Message-State: AOAM530YpZmFFb6qYws/DkqaEjdoRhxaoxwOVRRgxRiNyyNlMuY/58o+ +XIV3B3F0PLeqU3+TszX45Q= X-Google-Smtp-Source: ABdhPJw8G3qQpcBEOQOl2n1jsv9b14X+nabi32lR8Ou+QXQn4MMlOoWQ6dDih6K8nK2W55im4NDSkw== X-Received: by 2002:a7b:c4cb:: with SMTP id g11mr8707586wmk.88.1602943375100; Sat, 17 Oct 2020 07:02:55 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Huacai Chen , Paul Burton , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Luc Michel , Damien Hedde , "Edgar E . Iglesias" Subject: [PULL 02/44] hw/qdev-clock: Display error hint when clock is missing from device Date: Sat, 17 Oct 2020 16:02:01 +0200 Message-Id: <20201017140243.1078718-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201017140243.1078718-1-f4bug@amsat.org> References: <20201017140243.1078718-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Instead of directly aborting, display a hint to help the developer figure out the problem (likely trying to connect a clock to a device pre-dating the Clock API, thus not expecting clocks). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Luc Michel Reviewed-by: Damien Hedde Reviewed-by: Edgar E. Iglesias Message-Id: <20201012095804.3335117-4-f4bug@amsat.org> --- hw/core/qdev-clock.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/core/qdev-clock.c b/hw/core/qdev-clock.c index 47ecb5b4fae..6a9a340d0fb 100644 --- a/hw/core/qdev-clock.c +++ b/hw/core/qdev-clock.c @@ -12,6 +12,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "hw/qdev-clock.h" #include "hw/qdev-core.h" #include "qapi/error.h" @@ -153,6 +154,11 @@ Clock *qdev_get_clock_in(DeviceState *dev, const char = *name) assert(name); =20 ncl =3D qdev_get_clocklist(dev, name); + if (!ncl) { + error_report("Can not find clock-in '%s' for device type '%s'", + name, object_get_typename(OBJECT(dev))); + abort(); + } assert(!ncl->output); =20 return ncl->clock; @@ -165,6 +171,11 @@ Clock *qdev_get_clock_out(DeviceState *dev, const char= *name) assert(name); =20 ncl =3D qdev_get_clocklist(dev, name); + if (!ncl) { + error_report("Can not find clock-out '%s' for device type '%s'", + name, object_get_typename(OBJECT(dev))); + abort(); + } assert(ncl->output); =20 return ncl->clock; --=20 2.26.2