From nobody Tue Feb 10 20:48:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) client-ip=209.85.221.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602943428; cv=none; d=zohomail.com; s=zohoarc; b=FEyMuMxlWbYFQ7zOPAa2/F9bRO9uQeT3gdwXe4Oh2+YIWzc6kEn3XCxZAd7E3YqMP6OIplZVczzSNOMJ+iZTrCFBI2dECWODW2j/Bx2HOZLTDnD/0hDTm4HeuPqXZZKq6f/DrcgZG2lRNXmdN6II8OzAHfoi1ldBud7H4mEg/rs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602943428; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QVmCBzAijqIxVbHfMUmSPN/CpI6hZqRTxfcmVPbu0NA=; b=Du7IziyCJasBJGFMeBoP7iGlsol9SY7fscxQxAqpTvhKn79NJBnOb/8xL81cSddbSM6YrZ/ulF6099xDqTMA/HSei0VKQJciPJ3L+uu/A2a1RivlR88xPdrLnJNUMDFdBgXrmWdToXUD4a5stzK3E4r45nRBYvvBEmExftG5TVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.zohomail.com with SMTPS id 1602943428413732.3781174082479; Sat, 17 Oct 2020 07:03:48 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id j7so2485924wrt.9 for ; Sat, 17 Oct 2020 07:03:47 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (117.red-83-52-172.dynamicip.rima-tde.net. [83.52.172.117]) by smtp.gmail.com with ESMTPSA id g5sm7492870wmi.4.2020.10.17.07.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2020 07:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QVmCBzAijqIxVbHfMUmSPN/CpI6hZqRTxfcmVPbu0NA=; b=KVCEkciRTE7Jpa3bDmrfXZ/fBHouFmR5oJYG38COqNnNBEapA9epwsy0rUjWswoVYL e9YMWblt3k8VPQpZz6uSdVhzuxAcxuMjfhgBKvvSSGwOH2Wb5G01+T6nxWxTipPopDlu cNP+73uG1Hlwsho26PBRvlVXk8BCtgK4B2RAWFx0P3H7KqzHGZNtWwnfOeDdk5d0IfoG AHafDmTQazEMecfOwTa8gQM9XllRjYTfvBMaPxM7Ri3D2+WyJ6uos/cO9DSh0nF5wBzp tPAr3xEYFH5BaRWlOQqxOMJG/uBfecbF+ZHpb3HtIZ2BsCuBLQ+eCHoIbVT9H/qh4Nix 9rJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=QVmCBzAijqIxVbHfMUmSPN/CpI6hZqRTxfcmVPbu0NA=; b=C6OU9YPmiiC6PqFF34Eqd3zeueeNiaYRrhUVV50/LvJbPgdnlvG848/IEveJCFsfSl 770Pd8isF5LmNWBnQ0ZqD5ROPFkxZ9s2B1PDX5ldAI4ByseLY/dBl1w9+lG2FzLXgXMF OwlQI9lfjn6WvQLcpvC+r6NPinZ9I4b4FmSL+HGgKnnejti4AuSvstxBI1QRjiCvB/bB mI5PvYPXaIxyWzE32qYej3A7pGm+kgaSIYLQZ+vNLIglI3VHuLnKQaHB2306eL1p10qQ qPZm7y3Y5IKhD3eKDxwn7R/Yh2ZbyA+3Fbrdbin7MHPKsourucIOetKCuIMo/Q14x5A1 CqLA== X-Gm-Message-State: AOAM532IWFRvplBEJhd1EVm6soQbqTN12Z6d+YiK4bt4vp4cJIXrBiol BNrMvNpPOD9jS4DC2M/5VpQ= X-Google-Smtp-Source: ABdhPJwkqIqa9dMANp6emE7laWWkLuj4iweTq0EA3lDHIX8v+ibZe5ZSK5KwjUqTxFZhzfUKIxZDwQ== X-Received: by 2002:adf:e3cb:: with SMTP id k11mr10346246wrm.341.1602943426613; Sat, 17 Oct 2020 07:03:46 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Huacai Chen , Paul Burton , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 13/44] target/mips/op_helper: Log unimplemented cache opcode Date: Sat, 17 Oct 2020 16:02:12 +0200 Message-Id: <20201017140243.1078718-14-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201017140243.1078718-1-f4bug@amsat.org> References: <20201017140243.1078718-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) In case the guest uses a cache opcode we are not expecting, log it to give us a chance to notice it, in case we should actually do something. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Jiaxun Yang Message-Id: <20200813181527.22551-4-f4bug@amsat.org> --- target/mips/op_helper.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index 2496d1dd718..0050d0616b6 100644 --- a/target/mips/op_helper.c +++ b/target/mips/op_helper.c @@ -1574,6 +1574,13 @@ void helper_msa_st_d(CPUMIPSState *env, uint32_t wd, void helper_cache(CPUMIPSState *env, target_ulong addr, uint32_t op) { #ifndef CONFIG_USER_ONLY + static const char *const type_name[] =3D { + "Primary Instruction", + "Primary Data or Unified Primary", + "Tertiary", + "Secondary" + }; + uint32_t cache_type =3D extract32(op, 0, 2); uint32_t cache_operation =3D extract32(op, 2, 3); target_ulong index =3D addr & 0x1fffffff; =20 @@ -1592,6 +1599,8 @@ void helper_cache(CPUMIPSState *env, target_ulong add= r, uint32_t op) /* no-op */ break; default: + qemu_log_mask(LOG_UNIMP, "cache operation:%u (type: %s cache)\n", + cache_operation, type_name[cache_type]); break; } #endif --=20 2.26.2