From nobody Tue Feb 10 03:40:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) client-ip=209.85.128.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602943423; cv=none; d=zohomail.com; s=zohoarc; b=kWydJlzr/hDBcG53z/uKwyYdG4MyaT3inoxaMtHlVGzjst2Zxf1NOh1mdDGzow50dgDj7VGRiOVQy11oaCnbfDiaazEImcwIJ2ujUTEumOh8wtT55sSLYMqN7G7MRYifRi6IxYDR6GYvtbbGz9Uu9ITmEOlSj4MCVvNTRyMwBnM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602943423; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LfhnJlD5ICt8SM68uBqo2cJX//28deS2z59iVNfu0PI=; b=K5MUd9VctJifnaQiMjPGBszV5T2jr/xjLTRiHhUHGTLbprfQhgNnY6YPVjiL5hsnjObytIiNrSBtM2eq1uE0YeiQc1VEwPw4+S5EQdGgsTPY50VVGYT7yEE6u09yMIHQXKucBGHVwAshY5cP+zDWpx6nOCNjglIRcDdA4tVXgIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.zohomail.com with SMTPS id 1602943423770775.1044647150131; Sat, 17 Oct 2020 07:03:43 -0700 (PDT) Received: by mail-wm1-f47.google.com with SMTP id e23so6138374wme.2 for ; Sat, 17 Oct 2020 07:03:43 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (117.red-83-52-172.dynamicip.rima-tde.net. [83.52.172.117]) by smtp.gmail.com with ESMTPSA id e11sm3013725wrj.75.2020.10.17.07.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2020 07:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LfhnJlD5ICt8SM68uBqo2cJX//28deS2z59iVNfu0PI=; b=JfYiAQd/bhekY/nPqLmhS0HWkfBC73prgWUMUtFgcG4iQaQtgGhh9z06CeSeIKwJrv 4JeTvDoqmZs66JC5j46jngl0fj7oaCR+OwxONsXdAKCTY+itW4wk9i1Ehz/5ayI3vIiR 7eUDp4LUnwnzpSZIV8QHMdsmdoIMMyfLcsSK0O1X2tpK3AO1rVWIjkBrETRBcECJv0l8 yigZyxjky+3UXCX5+TXJdd2zRx/jZm15csBXKvSvpZD6J4Mvvsxlg7yDs6d9+GcSwFiw ayWWTxhxJ5HsLX6R64kmMWJAMoyfemq9LxzdAWI7yrhQUG7Rtp2WHw1hQaYUcyi2hG9Q irRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=LfhnJlD5ICt8SM68uBqo2cJX//28deS2z59iVNfu0PI=; b=ViaOUgoXtKqwQjz5TKpyAbtnZ1AsPeQgysHc1cb0MgTjxKMBMMQbMnu4tyrqn1nqR/ oZ5My/qcKAFzUSeWfOeiA2drLMrku3ZsaAOhraOXtL7JuiXiWZrxJ6KIND+jLaNd/KAP pr0CKJ1TY3am9ER5fJqCNxwAr/kbhb+jhIA1bjaY7HchbzowlyPpSaKIKr0eNpX4GGtq 9S9y0X0iG12KqWki2lCXcgG378kJtC1mWVWHk3VbTTmtxkrajC+Kont1r7uPjm8Y+Duf c0bdDoXHbxB7qGKrJpx1CYuAmu3pCiSNVDBNLCtx0dNNRFe8t1GcExu41NsUUlsrLnX+ 3/cw== X-Gm-Message-State: AOAM530L0HFSJQfAiilPhuuKy0g9LN3jPJoHXTRDF+xgz1RBNACRYdpZ GX8Obzy/OK3SfYCVdlblzVg= X-Google-Smtp-Source: ABdhPJxuGE3erFN1R3CnyNhjkcDeOQbvlhsJ6lxe8pRD9gkn5Yeqh/ay8KId3J23Shb40JAI+v/zlw== X-Received: by 2002:a1c:bb06:: with SMTP id l6mr8944254wmf.40.1602943421884; Sat, 17 Oct 2020 07:03:41 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Huacai Chen , Paul Burton , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 12/44] target/mips/op_helper: Document Invalidate/Writeback opcodes as no-op Date: Sat, 17 Oct 2020 16:02:11 +0200 Message-Id: <20201017140243.1078718-13-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201017140243.1078718-1-f4bug@amsat.org> References: <20201017140243.1078718-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) QEMU does not model caches, so there is not much to do with the Invalidate/Writeback opcodes. Make it explicit adding a comment. Suggested-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Jiaxun Yang Message-Id: <20200813181527.22551-3-f4bug@amsat.org> --- target/mips/op_helper.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index c15f5c07761..2496d1dd718 100644 --- a/target/mips/op_helper.c +++ b/target/mips/op_helper.c @@ -1586,6 +1586,11 @@ void helper_cache(CPUMIPSState *env, target_ulong ad= dr, uint32_t op) memory_region_dispatch_read(env->itc_tag, index, &env->CP0_TagLo, MO_64, MEMTXATTRS_UNSPECIFIED); break; + case 0b000: /* Index Invalidate */ + case 0b100: /* Hit Invalidate */ + case 0b110: /* Hit Writeback */ + /* no-op */ + break; default: break; } --=20 2.26.2