From nobody Sun Feb 8 22:34:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1602828002; cv=none; d=zohomail.com; s=zohoarc; b=Om1L3rmnpmyVM21t+XtSNUOBZVD6AvcaPM7brADxMT7A8KyCLp0qJCBBeF2t0iljztI0KXP0N6PjRz1hXQ+Q86JO8tbTP20t3Ob8F+Kz90kC2ySEnJJPWr0/jlD7Lmh3N9P/+zvv11YI4KaY6e7CZCIXLaMrbBKX8zT2LxKZITg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602828002; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ix7cQpoM3cMFb0V0iYFqtkfBNCl/+1RR6ykxdcV61PM=; b=gFAI6pPZ4CXbmtaXee4IA07EH2Rir44bXXI9W4VKj6mamt5i5uUaZqaavYstMpOHMEorotcdXjknyRNK9Dlq2yw4nVlkE6XVQ3cIO0FMfdQYklgXGlnTXs6DKC6yywDap9w/6vGkqz2QBUsN5e1zjgLJQRSdMhtsTluSAjNZFxc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602828002160592.4754924493272; Thu, 15 Oct 2020 23:00:02 -0700 (PDT) Received: from localhost ([::1]:48398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTImW-0005Ac-NR for importer@patchew.org; Fri, 16 Oct 2020 02:00:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTIhb-0006T6-KT for qemu-devel@nongnu.org; Fri, 16 Oct 2020 01:54:55 -0400 Received: from mga01.intel.com ([192.55.52.88]:36617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTIhY-0005C7-Rj for qemu-devel@nongnu.org; Fri, 16 Oct 2020 01:54:55 -0400 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 22:54:51 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 22:54:50 -0700 IronPort-SDR: 9+EeAK4TpHfpBdWsFnnpz5+pCj4Tf7/MZf8qq5ERN9apJLr6KZ2jEpQiykCmGjHb65hm1NxtCE hjst1FNKz/AQ== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="184094672" X-IronPort-AV: E=Sophos;i="5.77,381,1596524400"; d="scan'208";a="184094672" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: jLsYW2IXI9kbNuT30BT4XRmFWsiKrCWx5Gxs/IRXrEcBx7UcH76Al+1DVTATS6Y9oq55y2ToQZ GAsILxeh4FqQ== X-IronPort-AV: E=Sophos;i="5.77,381,1596524400"; d="scan'208";a="464572855" From: Zhang Chen To: Jason Wang , qemu-dev Subject: [PATCH V2 08/10] net/colo-compare.c: Change the timer clock type Date: Fri, 16 Oct 2020 13:52:06 +0800 Message-Id: <20201016055208.7969-9-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201016055208.7969-1-chen.zhang@intel.com> References: <20201016055208.7969-1-chen.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.88; envelope-from=chen.zhang@intel.com; helo=mga01.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/16 01:54:36 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, FROM_ADDR_WS=2.996, FROM_WSP_TRAIL=1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Derek Su , Zhang Chen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhang Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Zhang Chen The virtual clock only runs during the emulation. It stops when the virtual machine is stopped. The host clock should be used for device models that emulate accurate real time sources. It will continue to run when the virtual machine is suspended. COLO need to know the host time here. Fixes: dd321ecfc2e ("colo-compare: Use IOThread to Check old packet regularly and Process packets of the primary") Reported-by: Derek Su Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- net/colo-compare.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 76b83a9ca0..1263203e7f 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -900,7 +900,7 @@ static void check_old_packet_regular(void *opaque) =20 /* if have old packet we will notify checkpoint */ colo_old_packet_check(s); - timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL)= + + timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_HOST) + s->expired_scan_cycle); } =20 @@ -934,10 +934,10 @@ static void colo_compare_timer_init(CompareState *s) { AioContext *ctx =3D iothread_get_aio_context(s->iothread); =20 - s->packet_check_timer =3D aio_timer_new(ctx, QEMU_CLOCK_VIRTUAL, + s->packet_check_timer =3D aio_timer_new(ctx, QEMU_CLOCK_HOST, SCALE_MS, check_old_packet_regular, s); - timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL)= + + timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_HOST) + s->expired_scan_cycle); } =20 --=20 2.17.1