From nobody Sun Feb 8 19:02:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602691127; cv=none; d=zohomail.com; s=zohoarc; b=L6lhnPwaMTDafTHk6fGiEZHnKFrUIDuXHD78djIbv2pLgLgEah13PmUtgK5LkBbCw4dhEwKCR9wAU20kaGElHx01Od/JSr26Tvd1bexOxZABfwo0Z9RYMVOWocSlMbVDsTKyYHh9ftKmDybtA9UlWyyL97Rb5hHzkA44V/MI2Mo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602691127; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=n55Tojzee3U5y86sm0YRlgiaSZuSyN/j5wbWS6M55NQ=; b=d+66V7I5ImItxZPVW2BHPVMAjtkfS4Y82X8GpyDwvWRlXXu8rLQ19DED8OOnfGMhAmEJnvsIeE0LY4eS+1/tDVCY9rSw+AKtXia7NLPoBSw6o2WOJwctjvxZ2kmfQPF1A9XIrAOKooidq+7aD1/ZfYrUl6Vatjv9vekqDyYn7iQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1602691127298760.2470384684493; Wed, 14 Oct 2020 08:58:47 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-542-XpUgnYAZO3S_bXdkxIQLFw-1; Wed, 14 Oct 2020 11:58:44 -0400 Received: by mail-wr1-f72.google.com with SMTP id i6so1534999wrx.11 for ; Wed, 14 Oct 2020 08:58:44 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id y14sm52505wma.48.2020.10.14.08.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 08:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602691126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n55Tojzee3U5y86sm0YRlgiaSZuSyN/j5wbWS6M55NQ=; b=DUs651IHMsGvdqm/FqvOVf0zwjdTKa0g4pQr5w93PH/WY+4aMY0Lb1UpQT3fw2Yu2XZI+t pd1CJiXWWkCZqP9RwnFpwL3DAH9bGkgkpnCNiLJAu50jkF6oaZTYVLbu5CNVMRFJXYfBGJ aUjoV+LNduvgE7W0I+lZa6+FRJdbkfQ= X-MC-Unique: XpUgnYAZO3S_bXdkxIQLFw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n55Tojzee3U5y86sm0YRlgiaSZuSyN/j5wbWS6M55NQ=; b=kcp+1U0E+iX/LNmBaWs5o0kxhP+VjiQV7h3Et0pdFXTB1h4EV0KR9cxwuJsqUMmlE3 E2yM9xxNV2SyMylaiuFLaWq7n+EyoNKy6l0FYKkZZQqNIfeJlQogNQ5xzMDoOeZ614U7 H5ceruG12rPw40b17rtIYnmyn0CmmfuqUEqwPdsD7ucBiMQdL/IemuYMBV2h/4DK2Pvm blTXWjeQtKRSwXcSQ3CGaU1Wl7WAHmFJax96p17X6gMEahTEoB8NtU/MVXJ0TyzcrA7u WDtKlAhpK7rlr54VbmVt9EXoaTUBP62rhIWQvN+xKRrs8xnspVXg4WgkFv72NEEfQLhP NaKw== X-Gm-Message-State: AOAM530l1ewPP4PCMn9hbtWiq21Y2GeKmbkRfyJmjg+nTEat9D9ap0Kv Q2/G5PZLL6BFymBI1ZzuQOsrk5yZxsANTyi8Ek1J0VIzhioWGBrxMddY+H+qNIs6gjOOwWoiFW/ 7J0jZIX+vbYGa2A== X-Received: by 2002:a1c:e48b:: with SMTP id b133mr142439wmh.0.1602691123050; Wed, 14 Oct 2020 08:58:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxU5/fKCXdU6560Jh9AUqT/0+Qts4e54qcj5ajEnL+jQMGHTPBVChIr9SLcJF5frgRKodrzrQ== X-Received: by 2002:a1c:e48b:: with SMTP id b133mr142431wmh.0.1602691122885; Wed, 14 Oct 2020 08:58:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Fam Zheng , Stefan Hajnoczi , Kevin Wolf , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 06/15] block/nvme: Make nvme_identify() return boolean indicating error Date: Wed, 14 Oct 2020 17:58:01 +0200 Message-Id: <20201014155810.102841-7-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201014155810.102841-1-philmd@redhat.com> References: <20201014155810.102841-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block/nvme.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/nvme.c b/block/nvme.c index 95f19e12cd6..95f8f8b360b 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -496,9 +496,11 @@ static int nvme_cmd_sync(BlockDriverState *bs, NVMeQue= uePair *q, return ret; } =20 -static void nvme_identify(BlockDriverState *bs, int namespace, Error **err= p) +/* Returns true on success, false on failure. */ +static bool nvme_identify(BlockDriverState *bs, int namespace, Error **err= p) { BDRVNVMeState *s =3D bs->opaque; + bool ret =3D false; union { NvmeIdCtrl ctrl; NvmeIdNs ns; @@ -575,10 +577,13 @@ static void nvme_identify(BlockDriverState *bs, int n= amespace, Error **errp) goto out; } =20 + ret =3D true; s->blkshift =3D lbaf->ds; out: qemu_vfio_dma_unmap(s->vfio, id); qemu_vfree(id); + + return ret; } =20 static bool nvme_poll_queue(NVMeQueuePair *q) --=20 2.26.2