From nobody Sun Feb 8 09:33:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602677718; cv=none; d=zohomail.com; s=zohoarc; b=cLoCO6/aJNygUJpK9AOzpSElSn8LnYhNKWK1a9QknKzneOgbX8MzLJUVKBhc0BYnmYHVSxFsKgbA3tTdve2B7gx/D/DMlEJVQWkzbyPHZohwkP0ypiyRc7pB6oV095AZpU1Esm7C42l1mo8Eo54GHc/4alqTGprIry7LUzcFDxM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602677718; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cD9WkUKSOWy1oXoBE3GlVH0FFoEMnzc1QrCN8Qgu+Bc=; b=EPdwhZQ1pqy32LJtSmrmnd/2JW4k9Bd640aJUel26ZRgJVRG6CKxJQNLwPI+YDP1PkW9QUrdUa/tvMrKF2UoayJJ7eB8iFQGqZ5YgJXs0+xPGo6pWdAzvq979eAQRUKizKPDGrGoBAp4m1P0RMsKAfFxONUhWRrdVomMyEEpplU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602677718509625.731632153152; Wed, 14 Oct 2020 05:15:18 -0700 (PDT) Received: from localhost ([::1]:45296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSfgb-00082Q-Pe for importer@patchew.org; Wed, 14 Oct 2020 08:15:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSfd1-00050b-FN for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSfcz-0003NE-NI for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:35 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-523-KJK-zK6fO7KuS-9vAswpBQ-1; Wed, 14 Oct 2020 08:11:31 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9ED78801FCC for ; Wed, 14 Oct 2020 12:11:30 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id E6AE45C882; Wed, 14 Oct 2020 12:11:21 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EAE3F9A95; Wed, 14 Oct 2020 14:11:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602677493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cD9WkUKSOWy1oXoBE3GlVH0FFoEMnzc1QrCN8Qgu+Bc=; b=AvKu01hYKBjasoI0tqB2StaJ0ww5DqmULItzWSBkEBGmutTDh0TI/GL4pwgjprACuu1CDC DhUJE3M5dK6BOqZV8whPSP+XzKiRUFNpuOMMdjeCDCWJXme0P8k4OH7FUhLJ/dezXSOr0A GBmRRN8mIn1VGTznU2bejuBoNwM8yKg= X-MC-Unique: KJK-zK6fO7KuS-9vAswpBQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v5 1/7] qemu-edid: drop cast Date: Wed, 14 Oct 2020 14:11:14 +0200 Message-Id: <20201014121120.13482-2-kraxel@redhat.com> In-Reply-To: <20201014121120.13482-1-kraxel@redhat.com> References: <20201014121120.13482-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 01:12:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Not needed and makes some compilers error out with: qemu-edid.c:15:1: error: initializer element is not constant Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrang=C3=A9 Message-id: 20201013091615.14166-1-kraxel@redhat.com --- qemu-edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-edid.c b/qemu-edid.c index 1db3372b982c..1cd6a9517238 100644 --- a/qemu-edid.c +++ b/qemu-edid.c @@ -9,7 +9,7 @@ #include "qemu/cutils.h" #include "hw/display/edid.h" =20 -static qemu_edid_info info =3D (qemu_edid_info) { +static qemu_edid_info info =3D { .prefx =3D 1024, .prefy =3D 768, }; --=20 2.27.0 From nobody Sun Feb 8 09:33:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602677642; cv=none; d=zohomail.com; s=zohoarc; b=B/rxIy1E6uYwuowHhfkBEjnozIQQywBLo5KZZlb5rD8QNijZ2LtkBAUbYRKOet688XHMZN3k+q0+qTvVhmkbmSgUIOtjZT0lJsHifMa+x/kFCCxJa9BoXR9cRbzrL9JIHhCrqQFSXrBhnL4r51zAdyUTq9k8PxiW2NT5heS6uIE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602677642; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=t0zrZnk/mtyFuALg4bVX3ckcLL+sGEU01fnMcB+jN4s=; b=T5Rz9blk5wctBykcvkYcV0HiIJyyZmG+X7bHO9aWZiY+BI5Jfxq0tY2+XLXU7d7PODyBTMx8eqI5JYY0sjzWigrRrm2jBvHZw9XxSwOXIAf9d0fNPDDLxJ85WdnJXS1TMRbOCeHEWJ3mau4KDOdNPZh1Mlp9nYHmbnYPinRKacQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602677642521180.09477321681425; Wed, 14 Oct 2020 05:14:02 -0700 (PDT) Received: from localhost ([::1]:42766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSffN-0006v1-3x for importer@patchew.org; Wed, 14 Oct 2020 08:14:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSfd1-0004zg-36 for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSfcy-0003Ll-SU for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:34 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-zuLVuwXEOh2cAqKZOL1CmA-1; Wed, 14 Oct 2020 08:11:30 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E8A818BE16D for ; Wed, 14 Oct 2020 12:11:29 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id C94D55D9CD; Wed, 14 Oct 2020 12:11:22 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id F3F5F43BFB8; Wed, 14 Oct 2020 14:11:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602677491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t0zrZnk/mtyFuALg4bVX3ckcLL+sGEU01fnMcB+jN4s=; b=HTLk83JFFUPwCmW+zCCwyGOWbav7feA5zsWAAWy1Yakmy3nXrbihcb/6QUzSXxCfeQcJcM 5OeBEG/tT2pKdXNdNLptjAN0pi/KpTtaDydqxmo2BFHIlb7b9A2cHN+4HrGZCu+l/J9KwW 4ABxqw5F9i8FITZzm9vN6vFyT5jsPuY= X-MC-Unique: zuLVuwXEOh2cAqKZOL1CmA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v5 2/7] ui/spice-app: don't use qemu_chr_open_spice_port directly Date: Wed, 14 Oct 2020 14:11:15 +0200 Message-Id: <20201014121120.13482-3-kraxel@redhat.com> In-Reply-To: <20201014121120.13482-1-kraxel@redhat.com> References: <20201014121120.13482-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 03:37:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Save the parent object's open function pointer in the (new) VCChardevClass struct instead before overwriting it, so we can look it up when needed. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- ui/spice-app.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/ui/spice-app.c b/ui/spice-app.c index 93e105c6ee82..7e0550c79fdd 100644 --- a/ui/spice-app.c +++ b/ui/spice-app.c @@ -44,11 +44,15 @@ static char *sock_path; struct VCChardev { SpiceChardev parent; }; -typedef struct VCChardev VCChardev; + +struct VCChardevClass { + ChardevClass parent; + void (*parent_open)(Chardev *chr, ChardevBackend *backend, + bool *be_opened, Error **errp); +}; =20 #define TYPE_CHARDEV_VC "chardev-vc" -DECLARE_INSTANCE_CHECKER(VCChardev, VC_CHARDEV, - TYPE_CHARDEV_VC) +OBJECT_DECLARE_TYPE(VCChardev, VCChardevClass, CHARDEV_VC) =20 static ChardevBackend * chr_spice_backend_new(void) @@ -66,6 +70,7 @@ static void vc_chr_open(Chardev *chr, bool *be_opened, Error **errp) { + VCChardevClass *vc =3D CHARDEV_VC_GET_CLASS(chr); ChardevBackend *be; const char *fqdn =3D NULL; =20 @@ -80,7 +85,7 @@ static void vc_chr_open(Chardev *chr, be =3D chr_spice_backend_new(); be->u.spiceport.data->fqdn =3D fqdn ? g_strdup(fqdn) : g_strdup_printf("org.qemu.console.%s", chr->label= ); - qemu_chr_open_spice_port(chr, be, be_opened, errp); + vc->parent_open(chr, be, be_opened, errp); qapi_free_ChardevBackend(be); } =20 @@ -91,8 +96,11 @@ static void vc_chr_set_echo(Chardev *chr, bool echo) =20 static void char_vc_class_init(ObjectClass *oc, void *data) { + VCChardevClass *vc =3D CHARDEV_VC_CLASS(oc); ChardevClass *cc =3D CHARDEV_CLASS(oc); =20 + vc->parent_open =3D cc->open; + cc->parse =3D qemu_chr_parse_vc; cc->open =3D vc_chr_open; cc->chr_set_echo =3D vc_chr_set_echo; @@ -103,6 +111,7 @@ static const TypeInfo char_vc_type_info =3D { .parent =3D TYPE_CHARDEV_SPICEPORT, .instance_size =3D sizeof(VCChardev), .class_init =3D char_vc_class_init, + .class_size =3D sizeof(VCChardevClass), }; =20 static void spice_app_atexit(void) --=20 2.27.0 From nobody Sun Feb 8 09:33:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602677642; cv=none; d=zohomail.com; s=zohoarc; b=TfXyplGEbTqgE4zR33LZv77VwLOHOeFMVMn2F2HARt/NMo4P7919eqkJEr7pMCw6OL58ewXHTb/PVA3lU1IK+p4Fq9qyszbNfiIrL6E7TQRkBzAXUEYMFOBfOKZjXfIuvnfHeXCZUn89YtlMjrzBMM5vkj61AnHF9Jcg/KhibBw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602677642; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yMBmbg7SUQKRbE0citzPb/yjsoHzYvKjWAcF04LGDBE=; b=GrVzq6egf6NguUZ0RozL6tU5NUTXhrCDPoQizNdzRjhKrmdH/BWPOYzrnoP9T2J0hHVmkk/aSbjQi1GmetEt5r+FsREBCc12mbzXr1UMjQ0wecL7KNsewivGeA5+hwOF0MOhMuBspFUYVTeLfa5CLbWohSXDWuqGqowzv4+dJtw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602677642957188.8088330161646; Wed, 14 Oct 2020 05:14:02 -0700 (PDT) Received: from localhost ([::1]:42840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSffO-0006xk-6Y for importer@patchew.org; Wed, 14 Oct 2020 08:14:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSfd0-0004xx-2i for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSfcy-0003LY-5D for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:33 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-DYnMxzXMMv2FK8r7Ls8B_g-1; Wed, 14 Oct 2020 08:11:29 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A72D1801FCC for ; Wed, 14 Oct 2020 12:11:28 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14B6F7366B; Wed, 14 Oct 2020 12:11:21 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0A50A6DE2; Wed, 14 Oct 2020 14:11:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602677491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yMBmbg7SUQKRbE0citzPb/yjsoHzYvKjWAcF04LGDBE=; b=IVIHFVRDmXm4UKs9YAmVnFtTRXieZ+7ap6ziCy7py6ijr+G0zyXG9W8gQMzcv8v7Kj7jVY sIYoqrmOvYGdBzGSF0Kq5e5KHZ5NltVb8WkCdrPvQ6Q5vDYrwLsMnI/v5KjLTUJUUM7k2C ngUY3eSM0a18o/rCeKW7xSX44BQX8vE= X-MC-Unique: DYnMxzXMMv2FK8r7Ls8B_g-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v5 3/7] chardev/spice: make qemu_chr_open_spice_port static Date: Wed, 14 Oct 2020 14:11:16 +0200 Message-Id: <20201014121120.13482-4-kraxel@redhat.com> In-Reply-To: <20201014121120.13482-1-kraxel@redhat.com> References: <20201014121120.13482-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 01:12:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/chardev/spice.h | 3 --- chardev/spice.c | 8 ++++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/chardev/spice.h b/include/chardev/spice.h index 99f26aedde54..1115502cdfbd 100644 --- a/include/chardev/spice.h +++ b/include/chardev/spice.h @@ -24,7 +24,4 @@ typedef struct SpiceChardev SpiceChardev; DECLARE_INSTANCE_CHECKER(SpiceChardev, SPICE_CHARDEV, TYPE_CHARDEV_SPICE) =20 -void qemu_chr_open_spice_port(Chardev *chr, ChardevBackend *backend, - bool *be_opened, Error **errp); - #endif diff --git a/chardev/spice.c b/chardev/spice.c index bf7ea1e2940d..051c23a84f4c 100644 --- a/chardev/spice.c +++ b/chardev/spice.c @@ -296,10 +296,10 @@ static void qemu_chr_open_spice_vmc(Chardev *chr, chr_open(chr, type); } =20 -void qemu_chr_open_spice_port(Chardev *chr, - ChardevBackend *backend, - bool *be_opened, - Error **errp) +static void qemu_chr_open_spice_port(Chardev *chr, + ChardevBackend *backend, + bool *be_opened, + Error **errp) { ChardevSpicePort *spiceport =3D backend->u.spiceport.data; const char *name =3D spiceport->fqdn; --=20 2.27.0 From nobody Sun Feb 8 09:33:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602677876; cv=none; d=zohomail.com; s=zohoarc; b=fudFiZnGspUwAJ+g49lOi9zktt/M0QOhypgMbJGK3aAlvJkNwRoUEYkVIW9kKelnBSPqJD0kvzK0HL5dN/bZ2ymxNsrHiiP884hZkdYnUeZpxcGdsWyfeyO9c4IMIjbgCbZ8A9OKfbzLC8QjMWdYJvSMUwcqBpt/ynBnQo4IErg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602677876; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G6myWME/MwhZrqSHEJYyEGL4dVNEEsuXkuDXXdLn8aU=; b=ka/uKq0P6MC/43OPpLr0LyU6p2wT3R2lmkTd0dxfVTAqrG8pkrLx2lwN1nQEFnuGW/RJa1q91Ur7V4hojNqlfdbW2eTXtagxwFwWLZzxt3mdXewHWvtGdvkn+CAFH67lQl6Vcy2ioc5WAPdUWrOWEAr2pNk7ZoDfrTRe9lE8ssI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602677876088157.20928361602319; Wed, 14 Oct 2020 05:17:56 -0700 (PDT) Received: from localhost ([::1]:51154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSfj9-0002K1-9r for importer@patchew.org; Wed, 14 Oct 2020 08:17:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSfd2-00052L-6U for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSfcy-0003Le-AE for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:35 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-F3QnrZopOn63cUe7C8PO0g-1; Wed, 14 Oct 2020 08:11:29 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1EDE107AFAF for ; Wed, 14 Oct 2020 12:11:28 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id F29CC73669; Wed, 14 Oct 2020 12:11:21 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1B93143BFB9; Wed, 14 Oct 2020 14:11:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602677491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G6myWME/MwhZrqSHEJYyEGL4dVNEEsuXkuDXXdLn8aU=; b=gnqCPXZTp9WdIHTrMUNUheiQ2A4G+NXUUiiJ+yPxQM1ovUuLX26h/HJyl6SkxzCsqBAL2c 5zng9LGtg4FjQ6WHEbfhBIt69oWVpOjhb8QNZATkzglGdlFcYwsiDiq3GiESsQNo51OeL7 Q7wcj79GLdKbrYNCzoRJHJur/jE4XP0= X-MC-Unique: F3QnrZopOn63cUe7C8PO0g-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v5 4/7] chardev/spice: simplify chardev setup Date: Wed, 14 Oct 2020 14:11:17 +0200 Message-Id: <20201014121120.13482-5-kraxel@redhat.com> In-Reply-To: <20201014121120.13482-1-kraxel@redhat.com> References: <20201014121120.13482-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 01:12:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Initialize spice before chardevs. That allows to register the spice chardevs directly in the init function and removes the need to maintain a linked list of chardevs just for registration. Signed-off-by: Gerd Hoffmann --- include/chardev/spice.h | 1 - include/ui/qemu-spice.h | 1 - chardev/spice.c | 29 ++++++----------------------- softmmu/vl.c | 9 +++++---- ui/spice-app.c | 17 +++++++++-------- ui/spice-core.c | 2 -- 6 files changed, 20 insertions(+), 39 deletions(-) diff --git a/include/chardev/spice.h b/include/chardev/spice.h index 1115502cdfbd..58e5b727e9fe 100644 --- a/include/chardev/spice.h +++ b/include/chardev/spice.h @@ -13,7 +13,6 @@ struct SpiceChardev { bool blocked; const uint8_t *datapos; int datalen; - QLIST_ENTRY(SpiceChardev) next; }; typedef struct SpiceChardev SpiceChardev; =20 diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h index 12474d88f40e..0e8ec3f0d776 100644 --- a/include/ui/qemu-spice.h +++ b/include/ui/qemu-spice.h @@ -45,7 +45,6 @@ int qemu_spice_migrate_info(const char *hostname, int por= t, int tls_port, #else #define SPICE_NEEDS_SET_MM_TIME 0 #endif -void qemu_spice_register_ports(void); =20 #else /* CONFIG_SPICE */ =20 diff --git a/chardev/spice.c b/chardev/spice.c index 051c23a84f4c..7d1fb1771894 100644 --- a/chardev/spice.c +++ b/chardev/spice.c @@ -14,9 +14,6 @@ typedef struct SpiceCharSource { SpiceChardev *scd; } SpiceCharSource; =20 -static QLIST_HEAD(, SpiceChardev) spice_chars =3D - QLIST_HEAD_INITIALIZER(spice_chars); - static int vmc_write(SpiceCharDeviceInstance *sin, const uint8_t *buf, int= len) { SpiceChardev *scd =3D container_of(sin, SpiceChardev, sin); @@ -216,8 +213,6 @@ static void char_spice_finalize(Object *obj) =20 vmc_unregister_interface(s); =20 - QLIST_SAFE_REMOVE(s, next); - g_free((char *)s->sin.subtype); g_free((char *)s->sin.portname); } @@ -256,8 +251,6 @@ static void chr_open(Chardev *chr, const char *subtype) =20 s->active =3D false; s->sin.subtype =3D g_strdup(subtype); - - QLIST_INSERT_HEAD(&spice_chars, s, next); } =20 static void qemu_chr_open_spice_vmc(Chardev *chr, @@ -310,28 +303,18 @@ static void qemu_chr_open_spice_port(Chardev *chr, return; } =20 + if (!using_spice) { + error_setg(errp, "spice not enabled"); + return; + } + chr_open(chr, "port"); =20 *be_opened =3D false; s =3D SPICE_CHARDEV(chr); s->sin.portname =3D g_strdup(name); =20 - if (using_spice) { - /* spice server already created */ - vmc_register_interface(s); - } -} - -void qemu_spice_register_ports(void) -{ - SpiceChardev *s; - - QLIST_FOREACH(s, &spice_chars, next) { - if (s->sin.portname =3D=3D NULL) { - continue; - } - vmc_register_interface(s); - } + vmc_register_interface(s); } =20 static void qemu_chr_parse_spice_vmc(QemuOpts *opts, ChardevBackend *backe= nd, diff --git a/softmmu/vl.c b/softmmu/vl.c index 254ee5e525d1..cb476aa70bcc 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -4148,6 +4148,11 @@ void qemu_init(int argc, char **argv, char **envp) user_creatable_add_opts_foreach, object_create_initial, &error_fatal); =20 + /* spice needs the timers to be initialized by this point */ + /* spice must initialize before audio as it changes the default auiode= v */ + /* spice must initialize before chardevs (for spicevmc and spiceport) = */ + qemu_spice_init(); + qemu_opts_foreach(qemu_find_opts("chardev"), chardev_init_func, NULL, &error_fatal); =20 @@ -4156,10 +4161,6 @@ void qemu_init(int argc, char **argv, char **envp) fsdev_init_func, NULL, &error_fatal); #endif =20 - /* spice needs the timers to be initialized by this point */ - /* spice must initialize before audio as it changes the default auiode= v */ - qemu_spice_init(); - /* * Note: we need to create audio and block backends before * machine_set_property(), so machine properties can refer to diff --git a/ui/spice-app.c b/ui/spice-app.c index 7e0550c79fdd..026124ef56a0 100644 --- a/ui/spice-app.c +++ b/ui/spice-app.c @@ -129,7 +129,6 @@ static void spice_app_atexit(void) static void spice_app_display_early_init(DisplayOptions *opts) { QemuOpts *qopts; - ChardevBackend *be =3D chr_spice_backend_new(); GError *err =3D NULL; =20 if (opts->has_full_screen) { @@ -174,6 +173,15 @@ static void spice_app_display_early_init(DisplayOption= s *opts) qemu_opt_set(qopts, "gl", opts->has_gl ? "on" : "off", &error_abort); display_opengl =3D opts->has_gl; #endif +} + +static void spice_app_display_init(DisplayState *ds, DisplayOptions *opts) +{ + ChardevBackend *be =3D chr_spice_backend_new(); + QemuOpts *qopts; + GError *err =3D NULL; + gchar *uri; + be->u.spiceport.data->fqdn =3D g_strdup("org.qemu.monitor.qmp.0"); qemu_chardev_new("org.qemu.monitor.qmp", TYPE_CHARDEV_SPICEPORT, be, NULL, &error_abort); @@ -183,13 +191,6 @@ static void spice_app_display_early_init(DisplayOption= s *opts) qemu_opt_set(qopts, "mode", "control", &error_abort); =20 qapi_free_ChardevBackend(be); -} - -static void spice_app_display_init(DisplayState *ds, DisplayOptions *opts) -{ - GError *err =3D NULL; - gchar *uri; - uri =3D g_strjoin("", "spice+unix://", app_dir, "/", "spice.sock", NUL= L); info_report("Launching display with URI: %s", uri); g_app_info_launch_default_for_uri(uri, NULL, &err); diff --git a/ui/spice-core.c b/ui/spice-core.c index 10aa309f78f7..47700b220059 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -812,8 +812,6 @@ void qemu_spice_init(void) g_free(x509_cert_file); g_free(x509_cacert_file); =20 - qemu_spice_register_ports(); - #ifdef HAVE_SPICE_GL if (qemu_opt_get_bool(opts, "gl", 0)) { if ((port !=3D 0) || (tls_port !=3D 0)) { --=20 2.27.0 From nobody Sun Feb 8 09:33:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602678136; cv=none; d=zohomail.com; s=zohoarc; b=SJ07yTlQ2GqENTSr2RYwh9AUOZFh6hJPqfIWPAGN36jH9B8epV60g0cEOiW1ITmcnafo33cnGq8w4C4jLht3wAgA1UzORMQ5M63WbWFpX3GIr3+ULR+DZNj8S7D1EalXoBgbWLPeZ1JmXdrs88SvTcu5ESi6f5bpiRIxm/oH4rI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602678136; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9y7GTVMnJIb0gY81xHrDyXRIuOvWrtlPgNQSlfQwSxk=; b=bIMlGnpkdF4NLdzd0q2A+DWAKB0K1JZa4kX+xMqbpqwvNw76zWdAlVbwSIAZFvD2AMbJ3EqOCYfdgyWQkBzur/F0yeJKUlBTi/dbSqXXlwc6Qge61s/OQ6UpC/MbV8IUE+fKPb/5MCjybCgfeBDdizYBPKyOuJRlrvsoN0WpB/Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602678136912814.9526325223434; Wed, 14 Oct 2020 05:22:16 -0700 (PDT) Received: from localhost ([::1]:58334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSfnL-0005ZH-JU for importer@patchew.org; Wed, 14 Oct 2020 08:22:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSfd3-00054i-74 for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSfcz-0003NK-VL for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:36 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-517-4FbAlbMxN5OWDzk4fQOURA-1; Wed, 14 Oct 2020 08:11:30 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D636A107AFB2 for ; Wed, 14 Oct 2020 12:11:29 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98B9A5D9CD; Wed, 14 Oct 2020 12:11:29 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 27B1B43BFBA; Wed, 14 Oct 2020 14:11:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602677493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9y7GTVMnJIb0gY81xHrDyXRIuOvWrtlPgNQSlfQwSxk=; b=e0nGGoNh5l5KY8k0GjLgR37lgf1Q10Tt/bd4Wtlchep+oauLbWOQcFw0vAkZCKF9zgAopq 1UXhedYbhO6+idjo8wicJ1ujJ6IxOFY5UXY7kM38JbYNqA2ow//oNDkvPK2H4DOv5Nsw0d mGCAnKQzBfUGxRqjsmRBYLYX9ICKwBQ= X-MC-Unique: 4FbAlbMxN5OWDzk4fQOURA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v5 5/7] meson: add spice_headers dependency. Date: Wed, 14 Oct 2020 14:11:18 +0200 Message-Id: <20201014121120.13482-6-kraxel@redhat.com> In-Reply-To: <20201014121120.13482-1-kraxel@redhat.com> References: <20201014121120.13482-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 01:12:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Used for files which (with CONFIG_SPICE=3Dy) depend on spice header files to pick up some enum, but which do not depend on on the actual spice shared library. Signed-off-by: Gerd Hoffmann --- audio/meson.build | 2 +- meson.build | 2 ++ monitor/meson.build | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/audio/meson.build b/audio/meson.build index 18a831129ed0..7d53b0f920ff 100644 --- a/audio/meson.build +++ b/audio/meson.build @@ -1,5 +1,5 @@ +softmmu_ss.add([spice_headers, files('audio.c')]) softmmu_ss.add(files( - 'audio.c', 'audio_legacy.c', 'mixeng.c', 'noaudio.c', diff --git a/meson.build b/meson.build index ad6c7c90c787..90b111d21dbd 100644 --- a/meson.build +++ b/meson.build @@ -321,9 +321,11 @@ if 'CONFIG_LIBJACK' in config_host jack =3D declare_dependency(link_args: config_host['JACK_LIBS'].split()) endif spice =3D not_found +spice_headers =3D not_found if 'CONFIG_SPICE' in config_host spice =3D declare_dependency(compile_args: config_host['SPICE_CFLAGS'].s= plit(), link_args: config_host['SPICE_LIBS'].split()) + spice_headers =3D declare_dependency(compile_args: config_host['SPICE_CF= LAGS'].split()) endif rt =3D cc.find_library('rt', required: false) libdl =3D not_found diff --git a/monitor/meson.build b/monitor/meson.build index eb2a534fdc88..6d00985ace7a 100644 --- a/monitor/meson.build +++ b/monitor/meson.build @@ -3,7 +3,7 @@ qmp_ss.add(files('monitor.c', 'qmp.c', 'qmp-cmds-control.c'= )) softmmu_ss.add(files( 'hmp-cmds.c', 'hmp.c', - 'qmp-cmds.c', )) +softmmu_ss.add([spice_headers, files('qmp-cmds.c')]) =20 specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('misc.c'), spice]) --=20 2.27.0 From nobody Sun Feb 8 09:33:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602677980; cv=none; d=zohomail.com; s=zohoarc; b=emroHAyWUgUz/cHqpgoO5+xx/vIJom0jPG6AFbIJtnZQgUq1LjWh2T7OtBH2YgNyZMxXRNPVZwWRJYB1olNtQsxnuLkDxkt6Lflx0yEQhqmB02X81jiXlj7fR4oYnTG8ChrHMACh+mn7/ohTipYAp21eRS6imriDXn/nsUYa44M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602677980; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5ipbcGctNUG+3uSEfHb5xLukKS5GIrTbTQUwsczBIt8=; b=f72indRQnhsK6qlFpxNjnxRBupKYzJP+7jjpx8bWsB3KTzeFxbbrEcWztXs72mkTbN6bg7gCcumsVzqCvm04+UnD2DJWomOBk+YnDFUzk/cNzcXhDb3RMx1heeA8KAoMvbkTmmjzB4iY5I6BMnFOw2ssZsHHNAtMxU1QyoufwbQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602677980284508.5751992887235; Wed, 14 Oct 2020 05:19:40 -0700 (PDT) Received: from localhost ([::1]:53526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSfkp-0003JG-4D for importer@patchew.org; Wed, 14 Oct 2020 08:19:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSfd8-0005E0-UB for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSfd6-0003Oc-T6 for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:42 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-526-Cw9aZMtONhigAhUwmADF4Q-1; Wed, 14 Oct 2020 08:11:38 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47CEF18BE161 for ; Wed, 14 Oct 2020 12:11:37 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9A8151992F; Wed, 14 Oct 2020 12:11:29 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 30DE843BFBB; Wed, 14 Oct 2020 14:11:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602677500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ipbcGctNUG+3uSEfHb5xLukKS5GIrTbTQUwsczBIt8=; b=F1Z14AFbN2mBbPeGq7YCTHoKhlUGqi3W7guzU8evQroHbet6GdJTPljW6mbHwFfyDv4g5+ inemJ/UIRDGxnohXup6sGYgnESCNGWHwfPNcr21Ug4vRhqLeJ6jKQAQNq/2iUMCHNzLVkw M3LHjPIi4Zbxz1WM3zH4n3xbstn/GlI= X-MC-Unique: Cw9aZMtONhigAhUwmADF4Q-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v5 6/7] meson: add spice dependency to core spice source files. Date: Wed, 14 Oct 2020 14:11:19 +0200 Message-Id: <20201014121120.13482-7-kraxel@redhat.com> In-Reply-To: <20201014121120.13482-1-kraxel@redhat.com> References: <20201014121120.13482-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 03:37:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Right now it happens to work by pure luck because the spice chardevs add the spice dependency to the softmmu source set. That'll change though once we start building spice chardevs as module, so lets fix it properly. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- ui/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/meson.build b/ui/meson.build index 8a080c38e325..bad7a3745148 100644 --- a/ui/meson.build +++ b/ui/meson.build @@ -14,7 +14,7 @@ softmmu_ss.add(files( )) =20 softmmu_ss.add(when: 'CONFIG_LINUX', if_true: files('input-linux.c')) -softmmu_ss.add(when: 'CONFIG_SPICE', if_true: files('spice-core.c', 'spice= -input.c', 'spice-display.c')) +softmmu_ss.add(when: [spice, 'CONFIG_SPICE'], if_true: files('spice-core.c= ', 'spice-input.c', 'spice-display.c')) softmmu_ss.add(when: cocoa, if_true: files('cocoa.m')) =20 vnc_ss =3D ss.source_set() --=20 2.27.0 From nobody Sun Feb 8 09:33:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602677853; cv=none; d=zohomail.com; s=zohoarc; b=R1Ex8jJNmhq+F50Ru5S/rcAhnRxwzXQSLkzB2db0edIb5r0tvIdr4vchwNbLZ+IwBBFjZOYXq1kl9KBvtPvgB7NlULau0tVEVvkIRIIeDwhXk0AKZJaNcvUVbQddFyvWl68iRc/5bQHvGRRGu98pqdM4F0MB2qksJDofF3N1c+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602677853; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DkVVvPbH98jkfOWc2FQkYqaHlvp7TtF/IsGGvo49Gyo=; b=KigL7ZSjjjlCYMhGhlyRTG9oIN9bonhbxJxfeZ6B01PNHya9QAxSDjuNOKltfblL8D76TfDlDkA1P9whNbQBsR+o3kf3eFi2bByipCtEuS6B1IzQdpSMA+if2JxrNZMqZSJJJ2W9qNN7Mqc1eAe3OAi+z6kCxknNIh41ih2Clwg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602677853583216.0901825888676; Wed, 14 Oct 2020 05:17:33 -0700 (PDT) Received: from localhost ([::1]:49212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSfim-0001OK-IJ for importer@patchew.org; Wed, 14 Oct 2020 08:17:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSfd3-00055D-Cj for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60397) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSfcz-0003NH-Uw for qemu-devel@nongnu.org; Wed, 14 Oct 2020 08:11:37 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-DW7HL7qEPsKzk-l6Bxe0og-1; Wed, 14 Oct 2020 08:11:30 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB0D7102090A for ; Wed, 14 Oct 2020 12:11:29 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D7086EF67; Wed, 14 Oct 2020 12:11:29 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 3B8C231E21; Wed, 14 Oct 2020 14:11:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602677493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DkVVvPbH98jkfOWc2FQkYqaHlvp7TtF/IsGGvo49Gyo=; b=i1Zt8ZtX0BZWOIHYUoPDyfb/lDWXhfcdEuW+QaYfBhGu1/UU4OnykMdCNSuN5mYEVJT0cf tnsrycvEJ8o5OrqFtlARWdwdQN/oBbLxP+AchCy9OhlJ9R9XkRoFjiqEw+WJXYPlnq4hZM NfIjmEgr/Nplwwhdip3nOgtyGQL3xoQ= X-MC-Unique: DW7HL7qEPsKzk-l6Bxe0og-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v5 7/7] chardev/spice: build spice chardevs as module Date: Wed, 14 Oct 2020 14:11:20 +0200 Message-Id: <20201014121120.13482-8-kraxel@redhat.com> In-Reply-To: <20201014121120.13482-1-kraxel@redhat.com> References: <20201014121120.13482-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 03:37:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Gerd Hoffmann --- util/module.c | 2 ++ chardev/meson.build | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index a44ec38d9362..4a5735dfdc76 100644 --- a/util/module.c +++ b/util/module.c @@ -264,6 +264,8 @@ static struct { { "virtio-gpu-device", "hw-", "display-virtio-gpu" }, { "vhost-user-gpu", "hw-", "display-virtio-gpu" }, { "chardev-braille", "chardev-", "baum" }, + { "chardev-spicevmc", "chardev-", "spice" }, + { "chardev-spiceport", "chardev-", "spice" }, }; =20 static bool module_loaded_qom_all; diff --git a/chardev/meson.build b/chardev/meson.build index dd2699a11b08..859d8b04d480 100644 --- a/chardev/meson.build +++ b/chardev/meson.build @@ -26,7 +26,6 @@ chardev_ss.add(when: 'CONFIG_WIN32', if_true: files( chardev_ss =3D chardev_ss.apply(config_host, strict: false) =20 softmmu_ss.add(files('chardev-sysemu.c', 'msmouse.c', 'wctablet.c', 'testd= ev.c')) -softmmu_ss.add(when: ['CONFIG_SPICE', spice], if_true: files('spice.c')) =20 chardev_modules =3D {} =20 @@ -36,4 +35,10 @@ if config_host.has_key('CONFIG_BRLAPI') chardev_modules +=3D { 'baum': module_ss } endif =20 +if config_host.has_key('CONFIG_SPICE') + module_ss =3D ss.source_set() + module_ss.add(when: [spice], if_true: files('spice.c')) + chardev_modules +=3D { 'spice': module_ss } +endif + modules +=3D { 'chardev': chardev_modules } --=20 2.27.0