From nobody Sun May 12 19:26:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1602675973; cv=none; d=zohomail.com; s=zohoarc; b=BMimJCetpStNmSnjWFfcZBM/fiyNxsZWFOeTG9QjprrLjdZaUuWD66toQtkXzACjZiG8hh1pIqDbwM4uxAvyKRR0v1cgl83pwcbYkc4YYZTaU0RRWERKZB9oEccGudIY1d4N4KzA4OuCn3D44OdtXRF/ZUFbFxvlce9aGqHgK/8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602675973; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=iyWq75mLOUAIUSDKvDQuGoNtIFhnSzIHqs2sB2UgX2c=; b=Pk25uN8iXH1i+mXi9AVRHVBTvLdIXP1UJhZS+7hNFz+P8/qzKhJfKLnnRmkG1OW7z8gMlUCZ5QGSswc7HQ/5UpEI9ClCJLHUgAjS3pXXTqA3JGssSFbxHyZlFWHRpA4FEBtBc2c34W75FmNZx+sjxMO9QxbsbDSP47Qxi09fxWY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602675973125123.10848019406671; Wed, 14 Oct 2020 04:46:13 -0700 (PDT) Received: from localhost ([::1]:36396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSfES-0004Kk-2q for importer@patchew.org; Wed, 14 Oct 2020 07:46:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSfD7-0003AW-OY; Wed, 14 Oct 2020 07:44:49 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:49882 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSfD5-0007uQ-FK; Wed, 14 Oct 2020 07:44:49 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id BD79E4EEA73786A28C5E; Wed, 14 Oct 2020 19:44:41 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Wed, 14 Oct 2020 19:44:32 +0800 From: Chen Qun To: , Subject: [PATCH v3] migration/block-dirty-bitmap: fix uninitialized variable warning Date: Wed, 14 Oct 2020 19:44:30 +0800 Message-ID: <20201014114430.1898684-1-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=kuhn.chenqun@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 07:44:42 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, ganqixin@huawei.com, vsementsov@virtuozzo.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, quintela@redhat.com, Li Qiang , dgilbert@redhat.com, mreitz@redhat.com, stefanha@redhat.com, Euler Robot , Chen Qun , jsnow@redhat.com, Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" A default value is provided for the variable 'bitmap_name' to avoid compile= r warning. The compiler show warning: migration/block-dirty-bitmap.c:1090:13: warning: =E2=80=98bitmap_name=E2=80= =99 may be used uninitialized in this function [-Wmaybe-uninitialized] g_strlcpy(s->bitmap_name, bitmap_name, sizeof(s->bitmap_name)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Vladimir Sementsov-Ogievskiy --- v2->v3: Placing the declaration at the beginning of the block(Base on Max's= suggestion). Cc: Max Reitz Cc: Vladimir Sementsov-Ogievskiy Cc: Laurent Vivier Cc: Li Qiang --- migration/block-dirty-bitmap.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c index 5bef793ac0..114987961a 100644 --- a/migration/block-dirty-bitmap.c +++ b/migration/block-dirty-bitmap.c @@ -1071,18 +1071,15 @@ static int dirty_bitmap_load_header(QEMUFile *f, DB= MLoadState *s, return -EINVAL; } =20 - if (!s->cancelled) { - if (bitmap_alias_map) { - bitmap_name =3D g_hash_table_lookup(bitmap_alias_map, - s->bitmap_alias); - if (!bitmap_name) { - error_report("Error: Unknown bitmap alias '%s' on node= " - "'%s' (alias '%s')", s->bitmap_alias, - s->bs->node_name, s->node_alias); - cancel_incoming_locked(s); - } - } else { - bitmap_name =3D s->bitmap_alias; + bitmap_name =3D s->bitmap_alias; + if (!s->cancelled && bitmap_alias_map) { + bitmap_name =3D g_hash_table_lookup(bitmap_alias_map, + s->bitmap_alias); + if (!bitmap_name) { + error_report("Error: Unknown bitmap alias '%s' on node " + "'%s' (alias '%s')", s->bitmap_alias, + s->bs->node_name, s->node_alias); + cancel_incoming_locked(s); } } =20 --=20 2.23.0