From nobody Mon Feb 9 07:23:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1602660790; cv=none; d=zohomail.com; s=zohoarc; b=JIPvaVNWjrle6KgOLgzJxRtL0L5tdO+CrS1lGCGKZ6RuRJzo13fSou54QT+8hcLHk2UPxIhZsi5V/oUD8FXo+IcN4DmJzTNx79i7YAYQxV7kOL2L5atLCuQB5K46HeFRCphgGt1mNCnF9pYQPFocTKHrabrErQ3AFtQg43b7PeQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602660790; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=4BiCQmLk/Bl1J0lxxEWtz1c03pMN/Q4Vs0NyLgts81g=; b=k/cC4aKomNgMoONA/NzvqA94Gka/X+qPQpnFiLHWNBZ2F0tMonLpAZtsPh9nVW55fuAfhUMv8ufb8qV/rXBF5TebVjgOWRkBy9f9d4tqCaIPCIeXSIowDKqiryDnpCk7FSi1ZRfoffIhA31fzJenbg2jyWMGa2CbMvjOlXn+ko8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602660790532754.1813929932817; Wed, 14 Oct 2020 00:33:10 -0700 (PDT) Received: from localhost ([::1]:59946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSbHZ-00047a-Bk for importer@patchew.org; Wed, 14 Oct 2020 03:33:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSbD5-0007jM-Fh for qemu-devel@nongnu.org; Wed, 14 Oct 2020 03:28:31 -0400 Received: from mga05.intel.com ([192.55.52.43]:54365) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSbD3-00041U-Oe for qemu-devel@nongnu.org; Wed, 14 Oct 2020 03:28:31 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 00:28:28 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 00:28:27 -0700 IronPort-SDR: KINNilbLm2cmYAQ3nj9zMCCr3jq3a/VzMjddxAQVuLmb7v8kO/nQzV4QzYuaAx5z4HeDIW0kmR jlgnbmJx1b+A== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="250751928" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="250751928" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: y0rsCka7ZOivCmYZ0nQ8VYhSpxqZHAoRKgjMVeAFPO2aC7frjBXh86RaAInhtZ+NkOLBf5hD97 Rhp/LeijCigg== X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="521323042" From: Zhang Chen To: Jason Wang , qemu-dev Subject: [PATCH 04/10] Fix the qemu crash when guest shutdown in COLO mode Date: Wed, 14 Oct 2020 15:25:50 +0800 Message-Id: <20201014072555.12515-5-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201014072555.12515-1-chen.zhang@intel.com> References: <20201014072555.12515-1-chen.zhang@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.43; envelope-from=chen.zhang@intel.com; helo=mga05.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 03:28:22 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, FROM_ADDR_WS=2.999, FROM_WSP_TRAIL=2.199, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , "Rao, Lei" , Zhang Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Rao, Lei" In COLO mode, if the startup parameters of QEMU include "no-shutdown", QEMU will crash when the guest shutdown. The root cause is when the guest shutdown, the state of VM will switch COLO to SHUTDOWN. When do checkpoint again, the state will be changed to COLO. But the state switch is undefined in runstate_transitions_def, we should add it. This patch fixes the following: qemu-system-x86_64: invalid runstate transition: 'shutdown' -> 'colo' Aborted Signed-off-by: leirao Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen --- softmmu/vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/softmmu/vl.c b/softmmu/vl.c index 5a11a62f78..bafe7c5b70 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -632,6 +632,7 @@ static const RunStateTransition runstate_transitions_de= f[] =3D { { RUN_STATE_SHUTDOWN, RUN_STATE_PAUSED }, { RUN_STATE_SHUTDOWN, RUN_STATE_FINISH_MIGRATE }, { RUN_STATE_SHUTDOWN, RUN_STATE_PRELAUNCH }, + { RUN_STATE_SHUTDOWN, RUN_STATE_COLO }, =20 { RUN_STATE_DEBUG, RUN_STATE_SUSPENDED }, { RUN_STATE_RUNNING, RUN_STATE_SUSPENDED }, --=20 2.17.1