From nobody Sun May 12 01:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1602609829; cv=none; d=zohomail.com; s=zohoarc; b=F97arz2Lr348uNiDEbjGAlqKPlY7G82plkf6f6+1Rr0VMy1ZlDha6uK0JiUG9fP1ZFc1XjNmFvRdjNwOeyZfVaiHVo7DD556FoXkFFdhbs9mYzRzbGx8um6R6fv6XlT0i5RIYzb/dkBIplJOygnVdHo9UP3UXh2Ua6Qpwwcp8dM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602609829; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=KkV3+5pJQQlIW7Ub+AenSj4BqesdeKgWMgyzNoYrvfc=; b=URvvngLq/HdA4Qe6pTsln+dVTrORi3eeeWDQWpKeGVdmXrhKoZXUmMtgqQNLc/t1w2FlNPYDQog2okL0l6cZ4cydW94QkWPU/YCLa7WziSPTdxTNrnuVC+HFvVx0K8TLtvk/K/rriQjThKJJ4BEXfhmalTFFkJum5HGn3t+ttP4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602609828872953.8872315194973; Tue, 13 Oct 2020 10:23:48 -0700 (PDT) Received: from localhost ([::1]:48262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSO1a-0007o8-Uc for importer@patchew.org; Tue, 13 Oct 2020 13:23:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSO0V-0007G1-Jr; Tue, 13 Oct 2020 13:22:39 -0400 Received: from serv1.kernkonzept.com ([2a01:4f8:1c1c:b490::2]:42221 helo=mx.kernkonzept.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSO0T-0001LA-T9; Tue, 13 Oct 2020 13:22:39 -0400 Received: from [86.56.119.37] (helo=george-laptop.lan) by mx.kernkonzept.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) id 1kSO0Q-0000MC-Ek; Tue, 13 Oct 2020 19:22:34 +0200 From: Georg Kotheimer To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [PATCH] target/riscv: Fix implementation of HLVX.WU instruction Date: Tue, 13 Oct 2020 19:22:23 +0200 Message-Id: <20201013172223.443645-1-georg.kotheimer@kernkonzept.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: softfail client-ip=2a01:4f8:1c1c:b490::2; envelope-from=georg.kotheimer@kernkonzept.com; helo=mx.kernkonzept.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.4, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Georg Kotheimer Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The HLVX.WU instruction is supposed to read a machine word, but prior to this change it read a byte instead. Signed-off-by: Georg Kotheimer Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/riscv/op_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c index 9b9ada45a9..3b7bd6ee88 100644 --- a/target/riscv/op_helper.c +++ b/target/riscv/op_helper.c @@ -334,12 +334,12 @@ target_ulong helper_hyp_x_load(CPURISCVState *env, ta= rget_ulong address, riscv_cpu_set_two_stage_lookup(env, true); =20 switch (memop) { - case MO_TEUL: - pte =3D cpu_ldub_data_ra(env, address, GETPC()); - break; case MO_TEUW: pte =3D cpu_lduw_data_ra(env, address, GETPC()); break; + case MO_TEUL: + pte =3D cpu_ldl_data_ra(env, address, GETPC()); + break; default: g_assert_not_reached(); } --=20 2.25.1