From nobody Tue Feb 10 04:08:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) client-ip=209.85.221.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602595544; cv=none; d=zohomail.com; s=zohoarc; b=iz+hPQ5FJNA3dOHQ2ToBVnZ9I9hHJsrrdYnNk94jd7RcC9mpJLdcSrlBVQtJ6WyUfUBWqFEIHR0MW3IeK/D85u8bOCFyx/Z6usgonfFUWGNfame2vWLUWCTyYpih0CdQjzi/cq6Z1Uu/XphxQpnuf5DHef6B3nr6cmFmTmxLty8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602595544; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=orbtnIXME7eI8Z8OOzrxbeZteV0enZumXvxzAJ1ns40=; b=nmkp/QB2OS1mFOagqQVsJk0is8m4ikLYerh2dgxRNVeSJCIRLYfg/icbq1ybglmGFmj397fZNHqYsOqllkZ85IZGDD9qQyAYtd+wVFu9ANwhokLfyYLG29AxJi1FhiTHDaf7u0Qcfx3Wiz4gLzm0wOQiLbI2FM3ZiJi45C/MPzo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.zohomail.com with SMTPS id 1602595544623223.72300383830532; Tue, 13 Oct 2020 06:25:44 -0700 (PDT) Received: by mail-wr1-f68.google.com with SMTP id n18so24053278wrs.5 for ; Tue, 13 Oct 2020 06:25:43 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id g139sm28521298wme.2.2020.10.13.06.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 06:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=orbtnIXME7eI8Z8OOzrxbeZteV0enZumXvxzAJ1ns40=; b=DwvgVy0Dcq4RzoKe5jWzYGaHt1u8AlfHniI7udTUBR4eMvNAWZMd/7f9Hwp7jM/Rx3 EmacVZ20Jcgz0oGt2Gll7A0kiR0bgX8IhpTYilHPwp8I8dHBaxkfkzXbFc53tpPG/mBT jBh0W/m5woPSSUIgmNIxGlwReQofS2MXTQjJoW1TQhLLgZwnIg49iHrUYlk42EPmtnZ4 /WHQOTiWFc1AqwC6AddPuL6gV4bymWvr0OwBpsh7irezEO2xTbyiKP/V29GreahSx1sB +WhzYBM9S4uLbPNkRfFMeCuaGi0RPCJhbWpN67Kji+o/BMwUpqdLbUG/s9z7IpMVeRSp jWhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=orbtnIXME7eI8Z8OOzrxbeZteV0enZumXvxzAJ1ns40=; b=N92csEOOkRd9/bWXj+ALG//njrBlKmng7DuK9L405QRjepHTSW0qPetGieOcG7OjaM dFJDl8jJkmVjbd3tjQBRASApgf0a6+y74jF9pPH1cQjiYbVCZZVcNuMv8AgGYjP1bxpJ GMB5kyp+2p8dvSrAh5e8yq771lMz66BDPcGoAe4I715IFQjAc3bG/ttrea63Pys9KAii 8Do933+a1z0JVR78G0gJrDKIL2ZUvEk67o/jRIU1KJf5pZVgbQs8LkPUnDvsxZE8x6NB O+K/yJ7rtJi7Hd5kdzjBFzl+wknBTalceOGmNT316N4NFntWmxJH0nBfOJavhqkiyMJn S5Ug== X-Gm-Message-State: AOAM5317BO2Cb25bNCpHqwz32kk9sxeQmOSR04LGbhSRDgOHASLzdy+h dl4+ygcoMFC8eswOOOxpT6w= X-Google-Smtp-Source: ABdhPJxuPuytI/LrtTAqkTfYc8qzhnN8MkXMX9zxPUFdbLbLS9QNjGRB3giEPLNDBRBh3owhT5kGSg== X-Received: by 2002:adf:f1c1:: with SMTP id z1mr11761614wro.331.1602595542614; Tue, 13 Oct 2020 06:25:42 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Victor Kamensky Cc: Khem Raj , Richard Henderson , Aleksandar Rikalo , Aleksandar Markovic , Jiaxun Yang , Aurelien Jarno , Richard Purdie , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 1/3] target/mips: Make cpu_mips_realize_env() propagate Error Date: Tue, 13 Oct 2020 15:25:33 +0200 Message-Id: <20201013132535.3599453-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201013132535.3599453-1-f4bug@amsat.org> References: <20201013132535.3599453-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) To be able to propagate error to our caller, make cpu_mips_realize_env() take an Error argument and return a boolean value indicating an error is set or not, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/internal.h | 10 +++++++++- target/mips/cpu.c | 4 +++- target/mips/translate.c | 4 +++- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/target/mips/internal.h b/target/mips/internal.h index 7f159a9230c..c2b2e79c515 100644 --- a/target/mips/internal.h +++ b/target/mips/internal.h @@ -206,7 +206,15 @@ void mips_tcg_init(void); =20 /* TODO QOM'ify CPU reset and remove */ void cpu_state_reset(CPUMIPSState *s); -void cpu_mips_realize_env(CPUMIPSState *env); + +/** + * cpu_mips_realize_env: Realize CPUMIPSState + * @env: CPUMIPSState object + * @errp: pointer to error object + * On success, return %true. + * On failure, store an error through @errp and return %false. + */ +bool cpu_mips_realize_env(CPUMIPSState *env, Error **errp); =20 /* cp0_timer.c */ uint32_t cpu_mips_get_random(CPUMIPSState *env); diff --git a/target/mips/cpu.c b/target/mips/cpu.c index e86cd065483..117c748345e 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -147,7 +147,9 @@ static void mips_cpu_realizefn(DeviceState *dev, Error = **errp) return; } =20 - cpu_mips_realize_env(&cpu->env); + if (!cpu_mips_realize_env(&cpu->env, errp)) { + return; + } =20 cpu_reset(cs); qemu_init_vcpu(cs); diff --git a/target/mips/translate.c b/target/mips/translate.c index 398edf72898..4c9b6216321 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -31316,7 +31316,7 @@ void mips_tcg_init(void) =20 #include "translate_init.c.inc" =20 -void cpu_mips_realize_env(CPUMIPSState *env) +bool cpu_mips_realize_env(CPUMIPSState *env, Error **errp) { env->exception_base =3D (int32_t)0xBFC00000; =20 @@ -31325,6 +31325,8 @@ void cpu_mips_realize_env(CPUMIPSState *env) #endif fpu_init(env, env->cpu_model); mvp_init(env, env->cpu_model); + + return true; } =20 bool cpu_supports_cps_smp(const char *cpu_type) --=20 2.26.2