From nobody Sun Feb 8 23:05:08 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602587406; cv=none; d=zohomail.com; s=zohoarc; b=dvt4+nhFKDcn6qEOGP0MEYiYafotJLZEg2KXhZ4KOCHp3tD3VugC79KDqtHLuYP0+zy79A1nr1vb9BS3us7O7RNeB+E6Cn/fVpzH1yNspFlwAu3cCDaU/MuWELi5uUXNpYcnHKqFzI4iIuaFJjIhyVMJqrV+TCbhFzfJ9fTwvtc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602587406; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZwdpEydgASwk7Xa1qzk0VcFGKtWjCj8HlX5xwek5440=; b=kYGvBTlsE5ruejb60Zko47NI9PxrcYVRuvhvINtzY6eeBEPzDUrAnudNt9AjFxzkUKjzixNfs1qALLnQZiplAFb8nQ2uys3p5Rirsjf5VG2/ELtTIlkcmXni16Cgt2ENNp/8jjaiMaURJ8FfjAwRYAaD9akLL5NLh+kbMEfqsH4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602587406537535.2306367277947; Tue, 13 Oct 2020 04:10:06 -0700 (PDT) Received: from localhost ([::1]:49030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSIBx-00052y-Ho for importer@patchew.org; Tue, 13 Oct 2020 07:10:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSHyZ-0005YR-DA for qemu-devel@nongnu.org; Tue, 13 Oct 2020 06:56:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48742) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSHyV-0006G0-GY for qemu-devel@nongnu.org; Tue, 13 Oct 2020 06:56:14 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-75-P6OzXzVtNzCBLEKXkUZRIw-1; Tue, 13 Oct 2020 06:56:07 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 560BC18829D3; Tue, 13 Oct 2020 10:56:06 +0000 (UTC) Received: from thuth.com (ovpn-112-151.ams2.redhat.com [10.36.112.151]) by smtp.corp.redhat.com (Postfix) with ESMTP id 640596EF41; Tue, 13 Oct 2020 10:56:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602586570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZwdpEydgASwk7Xa1qzk0VcFGKtWjCj8HlX5xwek5440=; b=AURDWfi1/MMvK6DdmnmIQdsePXY7lNtMEb3AypmTfWErrFkttFVQWgqjTV28LYAG240+kB gHOPNTfdfV3LShD2haUNsznTm0anTrVV+9Is31DI3/7ClFXjvHG3KR94feviabaV7U34zc ov+lDZgmn8oYlHgxbSz3BfT+7Az6D2I= X-MC-Unique: P6OzXzVtNzCBLEKXkUZRIw-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 14/23] gitlab: add a CI job for running checkpatch.pl Date: Tue, 13 Oct 2020 12:55:18 +0200 Message-Id: <20201013105527.20088-15-thuth@redhat.com> In-Reply-To: <20201013105527.20088-1-thuth@redhat.com> References: <20201013105527.20088-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/13 02:06:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Daniel P. Berrang=C3=A9 This job is advisory since it is expected that certain patches will fail the style checks and checkpatch.pl provides no way to mark exceptions to the rules. Signed-off-by: Daniel P. Berrang=C3=A9 Message-Id: <20200918132903.1848939-2-berrange@redhat.com> [thuth: Use "stage: build" to let it run earlier] Signed-off-by: Thomas Huth --- .gitlab-ci.d/check-patch.py | 48 +++++++++++++++++++++++++++++++++++++ .gitlab-ci.yml | 12 ++++++++++ 2 files changed, 60 insertions(+) create mode 100755 .gitlab-ci.d/check-patch.py diff --git a/.gitlab-ci.d/check-patch.py b/.gitlab-ci.d/check-patch.py new file mode 100755 index 0000000000..5a14a25b13 --- /dev/null +++ b/.gitlab-ci.d/check-patch.py @@ -0,0 +1,48 @@ +#!/usr/bin/env python3 +# +# check-patch.py: run checkpatch.pl across all commits in a branch +# +# Copyright (C) 2020 Red Hat, Inc. +# +# SPDX-License-Identifier: GPL-2.0-or-later + +import os +import os.path +import sys +import subprocess + +namespace =3D "qemu-project" +if len(sys.argv) >=3D 2: + namespace =3D sys.argv[1] + +cwd =3D os.getcwd() +reponame =3D os.path.basename(cwd) +repourl =3D "https://gitlab.com/%s/%s.git" % (namespace, reponame) + +# GitLab CI environment does not give us any direct info about the +# base for the user's branch. We thus need to figure out a common +# ancestor between the user's branch and current git master. +subprocess.check_call(["git", "remote", "add", "check-patch", repourl]) +subprocess.check_call(["git", "fetch", "check-patch", "master"], + stdout=3Dsubprocess.DEVNULL, + stderr=3Dsubprocess.DEVNULL) + +ancestor =3D subprocess.check_output(["git", "merge-base", + "check-patch/master", "HEAD"], + universal_newlines=3DTrue) + +ancestor =3D ancestor.strip() + +subprocess.check_call(["git", "remote", "rm", "check-patch"]) + +errors =3D False + +print("\nChecking all commits since %s...\n" % ancestor) + +ret =3D subprocess.run(["scripts/checkpatch.pl", ancestor + "..."]) + +if ret.returncode !=3D 0: + print(" =E2=9D=8C FAIL one or more commits failed scripts/checkpatc= h.pl") + sys.exit(1) + +sys.exit(0) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 29e934fd53..f1e18d3e90 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -399,3 +399,15 @@ check-crypto-only-gnutls: variables: IMAGE: centos7 MAKE_CHECK_ARGS: check + + +check-patch: + stage: build + image: $CI_REGISTRY_IMAGE/qemu/centos8:latest + script: .gitlab-ci.d/check-patch.py + except: + variables: + - $CI_PROJECT_NAMESPACE =3D=3D 'qemu-project' && $CI_COMMIT_BRANCH = =3D=3D 'master' + variables: + GIT_DEPTH: 1000 + allow_failure: true --=20 2.18.2