From nobody Mon Nov 17 03:41:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) client-ip=209.85.128.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602522620; cv=none; d=zohomail.com; s=zohoarc; b=dyBTpkUPYT97SejeBeECKQvuKXQMw+Ay9RhY7nqsOl6NrJX/6xY1MmA9bNhbNs1a0oByD/EdAh6e9EvUFigdwvDyWYDRBZAiz/539Vjr/XVw1XKxBIYguVrFxIClQs3v2I+hUbh+Sd4lmoNCXAXt9p9u/1wwGW2+5zrEIzh3jvY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522620; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T1VyM6vO+/UgLy3YgWrY448pDVaigr36dSzmUkhUC2A=; b=fYft904WM9+UkzUFYOsxJ5dp+oZVxR4oO5jWiIUOL/FjaEutJsJtEXravvgsh1A/xlZ+zboZ7Zh0cplS7Reo0CiVJlabnQ7EZNYrmEVvrxteH+s2/ipbRnDlY1aVbgl50wXC8IljuYVtSnlGHRK9p7gobD/H5rfftBjEq+btBSs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.zohomail.com with SMTPS id 1602522620806420.33389395294626; Mon, 12 Oct 2020 10:10:20 -0700 (PDT) Received: by mail-wm1-f68.google.com with SMTP id 13so17778954wmf.0 for ; Mon, 12 Oct 2020 10:10:20 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id u15sm23106397wml.21.2020.10.12.10.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T1VyM6vO+/UgLy3YgWrY448pDVaigr36dSzmUkhUC2A=; b=ah7JfWJuVEfIlML4YkqazrwbS7sEXPVCIhdOxoNBXgZsX1PlXbFVgZntXipr8W2lpb 9OQymwbhvVjmyjpF4Ez0RdjTxIhfhK8uR9KqVNMWooaRANbRQMYlpGgllxDBadNRlL0s EP1iD+tjx+c1kD3HQCB8XUf85OwlYxldW4IfW7HFUZEQDq2LNJgjLHAwBGUQWfw0Llaq DPF7QkRHDx6Saqycyvg7E3iJlrwVvf6iMw+Hws1IRLxU3Q9loZ+jbWXh9vsfWiy0PYqc F93b9zOuO0vzW9Pu68qsVRVXWmKpQe36sjVrNr7Jg6nvq0vpgmvl7ZYkBEonj9X6OMyM hvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=T1VyM6vO+/UgLy3YgWrY448pDVaigr36dSzmUkhUC2A=; b=bgGSAf7cst3taGv212yPGcnzlI20kYUoImZdfEVmr7ZL9OZYA4Z1CJggi0N+M81qIn gsjtZq3I8J9jgNGqzIUEcYy1wu670mttw4EM/PB/YAQl++srd0ormCKKrfC11nOkFgA5 Mt3aKNjxxdvWDPZvrJ5fs5UuDq+SejvKqa3IpMo0z6HYVfUoPSm05Hx1nj2+N7qIZsHT JI9DX4zAPksaj90sQpo3JjJh/E+w7mlgo2MJwmi3VnjpMXdtYMyvMYG89SVfhiOXb0HQ yQEeVFC24yg9y4M/XwwcgddEYpEDQkP2z/1mC5ntENyymCJxQXYnqVja+pipKSO8Ongq 1gMw== X-Gm-Message-State: AOAM532j7OXvHwluCay0f/REHNELQ8J45Fw1Iuja/sGDDbrKsyeIIkq5 bGUIT4TI37Mvys21t2/quT1dtId+3dU= X-Google-Smtp-Source: ABdhPJyxdsO9bDHuwTDwO7Z1fZXKTy3M2wfpNQrZ30oneOOWCHxnG40nAkdEInVoXWjVmeAJZFtjfA== X-Received: by 2002:a1c:9ecb:: with SMTP id h194mr11383273wme.140.1602522618940; Mon, 12 Oct 2020 10:10:18 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 6/6] hw/pci-host/sabre: Log reserved address accesses as GUEST_ERROR Date: Mon, 12 Oct 2020 19:09:50 +0200 Message-Id: <20201012170950.3491912-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Report accesses to reserved registers using qemu_log_mask(GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 67699ac9058..cc97c266a57 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -189,7 +189,11 @@ static void sabre_config_write(void *opaque, hwaddr ad= dr, case 0xa800 ... 0xa80f: /* Interrupt diagnostics */ case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ + break; default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Register 0x%04" HWADDR_PRIX " is reserved\n", + __func__, addr); break; } } @@ -235,7 +239,11 @@ static uint64_t sabre_config_read(void *opaque, case 0xa800 ... 0xa80f: /* Interrupt diagnostics */ case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ + break; default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Register 0x%04" HWADDR_PRIX " is reserved\n", + __func__, addr); break; } trace_sabre_config_read(addr, val); --=20 2.26.2