From nobody Mon Nov 17 03:43:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) client-ip=209.85.221.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1602522611; cv=none; d=zohomail.com; s=zohoarc; b=mzoZhCw4DU0UiLlokENMzbvhtDwLak+ar/TZYllyzGyBnUxJ2cDeh0U15wE5uJBsL1J1G8i0T3ytzQgdDneNGXaWKJgZJEMq1sxspvCN3JkzKN3Wjd+L3z8+WQ+/dfhQqppBQfs5Ql8lOFi919QyMv19896aXNO29DLRTHD/7Zo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522611; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=g+ZuN081JnWofgtvw5Xcnn25A8ChgQoZUlp7TAnTGlc=; b=nAYaSa3VY9SZ39MQulWyYahg0yYSCOpt4qaOqyR2PTLzB+PzvjDnUF9/X+JWyWuIcv8ubkV+A9HDwmGRImgXe1Yy+/iyYsOee0BtRN6vo4q6AK/xSBZELn36J/ZRikk6Fu7o3wDOcNycXe+JgjjMH6IRO0dlPI1MJ5tYWO07h7M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.zohomail.com with SMTPS id 1602522611760887.5498738589416; Mon, 12 Oct 2020 10:10:11 -0700 (PDT) Received: by mail-wr1-f66.google.com with SMTP id t9so20013516wrq.11 for ; Mon, 12 Oct 2020 10:10:11 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id b5sm3359947wrs.97.2020.10.12.10.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g+ZuN081JnWofgtvw5Xcnn25A8ChgQoZUlp7TAnTGlc=; b=Tzncg49ROC/sfxYjVrVxZ7A+r7tL+fD5nrGLNX8NgPAiDn/wJddqdLgNRfAIaCYioz Aup7mvBGbCcsBnf17lHSZ5qVuQWLxYFsN0sKxtXVBmTenDU/Obh/oHdSN/5X1abvjaB8 2CIQcPJtRe+nbMGb4Rg1zVNCIQgYS/a7vKsztHA9/DSMu9TkzdphaDAUnIWSyvrqXwQN XQzjXpmVByL6g/Z7yGArIOJfbTFofz/feVfBWRRN0f7NqEpP50nGsJaV2+9ClvG3X5WL VrwuQU4LJlUssE6hEYDQSLYzl1W9pPtxfX8aGeSS7jYdbF7uSM9fY14GNwfQ7V32sLLG DMkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=g+ZuN081JnWofgtvw5Xcnn25A8ChgQoZUlp7TAnTGlc=; b=n4UcH+fCup0A68VOS/rUSs7XZwDY/oGxj4/FISI3p4W/sOZqnky3yI7HkZ3qonPPv2 +UFvZnuqj4u4SjY/dEya6RL3v5v69ARnf92JdWu4leCr+fuQNdiCLBFSEkgG3voyailY zz7qVhYgyJ8BxrFe1Q4KVArLOTxFohdexDxK0ySQjEF9ZeV/e4IkN0n6ZKRbyeF/MGr8 CjWy0NRqyPH2Zs+kAoGLRbQs8PhclKO7vyAsekCLD7PNiDOAdKP8OTP1xZ8GhglAa1r+ GUAp4vDjVbts/coYOjEZX0JZOn6IvQjmbvqUBHyon8Z7DZjOKpNUkPbA+TVMy/xncAUA dNwQ== X-Gm-Message-State: AOAM530DuPoJAtclSCAzNm6FDawVF11Oc3zEL4CedQinCYUsz5ZAoMAv rw5wsA5ybQ44tEjX7yrrIbo= X-Google-Smtp-Source: ABdhPJxGEj9mYPb+dAW62VOwNvCZDqTYCzRwcgq81RPp+ctwU3YWEo3DuJoWbgOZNW5jblugNRumoQ== X-Received: by 2002:adf:e681:: with SMTP id r1mr1622526wrm.181.1602522609942; Mon, 12 Oct 2020 10:10:09 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP log_mask Date: Mon, 12 Oct 2020 19:09:48 +0200 Message-Id: <20201012170950.3491912-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Report unimplemented register accesses using qemu_log_mask(UNIMP). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/pci-host/sabre.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 3645bc962cb..4412e23131c 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -121,8 +121,10 @@ static void sabre_config_write(void *opaque, hwaddr ad= dr, trace_sabre_config_write(addr, val); =20 switch (addr) { - case 0x30 ... 0x4f: /* DMA error registers */ - /* XXX: not implemented yet */ + case 0x30 ... 0x4f: /* DMA error registers */ + qemu_log_mask(LOG_UNIMP, + "%s: Register 0x%02" HWADDR_PRIX " not implemented\n= ", + __func__, addr); break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { @@ -198,8 +200,10 @@ static uint64_t sabre_config_read(void *opaque, uint32_t val =3D 0; =20 switch (addr) { - case 0x30 ... 0x4f: /* DMA error registers */ - /* XXX: not implemented yet */ + case 0x30 ... 0x4f: /* DMA error registers */ + qemu_log_mask(LOG_UNIMP, + "%s: Register 0x%02" HWADDR_PRIX " not implemented\n= ", + __func__, addr); break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { --=20 2.26.2