From nobody Mon Nov 17 03:41:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602522607; cv=none; d=zohomail.com; s=zohoarc; b=FovyZdDlkMJnUDKmu8F1VSC5kPJ8DDKzUrfoeDB49MkaRxkMyVNV1dhWxg6czoESGhTPOSqYtKWzjGcmC2hhXZ2qtCjvJWqDtk/j6vaz1tiehOWFzfwtdk0QSKrqKYWMEVRotk7nU46vhMBq1OV34Y/PSKajl6HHGxhdC8f4e+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522607; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=u3qL4sMDH/Dtxtrv1yhVgK7r2RReEwtHtQeIMbIgt3M=; b=oF2/B41nKNlni0Ag2p3ow/DeX/47H9a0+Ub86H5M6YObNnLFNL11veCene6zx2v4Sh+7+pKKk4/AOckhjcR+MjYZibg8nuWVaqKgAbTcn/SvcWZnzwrQTNoDahRD3bsFrVjFeGVRCtz7PQ63SsJodJ4oS5a6S1Y7sJvnbxGr7Eo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 1602522607468130.94594267357536; Mon, 12 Oct 2020 10:10:07 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id h5so9947166wrv.7 for ; Mon, 12 Oct 2020 10:10:06 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id y6sm25666395wrt.80.2020.10.12.10.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u3qL4sMDH/Dtxtrv1yhVgK7r2RReEwtHtQeIMbIgt3M=; b=qculCezzeD43ig0+I83rawGeWv6OJTl8Z3uEMRe8vAk2ALOqMMnXDnULec4QESxgBl tPqDER1gzLmj/NVg23d5c8Ummt2E8HU3PzCAZYGZ7CY5crt/ruKPOHBjAG5pkD90Xns7 zxKqjdsJUaDk6/lt+rnHLLiB5P58sigWEDbg31oS4J12t7Rr35ehYsy6GPSJcLn7RPLX 1i3GS4iOHFzhi4irFKb/JO1MzqTaafPrkCMKAlB9aziHLN3VH9z8eM9JEschc34MWRlc MQsHzkVc3V8Jn1zNeLVlv8ffE3xucCrBREia3UlmPlvMk/14hC3pfg4VE/itcRPm3DcV OaHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=u3qL4sMDH/Dtxtrv1yhVgK7r2RReEwtHtQeIMbIgt3M=; b=Befs9aDXekErv7seZiR1kEOw5iYpVOVZcWBcPh9gxO+/1crBSt8cyy1PdCZR1YT9uu 5mr2VbVbGJnqiLJCgQzwrfU1V8mztbk9Y12MNr2qBnYWmnBVZug02sacFAQ7OyPejrY9 fRMxw3Hn/iwNHwBlms0Gjjt/fjL2QuqjBXNv7FcTMJCbnX/qc0bglr56DA+HhADotHOA 4Z/7Xc39TKJ9UwdNkTkNvgS/+JV3OhYrE+p8xy/8vMFEw9AIlXeBcWXelLKH2NYgoX0L /Asi8/NllQ4dJpwy9P5OARTVaUc49j8JijPz7cyLfmxLi6IJyPwHvAAvEQ+ukWYtHaIT Oi9Q== X-Gm-Message-State: AOAM531MPoQ7SaxqhnGPx2gYMzW4eOJB9pOfBXXt+clM53+s3kGZsmDq bN4Aqk0cl+OPjd/iv2p/q7A= X-Google-Smtp-Source: ABdhPJx9YarihkbWCLjLA+zauH3C5Ur5TUjz8h6l42q4X7K0ulHNlIBXm9b1PdViTxEjViRGQUF2QQ== X-Received: by 2002:a5d:6143:: with SMTP id y3mr13532957wrt.277.1602522605660; Mon, 12 Oct 2020 10:10:05 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/6] hw/pci-host/sabre: Simplify code initializing variable once Date: Mon, 12 Oct 2020 19:09:47 +0200 Message-Id: <20201012170950.3491912-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We only need to zero-initialize 'val' once. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 0889c9369f6..3645bc962cb 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -195,32 +195,25 @@ static uint64_t sabre_config_read(void *opaque, hwaddr addr, unsigned size) { SabreState *s =3D opaque; - uint32_t val; + uint32_t val =3D 0; =20 switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ - val =3D 0; /* XXX: not implemented yet */ break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { val =3D s->pci_irq_map[(addr & 0x3f) >> 3]; - } else { - val =3D 0; } break; case 0x1000 ... 0x107f: /* OBIO interrupt control */ if (addr & 4) { val =3D s->obio_irq_map[(addr & 0xff) >> 3]; - } else { - val =3D 0; } break; case 0x1080 ... 0x108f: /* PCI bus error */ if (addr & 4) { val =3D s->pci_err_irq_map[(addr & 0xf) >> 3]; - } else { - val =3D 0; } break; case 0x2000 ... 0x202f: /* PCI control */ @@ -229,8 +222,6 @@ static uint64_t sabre_config_read(void *opaque, case 0xf020 ... 0xf027: /* Reset control */ if (addr & 4) { val =3D s->reset_control; - } else { - val =3D 0; } break; case 0x5000 ... 0x51cf: /* PIO/DMA diagnostics */ @@ -239,7 +230,6 @@ static uint64_t sabre_config_read(void *opaque, case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ default: - val =3D 0; break; } trace_sabre_config_read(addr, val); --=20 2.26.2