From nobody Mon Nov 17 03:43:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) client-ip=209.85.221.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602522603; cv=none; d=zohomail.com; s=zohoarc; b=FQn8ltFsHLnyIVjAdFVCE2MBuvPTHYqrbLbwkSe4MNVZhLrfyNErXIzKDljAx8cuGvVhbBGTPIs/lL1BKdx9RHYUSfrDngdmeAxEcR/bjeJAJ9ITW5w2Rv8dfBmWmNAIYMuxgZfofC1RCbNVZ7rfOqC2yA9+I/5woqYVwC7kHYo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522603; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vwsOKhAW+74BD2GAbdrqNd+j5DzxxpKUr1mlTm/twmU=; b=D6Qu6fz7EBZaRYAb3QbXtjiK3ve6Vy3stJ9KU6S5++oUhvs4QtQQ/tIb3APctfUoWii0Nn0D5TB/Yy+0xJXDG9mxCUyK4yJ4C6jblc5OUdSde3Hk1neXvHNgYRICuKERCDSgPM9kW3W4butN8SPwpKlHAl2fQlNISwO3EpoBHzc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.zohomail.com with SMTPS id 1602522603098179.6005678013612; Mon, 12 Oct 2020 10:10:03 -0700 (PDT) Received: by mail-wr1-f66.google.com with SMTP id g12so20012840wrp.10 for ; Mon, 12 Oct 2020 10:10:02 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id p13sm24200745wmb.5.2020.10.12.10.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vwsOKhAW+74BD2GAbdrqNd+j5DzxxpKUr1mlTm/twmU=; b=lziW4pza2F6T+QKnv7EF2LTo5wcWsiGfZKFxkkOcfrTNGVeDH3Ug/jwW/gNrDRgfZK d3+dOrkVH6ArESqdgE+p1J+TdR85UMubWwUO6fdtaHky+RlTHfsS7IduqKE1KlQ8o19P BvAtoalgINGOnbnqwW4PIFMcnCIVqoVjntYex+cuLZRj2fakatGATBX2Z4+054Y6Yxxq ee+3Cy+VOwgce/9Q19ed+FumSCheLEcHj92RUwsuzDtM0Bd0xvVvkTiXGlTfKUZt7weo xJ4IlVrHC011EgKBCRz3FSgWroaFfdBTnbm1UGezkLZ/7ZhEmThTCxHi/NMFOObGwRS7 +fXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vwsOKhAW+74BD2GAbdrqNd+j5DzxxpKUr1mlTm/twmU=; b=Guwulgf7rHzOR6xkA9T8JnJ24YzgjToECCiP1lP7ePtcKUrFJseFPtT17QbpUcMdhx O0wVH7hCDW6rSbd/WkmHp1dxECBM8U8blnUDYSx7HRUKrY8rvzOT+zkyGIx3J4e5eNF5 zRnyMiP6Qt7GfBNEnSjhn5OaFaUx3xGGb0T0jD65HHsEuPF+tb8Q9TMxKk4LElZny3lw bIzgn1BPNO1++4EiIPB06/Wumxt0CFGdIkW2SRGPkvnCWF6epVzGGD3Zb+k1pVHVuD6d IuHzJBh/Go4Mi5iWBdanMVoxXzox0q0fsFgmMsF++Ub+hDvGBjeLQiRX58vnc9Tq6ECw 0TaQ== X-Gm-Message-State: AOAM533wRr/d+XLx9aki364yq2HiGmqYjmo1JUGf/CbP+Wvv6KX7EfJQ Dw/7BqZ8OH3gSUkb/5om/o4= X-Google-Smtp-Source: ABdhPJys3cOIo3gINMhbNO3UuWTjUtkGT55PGq+YoebOdjTOBR+G6+jqzsFfrD7Jc5srWX0hVA7bxg== X-Received: by 2002:adf:912e:: with SMTP id j43mr30782924wrj.325.1602522601253; Mon, 12 Oct 2020 10:10:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/6] hw/pci-host/sabre: Remove superfluous address range check Date: Mon, 12 Oct 2020 19:09:46 +0200 Message-Id: <20201012170950.3491912-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The region is registered as 64KiB in sabre_init(): memory_region_init_io(&s->sabre_config, OBJECT(s), &sabre_config_ops, s, "sabre-config", 0x10000); Remove the superfluous check. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 3634f8369b7..0889c9369f6 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -120,7 +120,7 @@ static void sabre_config_write(void *opaque, hwaddr add= r, =20 trace_sabre_config_write(addr, val); =20 - switch (addr & 0xffff) { + switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ /* XXX: not implemented yet */ break; @@ -197,7 +197,7 @@ static uint64_t sabre_config_read(void *opaque, SabreState *s =3D opaque; uint32_t val; =20 - switch (addr & 0xffff) { + switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ val =3D 0; /* XXX: not implemented yet */ --=20 2.26.2