From nobody Mon Nov 17 01:27:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602522598; cv=none; d=zohomail.com; s=zohoarc; b=XlRLsk34BzlIrK056Pk0dQ14uV6Q3kKLVyKzFrf3jK0gyp+afgmHTS/bLyZf5pfgdaL09qQ/BNtYj3926Ez3vF2Lhs2nmDoRQOTbYATporpPLMsjv+De/cUkKA3Kva/sfzoWYc1vex67xJJHdp4ueV3h8Bra0VOVyf3XdeqUJXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522598; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=K/0FGZZwlPzFsD7CDw6LNpeg+vGvRuv9FXjLqVDCM3o=; b=JmpeFWVJNVRklq6IozQKcFonNADIJajRoGYS9ifSxXduBeT06UIqzcm1yj709CH2uaiL8TFt2YANfGtCCJHIYXeh5H4LAFMdBKh4w6HBedGnzdnSixMW0zDStZ6/9LIS2MhnymVxl0CK+5ftU/RfsDzTwatCpOh2SA7cULYQCO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 160252259892857.236204878785315; Mon, 12 Oct 2020 10:09:58 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id h5so9946677wrv.7 for ; Mon, 12 Oct 2020 10:09:58 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id g139sm25872629wme.2.2020.10.12.10.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K/0FGZZwlPzFsD7CDw6LNpeg+vGvRuv9FXjLqVDCM3o=; b=Azk7yZjPF6VVj+hqVlAB5HhEANYY+vQUs6Csf9I93BqimulxncYmv9zvzODaZSTEzf 9hdtmDhHtdMIXPCaBfFBhoSwMEyH6n6LSCtH0od5uZXCg9IFjUlNtyb1ESISX2ZYbLNf ciS73zcuYuIAvm/D3lS6nc06y5q1X7fgOYsV1gl0PmpPDCOJ/aX0aROz/EbaBIVLNBrH gw8iD26PzrmvUM7mqcUqABWjsd0C0J5SOKi/+DE4t8yXqaB2FzXUhH4gnm4aXjUFbPIE S9evP92w992zx2IsczO41kxsSrG8vcTT7ocFxgUNn0QPe0EF/CcOBOTI2GXqLxgAkXfi Xeqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=K/0FGZZwlPzFsD7CDw6LNpeg+vGvRuv9FXjLqVDCM3o=; b=lWDUdiqBnQU2qPM08EV/GmSrexUwKKm6Y1M0N3Paz0fxlYit91wSxTPdjQBIqaBXqg ULssqpCyeQ2nbVJt3eIxi5TlDEI1PLFnJDcjSuQK5fXbIHQpHigj9/nFYQMJUvua/2rQ 3AEMb+EashinfEqKS3JHr3KFm5LV0/yyv8C8CyaqjFLG8DT+UTwLodyfN+WFnMt4W563 pCj5o7dBBE2P/UW4a5lkzsGJwVKsU4I57G9i+4ICItCNgfZpoNbtpJhGsNe1BgFzFpy5 t0byR0RfdI63rYgZnQslZaq1DaDWt96s1NuH985rwoOMrevT+w22DgUqDQVU1FO3e+sq 3UTA== X-Gm-Message-State: AOAM531HqNhg9HeaNbM/KEVf9UeUrUkhjV+W+Bj6yVx+jNNtEof7AODK 9VL1LDi+m8a673qRTT15cBlKoyuFUj0= X-Google-Smtp-Source: ABdhPJxQierGOMFl3ECY9FPz8M/NsDmtmT0d+XkIPtxvqdy28hHcR68zgD7Y4DwyrnukoDuJ+hJ/kA== X-Received: by 2002:adf:ff8e:: with SMTP id j14mr20584353wrr.255.1602522596794; Mon, 12 Oct 2020 10:09:56 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/6] hw/pci-host/sabre: Update documentation link Date: Mon, 12 Oct 2020 19:09:45 +0200 Message-Id: <20201012170950.3491912-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The current link redirects to https://www.oracle.com/sun/ announcing "Oracle acquired Sun Microsystems in 2010, ..." but does not give hint where to find the datasheet. Use the archived PDF on the Wayback Machine, which works. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 5ac62836238..3634f8369b7 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -44,7 +44,7 @@ /* * Chipset docs: * PBM: "UltraSPARC IIi User's Manual", - * http://www.sun.com/processors/manuals/805-0087.pdf + * https://web.archive.org/web/20030403110020/http://www.sun.com/processor= s/manuals/805-0087.pdf */ =20 #define PBM_PCI_IMR_MASK 0x7fffffff --=20 2.26.2 From nobody Mon Nov 17 01:27:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) client-ip=209.85.221.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602522603; cv=none; d=zohomail.com; s=zohoarc; b=FQn8ltFsHLnyIVjAdFVCE2MBuvPTHYqrbLbwkSe4MNVZhLrfyNErXIzKDljAx8cuGvVhbBGTPIs/lL1BKdx9RHYUSfrDngdmeAxEcR/bjeJAJ9ITW5w2Rv8dfBmWmNAIYMuxgZfofC1RCbNVZ7rfOqC2yA9+I/5woqYVwC7kHYo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522603; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vwsOKhAW+74BD2GAbdrqNd+j5DzxxpKUr1mlTm/twmU=; b=D6Qu6fz7EBZaRYAb3QbXtjiK3ve6Vy3stJ9KU6S5++oUhvs4QtQQ/tIb3APctfUoWii0Nn0D5TB/Yy+0xJXDG9mxCUyK4yJ4C6jblc5OUdSde3Hk1neXvHNgYRICuKERCDSgPM9kW3W4butN8SPwpKlHAl2fQlNISwO3EpoBHzc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.zohomail.com with SMTPS id 1602522603098179.6005678013612; Mon, 12 Oct 2020 10:10:03 -0700 (PDT) Received: by mail-wr1-f66.google.com with SMTP id g12so20012840wrp.10 for ; Mon, 12 Oct 2020 10:10:02 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id p13sm24200745wmb.5.2020.10.12.10.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vwsOKhAW+74BD2GAbdrqNd+j5DzxxpKUr1mlTm/twmU=; b=lziW4pza2F6T+QKnv7EF2LTo5wcWsiGfZKFxkkOcfrTNGVeDH3Ug/jwW/gNrDRgfZK d3+dOrkVH6ArESqdgE+p1J+TdR85UMubWwUO6fdtaHky+RlTHfsS7IduqKE1KlQ8o19P BvAtoalgINGOnbnqwW4PIFMcnCIVqoVjntYex+cuLZRj2fakatGATBX2Z4+054Y6Yxxq ee+3Cy+VOwgce/9Q19ed+FumSCheLEcHj92RUwsuzDtM0Bd0xvVvkTiXGlTfKUZt7weo xJ4IlVrHC011EgKBCRz3FSgWroaFfdBTnbm1UGezkLZ/7ZhEmThTCxHi/NMFOObGwRS7 +fXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vwsOKhAW+74BD2GAbdrqNd+j5DzxxpKUr1mlTm/twmU=; b=Guwulgf7rHzOR6xkA9T8JnJ24YzgjToECCiP1lP7ePtcKUrFJseFPtT17QbpUcMdhx O0wVH7hCDW6rSbd/WkmHp1dxECBM8U8blnUDYSx7HRUKrY8rvzOT+zkyGIx3J4e5eNF5 zRnyMiP6Qt7GfBNEnSjhn5OaFaUx3xGGb0T0jD65HHsEuPF+tb8Q9TMxKk4LElZny3lw bIzgn1BPNO1++4EiIPB06/Wumxt0CFGdIkW2SRGPkvnCWF6epVzGGD3Zb+k1pVHVuD6d IuHzJBh/Go4Mi5iWBdanMVoxXzox0q0fsFgmMsF++Ub+hDvGBjeLQiRX58vnc9Tq6ECw 0TaQ== X-Gm-Message-State: AOAM533wRr/d+XLx9aki364yq2HiGmqYjmo1JUGf/CbP+Wvv6KX7EfJQ Dw/7BqZ8OH3gSUkb/5om/o4= X-Google-Smtp-Source: ABdhPJys3cOIo3gINMhbNO3UuWTjUtkGT55PGq+YoebOdjTOBR+G6+jqzsFfrD7Jc5srWX0hVA7bxg== X-Received: by 2002:adf:912e:: with SMTP id j43mr30782924wrj.325.1602522601253; Mon, 12 Oct 2020 10:10:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/6] hw/pci-host/sabre: Remove superfluous address range check Date: Mon, 12 Oct 2020 19:09:46 +0200 Message-Id: <20201012170950.3491912-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The region is registered as 64KiB in sabre_init(): memory_region_init_io(&s->sabre_config, OBJECT(s), &sabre_config_ops, s, "sabre-config", 0x10000); Remove the superfluous check. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 3634f8369b7..0889c9369f6 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -120,7 +120,7 @@ static void sabre_config_write(void *opaque, hwaddr add= r, =20 trace_sabre_config_write(addr, val); =20 - switch (addr & 0xffff) { + switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ /* XXX: not implemented yet */ break; @@ -197,7 +197,7 @@ static uint64_t sabre_config_read(void *opaque, SabreState *s =3D opaque; uint32_t val; =20 - switch (addr & 0xffff) { + switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ val =3D 0; /* XXX: not implemented yet */ --=20 2.26.2 From nobody Mon Nov 17 01:27:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602522607; cv=none; d=zohomail.com; s=zohoarc; b=FovyZdDlkMJnUDKmu8F1VSC5kPJ8DDKzUrfoeDB49MkaRxkMyVNV1dhWxg6czoESGhTPOSqYtKWzjGcmC2hhXZ2qtCjvJWqDtk/j6vaz1tiehOWFzfwtdk0QSKrqKYWMEVRotk7nU46vhMBq1OV34Y/PSKajl6HHGxhdC8f4e+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522607; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=u3qL4sMDH/Dtxtrv1yhVgK7r2RReEwtHtQeIMbIgt3M=; b=oF2/B41nKNlni0Ag2p3ow/DeX/47H9a0+Ub86H5M6YObNnLFNL11veCene6zx2v4Sh+7+pKKk4/AOckhjcR+MjYZibg8nuWVaqKgAbTcn/SvcWZnzwrQTNoDahRD3bsFrVjFeGVRCtz7PQ63SsJodJ4oS5a6S1Y7sJvnbxGr7Eo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 1602522607468130.94594267357536; Mon, 12 Oct 2020 10:10:07 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id h5so9947166wrv.7 for ; Mon, 12 Oct 2020 10:10:06 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id y6sm25666395wrt.80.2020.10.12.10.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u3qL4sMDH/Dtxtrv1yhVgK7r2RReEwtHtQeIMbIgt3M=; b=qculCezzeD43ig0+I83rawGeWv6OJTl8Z3uEMRe8vAk2ALOqMMnXDnULec4QESxgBl tPqDER1gzLmj/NVg23d5c8Ummt2E8HU3PzCAZYGZ7CY5crt/ruKPOHBjAG5pkD90Xns7 zxKqjdsJUaDk6/lt+rnHLLiB5P58sigWEDbg31oS4J12t7Rr35ehYsy6GPSJcLn7RPLX 1i3GS4iOHFzhi4irFKb/JO1MzqTaafPrkCMKAlB9aziHLN3VH9z8eM9JEschc34MWRlc MQsHzkVc3V8Jn1zNeLVlv8ffE3xucCrBREia3UlmPlvMk/14hC3pfg4VE/itcRPm3DcV OaHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=u3qL4sMDH/Dtxtrv1yhVgK7r2RReEwtHtQeIMbIgt3M=; b=Befs9aDXekErv7seZiR1kEOw5iYpVOVZcWBcPh9gxO+/1crBSt8cyy1PdCZR1YT9uu 5mr2VbVbGJnqiLJCgQzwrfU1V8mztbk9Y12MNr2qBnYWmnBVZug02sacFAQ7OyPejrY9 fRMxw3Hn/iwNHwBlms0Gjjt/fjL2QuqjBXNv7FcTMJCbnX/qc0bglr56DA+HhADotHOA 4Z/7Xc39TKJ9UwdNkTkNvgS/+JV3OhYrE+p8xy/8vMFEw9AIlXeBcWXelLKH2NYgoX0L /Asi8/NllQ4dJpwy9P5OARTVaUc49j8JijPz7cyLfmxLi6IJyPwHvAAvEQ+ukWYtHaIT Oi9Q== X-Gm-Message-State: AOAM531MPoQ7SaxqhnGPx2gYMzW4eOJB9pOfBXXt+clM53+s3kGZsmDq bN4Aqk0cl+OPjd/iv2p/q7A= X-Google-Smtp-Source: ABdhPJx9YarihkbWCLjLA+zauH3C5Ur5TUjz8h6l42q4X7K0ulHNlIBXm9b1PdViTxEjViRGQUF2QQ== X-Received: by 2002:a5d:6143:: with SMTP id y3mr13532957wrt.277.1602522605660; Mon, 12 Oct 2020 10:10:05 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/6] hw/pci-host/sabre: Simplify code initializing variable once Date: Mon, 12 Oct 2020 19:09:47 +0200 Message-Id: <20201012170950.3491912-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We only need to zero-initialize 'val' once. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 0889c9369f6..3645bc962cb 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -195,32 +195,25 @@ static uint64_t sabre_config_read(void *opaque, hwaddr addr, unsigned size) { SabreState *s =3D opaque; - uint32_t val; + uint32_t val =3D 0; =20 switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ - val =3D 0; /* XXX: not implemented yet */ break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { val =3D s->pci_irq_map[(addr & 0x3f) >> 3]; - } else { - val =3D 0; } break; case 0x1000 ... 0x107f: /* OBIO interrupt control */ if (addr & 4) { val =3D s->obio_irq_map[(addr & 0xff) >> 3]; - } else { - val =3D 0; } break; case 0x1080 ... 0x108f: /* PCI bus error */ if (addr & 4) { val =3D s->pci_err_irq_map[(addr & 0xf) >> 3]; - } else { - val =3D 0; } break; case 0x2000 ... 0x202f: /* PCI control */ @@ -229,8 +222,6 @@ static uint64_t sabre_config_read(void *opaque, case 0xf020 ... 0xf027: /* Reset control */ if (addr & 4) { val =3D s->reset_control; - } else { - val =3D 0; } break; case 0x5000 ... 0x51cf: /* PIO/DMA diagnostics */ @@ -239,7 +230,6 @@ static uint64_t sabre_config_read(void *opaque, case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ default: - val =3D 0; break; } trace_sabre_config_read(addr, val); --=20 2.26.2 From nobody Mon Nov 17 01:27:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) client-ip=209.85.221.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1602522611; cv=none; d=zohomail.com; s=zohoarc; b=mzoZhCw4DU0UiLlokENMzbvhtDwLak+ar/TZYllyzGyBnUxJ2cDeh0U15wE5uJBsL1J1G8i0T3ytzQgdDneNGXaWKJgZJEMq1sxspvCN3JkzKN3Wjd+L3z8+WQ+/dfhQqppBQfs5Ql8lOFi919QyMv19896aXNO29DLRTHD/7Zo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522611; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=g+ZuN081JnWofgtvw5Xcnn25A8ChgQoZUlp7TAnTGlc=; b=nAYaSa3VY9SZ39MQulWyYahg0yYSCOpt4qaOqyR2PTLzB+PzvjDnUF9/X+JWyWuIcv8ubkV+A9HDwmGRImgXe1Yy+/iyYsOee0BtRN6vo4q6AK/xSBZELn36J/ZRikk6Fu7o3wDOcNycXe+JgjjMH6IRO0dlPI1MJ5tYWO07h7M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.zohomail.com with SMTPS id 1602522611760887.5498738589416; Mon, 12 Oct 2020 10:10:11 -0700 (PDT) Received: by mail-wr1-f66.google.com with SMTP id t9so20013516wrq.11 for ; Mon, 12 Oct 2020 10:10:11 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id b5sm3359947wrs.97.2020.10.12.10.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g+ZuN081JnWofgtvw5Xcnn25A8ChgQoZUlp7TAnTGlc=; b=Tzncg49ROC/sfxYjVrVxZ7A+r7tL+fD5nrGLNX8NgPAiDn/wJddqdLgNRfAIaCYioz Aup7mvBGbCcsBnf17lHSZ5qVuQWLxYFsN0sKxtXVBmTenDU/Obh/oHdSN/5X1abvjaB8 2CIQcPJtRe+nbMGb4Rg1zVNCIQgYS/a7vKsztHA9/DSMu9TkzdphaDAUnIWSyvrqXwQN XQzjXpmVByL6g/Z7yGArIOJfbTFofz/feVfBWRRN0f7NqEpP50nGsJaV2+9ClvG3X5WL VrwuQU4LJlUssE6hEYDQSLYzl1W9pPtxfX8aGeSS7jYdbF7uSM9fY14GNwfQ7V32sLLG DMkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=g+ZuN081JnWofgtvw5Xcnn25A8ChgQoZUlp7TAnTGlc=; b=n4UcH+fCup0A68VOS/rUSs7XZwDY/oGxj4/FISI3p4W/sOZqnky3yI7HkZ3qonPPv2 +UFvZnuqj4u4SjY/dEya6RL3v5v69ARnf92JdWu4leCr+fuQNdiCLBFSEkgG3voyailY zz7qVhYgyJ8BxrFe1Q4KVArLOTxFohdexDxK0ySQjEF9ZeV/e4IkN0n6ZKRbyeF/MGr8 CjWy0NRqyPH2Zs+kAoGLRbQs8PhclKO7vyAsekCLD7PNiDOAdKP8OTP1xZ8GhglAa1r+ GUAp4vDjVbts/coYOjEZX0JZOn6IvQjmbvqUBHyon8Z7DZjOKpNUkPbA+TVMy/xncAUA dNwQ== X-Gm-Message-State: AOAM530DuPoJAtclSCAzNm6FDawVF11Oc3zEL4CedQinCYUsz5ZAoMAv rw5wsA5ybQ44tEjX7yrrIbo= X-Google-Smtp-Source: ABdhPJxGEj9mYPb+dAW62VOwNvCZDqTYCzRwcgq81RPp+ctwU3YWEo3DuJoWbgOZNW5jblugNRumoQ== X-Received: by 2002:adf:e681:: with SMTP id r1mr1622526wrm.181.1602522609942; Mon, 12 Oct 2020 10:10:09 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP log_mask Date: Mon, 12 Oct 2020 19:09:48 +0200 Message-Id: <20201012170950.3491912-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Report unimplemented register accesses using qemu_log_mask(UNIMP). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/pci-host/sabre.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 3645bc962cb..4412e23131c 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -121,8 +121,10 @@ static void sabre_config_write(void *opaque, hwaddr ad= dr, trace_sabre_config_write(addr, val); =20 switch (addr) { - case 0x30 ... 0x4f: /* DMA error registers */ - /* XXX: not implemented yet */ + case 0x30 ... 0x4f: /* DMA error registers */ + qemu_log_mask(LOG_UNIMP, + "%s: Register 0x%02" HWADDR_PRIX " not implemented\n= ", + __func__, addr); break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { @@ -198,8 +200,10 @@ static uint64_t sabre_config_read(void *opaque, uint32_t val =3D 0; =20 switch (addr) { - case 0x30 ... 0x4f: /* DMA error registers */ - /* XXX: not implemented yet */ + case 0x30 ... 0x4f: /* DMA error registers */ + qemu_log_mask(LOG_UNIMP, + "%s: Register 0x%02" HWADDR_PRIX " not implemented\n= ", + __func__, addr); break; case 0xc00 ... 0xc3f: /* PCI interrupt control */ if (addr & 4) { --=20 2.26.2 From nobody Mon Nov 17 01:27:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.65 as permitted sender) client-ip=209.85.221.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602522616; cv=none; d=zohomail.com; s=zohoarc; b=IOA/qHR1U2mv/qLZcO1MbjUr9FCWfam2taN8MqBWja/eYSo+yjXNsxcwtGJLOu41ujzOJQ2mFTTYy9cxrLZncNwNjGtzx/j6NBG5C0mpkerL8C+jz/Yr3+6zInQ6moIIyBFxi9nQBbICozaRN3TR8AhtXNm9EEstpTHeTmFb/hk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522616; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gLKWS8Y8T9sXU+gbSEsaUnFE046T7Q7iWcrjHNDSPUk=; b=ij2dqDUH3+1RLIyg7e2ZnKm4wugo2FOTV/RrKygg+mQ44X7fNlElrAChO8FVyPyjOPQppHLJIv+KLfqbxo9+fywwe4lLlVvk9p+57YG+j31y6KgmraS1gHvFdo2hCAka0EeSQyow0JcyaWPaEWbfMgOlB+onuPovagcUZ9PlOog= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.zohomail.com with SMTPS id 1602522616374868.9702334958263; Mon, 12 Oct 2020 10:10:16 -0700 (PDT) Received: by mail-wr1-f65.google.com with SMTP id e17so19996057wru.12 for ; Mon, 12 Oct 2020 10:10:15 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id w11sm25209231wrs.26.2020.10.12.10.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gLKWS8Y8T9sXU+gbSEsaUnFE046T7Q7iWcrjHNDSPUk=; b=NtNvyNRM4x7aQxGrPNbrQKZW4ltl1eJR38nqwUpNbd0/CVRCciWskuvfINpVkwywVb EhQCHZteY4Pb2I1KijKDI5molNPv94ekDuhf5IDR6lMyyy9+s9zXEDy/QBakCoJQjAsC lXyr5CcEN5HJ2mpcRitBf1XzzLtlRlss/L8HY+WMZq7Pq+ZC/jLrNqAXrMC+TTbeROQp Etnw+k0ihnMDBEAeo0jaHL7/G+ezgSk9vE6hu4L+D4idWAbvQJIelGl0fa7hDx0bgkNy 6lkdTJyzvbM/2NcR7/95KGNePe0AERHRFL1SOXDg5B17xHxGdJchvPiOHL+ixtPXBZrF 6Tuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gLKWS8Y8T9sXU+gbSEsaUnFE046T7Q7iWcrjHNDSPUk=; b=E8enhzpY6dwHQU+nOLagcVTKUSOzPd9cRLSdP69pplT6B6cm5WVyP25IjMi42Wglt1 NLy7HM7SkoXXTabdMA4GXsR3mstFClfxYj5/JVHNHMYZ4+HGMgzW8AT8kZePEcU/TpIb UHzv8wLgcn3Jr44FKBfn/NTxu54xqQK1kQTZAU9DaFxlSv/iqp9T9IrnWuJCIWU/6O+h EU4+F4aG6k5Zsrxp1XieaHJ5wg8v1kQ9A99d6vU//ho/KRzXXvWoywKUpWIN6fYPAnH+ Lfl4zNFTmFZP/a661+MsstaXPRkFxH51bpylHkajHHlLSkkhQtULOZ2oZgODpNjxWwXB oI3g== X-Gm-Message-State: AOAM530xipZP1o3+aRDdQLSA5zwUB7hiExfV8qMMe0W2CZ4NjiALcxo5 Tbr/zIND9OUhvkxph5bND2I= X-Google-Smtp-Source: ABdhPJxRfwQn2L34y4SvXdgnGyJtQNCbpsc4mV/IiIX1Oqm+KoanB9VUGPBH4+AldnTX7IqHow+4nw== X-Received: by 2002:a5d:4fcc:: with SMTP id h12mr11815107wrw.132.1602522614431; Mon, 12 Oct 2020 10:10:14 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 5/6] hw/pci-host/sabre: Report IOMMU address range as unimplemented Date: Mon, 12 Oct 2020 19:09:49 +0200 Message-Id: <20201012170950.3491912-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/pci-host/sabre.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 4412e23131c..67699ac9058 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -122,6 +122,7 @@ static void sabre_config_write(void *opaque, hwaddr add= r, =20 switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ + case 0x200 ... 0x21f: /* IOMMU registers */ qemu_log_mask(LOG_UNIMP, "%s: Register 0x%02" HWADDR_PRIX " not implemented\n= ", __func__, addr); @@ -201,6 +202,7 @@ static uint64_t sabre_config_read(void *opaque, =20 switch (addr) { case 0x30 ... 0x4f: /* DMA error registers */ + case 0x200 ... 0x21f: /* IOMMU registers */ qemu_log_mask(LOG_UNIMP, "%s: Register 0x%02" HWADDR_PRIX " not implemented\n= ", __func__, addr); --=20 2.26.2 From nobody Mon Nov 17 01:27:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) client-ip=209.85.128.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602522620; cv=none; d=zohomail.com; s=zohoarc; b=dyBTpkUPYT97SejeBeECKQvuKXQMw+Ay9RhY7nqsOl6NrJX/6xY1MmA9bNhbNs1a0oByD/EdAh6e9EvUFigdwvDyWYDRBZAiz/539Vjr/XVw1XKxBIYguVrFxIClQs3v2I+hUbh+Sd4lmoNCXAXt9p9u/1wwGW2+5zrEIzh3jvY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602522620; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T1VyM6vO+/UgLy3YgWrY448pDVaigr36dSzmUkhUC2A=; b=fYft904WM9+UkzUFYOsxJ5dp+oZVxR4oO5jWiIUOL/FjaEutJsJtEXravvgsh1A/xlZ+zboZ7Zh0cplS7Reo0CiVJlabnQ7EZNYrmEVvrxteH+s2/ipbRnDlY1aVbgl50wXC8IljuYVtSnlGHRK9p7gobD/H5rfftBjEq+btBSs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.zohomail.com with SMTPS id 1602522620806420.33389395294626; Mon, 12 Oct 2020 10:10:20 -0700 (PDT) Received: by mail-wm1-f68.google.com with SMTP id 13so17778954wmf.0 for ; Mon, 12 Oct 2020 10:10:20 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id u15sm23106397wml.21.2020.10.12.10.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T1VyM6vO+/UgLy3YgWrY448pDVaigr36dSzmUkhUC2A=; b=ah7JfWJuVEfIlML4YkqazrwbS7sEXPVCIhdOxoNBXgZsX1PlXbFVgZntXipr8W2lpb 9OQymwbhvVjmyjpF4Ez0RdjTxIhfhK8uR9KqVNMWooaRANbRQMYlpGgllxDBadNRlL0s EP1iD+tjx+c1kD3HQCB8XUf85OwlYxldW4IfW7HFUZEQDq2LNJgjLHAwBGUQWfw0Llaq DPF7QkRHDx6Saqycyvg7E3iJlrwVvf6iMw+Hws1IRLxU3Q9loZ+jbWXh9vsfWiy0PYqc F93b9zOuO0vzW9Pu68qsVRVXWmKpQe36sjVrNr7Jg6nvq0vpgmvl7ZYkBEonj9X6OMyM hvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=T1VyM6vO+/UgLy3YgWrY448pDVaigr36dSzmUkhUC2A=; b=bgGSAf7cst3taGv212yPGcnzlI20kYUoImZdfEVmr7ZL9OZYA4Z1CJggi0N+M81qIn gsjtZq3I8J9jgNGqzIUEcYy1wu670mttw4EM/PB/YAQl++srd0ormCKKrfC11nOkFgA5 Mt3aKNjxxdvWDPZvrJ5fs5UuDq+SejvKqa3IpMo0z6HYVfUoPSm05Hx1nj2+N7qIZsHT JI9DX4zAPksaj90sQpo3JjJh/E+w7mlgo2MJwmi3VnjpMXdtYMyvMYG89SVfhiOXb0HQ yQEeVFC24yg9y4M/XwwcgddEYpEDQkP2z/1mC5ntENyymCJxQXYnqVja+pipKSO8Ongq 1gMw== X-Gm-Message-State: AOAM532j7OXvHwluCay0f/REHNELQ8J45Fw1Iuja/sGDDbrKsyeIIkq5 bGUIT4TI37Mvys21t2/quT1dtId+3dU= X-Google-Smtp-Source: ABdhPJyxdsO9bDHuwTDwO7Z1fZXKTy3M2wfpNQrZ30oneOOWCHxnG40nAkdEInVoXWjVmeAJZFtjfA== X-Received: by 2002:a1c:9ecb:: with SMTP id h194mr11383273wme.140.1602522618940; Mon, 12 Oct 2020 10:10:18 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 6/6] hw/pci-host/sabre: Log reserved address accesses as GUEST_ERROR Date: Mon, 12 Oct 2020 19:09:50 +0200 Message-Id: <20201012170950.3491912-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012170950.3491912-1-f4bug@amsat.org> References: <20201012170950.3491912-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Report accesses to reserved registers using qemu_log_mask(GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 67699ac9058..cc97c266a57 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -189,7 +189,11 @@ static void sabre_config_write(void *opaque, hwaddr ad= dr, case 0xa800 ... 0xa80f: /* Interrupt diagnostics */ case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ + break; default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Register 0x%04" HWADDR_PRIX " is reserved\n", + __func__, addr); break; } } @@ -235,7 +239,11 @@ static uint64_t sabre_config_read(void *opaque, case 0xa800 ... 0xa80f: /* Interrupt diagnostics */ case 0xf000 ... 0xf01f: /* FFB config, memory control */ /* we don't care */ + break; default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Register 0x%04" HWADDR_PRIX " is reserved\n", + __func__, addr); break; } trace_sabre_config_read(addr, val); --=20 2.26.2