From nobody Sat May 11 05:25:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602515202; cv=none; d=zohomail.com; s=zohoarc; b=QOP5h4Y9gmK4SYFHGx6z3VjA0VYMnZAd9dwz3dm3y6g1VRLOO5GJMrnhP3QbPjYia9/qG+gqZX6C+04m8SbxzrhZCuI3BUl8LblyC7H3oqvnotyILTZU/7buxzNgcLm+yqBx9lYK2RdpX1+cNX6yV95olGGjR34cvxwW2x2CkCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602515202; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Yt1ZwtxxiBdAmwBQdlo5rlU+bu9ghVvP39xTdU72bBY=; b=cX+BqN3hSJcc44mRBlk0yYgoXzaQ8Mt5sG/2JX+wAYpte3MSdy2IPI07aK3ICGLwYhKI+goad8BASp0VVSCIsT14KaXCYO+7Z1VbT5N7I5DahbWQlCKvp67uUYZAoRZeQe06Zkp5pxWhy1Ek8CZwfrKoyFKM+wZngPT+EpGEdro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602515202573719.7314100899167; Mon, 12 Oct 2020 08:06:42 -0700 (PDT) Received: from localhost ([::1]:41708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRzPN-0003nV-QB for importer@patchew.org; Mon, 12 Oct 2020 11:06:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRzO5-0002o4-Dd for qemu-devel@nongnu.org; Mon, 12 Oct 2020 11:05:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kRzO1-0003SG-GO for qemu-devel@nongnu.org; Mon, 12 Oct 2020 11:05:20 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-whiQv5YrML2s0euWTQtt0g-1; Mon, 12 Oct 2020 11:05:09 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 41FAAAFD31; Mon, 12 Oct 2020 15:04:55 +0000 (UTC) Received: from f32-work.redhat.com (unknown [10.40.193.247]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B29CA6E718; Mon, 12 Oct 2020 15:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602515111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yt1ZwtxxiBdAmwBQdlo5rlU+bu9ghVvP39xTdU72bBY=; b=dOKgIZT/+cGY6gCue4R1xlKjOwu2QbG8Qd+DYWkjmLj79/yrxu8nGh3+Q9SISLHg++9waW Z2Bbcu4ZhPnWWxBjO4ovRgVHj45aBiV3RokxokOE6AExZY9HmYkFiIwmP9zdNOOl/4LeKT 9ZJn6OVOPomQWSvnMSa9mn0RMQM8Q+U= X-MC-Unique: whiQv5YrML2s0euWTQtt0g-1 From: Mauro Matteo Cascella To: qemu-devel@nongnu.org Subject: [PATCH] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet() Date: Mon, 12 Oct 2020 17:03:56 +0200 Message-Id: <20201012150356.79670-1-mcascell@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mcascell@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mcascell@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/11 23:52:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gaoning.pgn@antgroup.com, mcascell@redhat.com, linyi.lxw@antfin.com, kraxel@redhat.com, pauldzim@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Check the value of mps before it is used as divisor. Since HCCHAR_MPS is gu= est controllable, this prevents a malicious/buggy guest from crashing the QEMU process on the host. Signed-off-by: Mauro Matteo Cascella Reported-by: Gaoning Pan Reported-by: Xingwei Lin Reviewed-by: Paul Zimmerman --- hw/usb/hcd-dwc2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c index 97688d21bf..91476fd781 100644 --- a/hw/usb/hcd-dwc2.c +++ b/hw/usb/hcd-dwc2.c @@ -324,6 +324,12 @@ babble: } } =20 + if (mps =3D=3D 0) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad HCCHAR_MPS set to zero\n", __func__); + return; + } + tpcnt =3D actual / mps; if (actual % mps) { tpcnt++; --=20 2.26.2