From nobody Mon Feb 9 08:11:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602505680; cv=none; d=zohomail.com; s=zohoarc; b=mBcojkUjf/j0QnagP9YgSUGyp+GnpDFdqY4gzHHRFhXL2UZbTfPl9zaH/J2aACYUCPILI5mNT6E5iQrC55ynAP6oF4spzmoKvCd1UubQWxswN5A96GoHyrgPZO5hSEIE26FprAdZ0zHCP7g4/y6THi1UdF+0njp9rfFjkk2o7Z4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602505680; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GF3rPFB8TmDLVdIBNNrbowCvUxvjAQ6sUwTvdnLn0c0=; b=l+DYkddhoZS+wZAzz05RWq8j8AR5pQez7i/1RV/gT8rQyDI+y33bMIIumdHD7ZTO8M+9/UypYPJqGKyDf0UK/3K2KIMIhJ/WWglo+y9o3Y5AqvvBCh5QUH/iLikjJwqz27Vj2qy7mb8TNvAqkbSja96KOkBjcPxViTdH4RBqpm4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1602505680794143.78621518094724; Mon, 12 Oct 2020 05:28:00 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-380-sXQI79r2NDKVIerpaNaRbA-1; Mon, 12 Oct 2020 08:27:58 -0400 Received: by mail-wr1-f69.google.com with SMTP id u15so9280715wrn.4 for ; Mon, 12 Oct 2020 05:27:57 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id c185sm1996288wma.44.2020.10.12.05.27.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 05:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602505679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GF3rPFB8TmDLVdIBNNrbowCvUxvjAQ6sUwTvdnLn0c0=; b=QBOzvtcKtRXR/4j0FT5N9DqQk8hEBom3fg0jXN5TlQrEcRzedkkSpkkM5gBTg2uPr1gwvw FEkrNdcOuf56KPP51eQhkXCP7xVAqolN7CLNKnmGmsbjBteWqOqwaQNovebJP2oKpIAqnq g4dTiLR0o8g/RRWGs3AFDdXG1kWFJzg= X-MC-Unique: sXQI79r2NDKVIerpaNaRbA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GF3rPFB8TmDLVdIBNNrbowCvUxvjAQ6sUwTvdnLn0c0=; b=jnl9HkhvUEFdzFtSZASKlXnIF/4n/dOQTbnicaj/p5FWmQi8wKCdwvwiFdTcLR/DE+ jfIa6D82wQ6APiKFPEoIIBmc76PkweRXY7FpfYXKIsJ0XFGahuq7z3xOQIO8E0AUot3q +9aqe/R5axoh8k3KUqe8/xFZcLfxoMnnHHdEzwTLdiGJB1u0rJeFs0oOEDl4+RofuLH1 pNnx0Qkl88Q48lpcQAmrqPqzRzeRsZH8rA2V2poSkl0DL4vrvvMgnJ4XnVl/x2gN03v/ Gz33ODI8VANcGyeqwt9zQmoTHjvg35j1LQeWEHrPkSR8x3//yR1stQ7pfoWGghGxJeWZ ok8g== X-Gm-Message-State: AOAM532+E4rHwo9NPZJ4misp8w2byNzlcEaS3/RDbZW324o4SJ/Nbs3d qwvvI6cu8xWGOG8Eiz8/MZzMXibr6yphFH2FbsYxpzdV4z+IlWD70irJzyH4Lz3KTMPIZxPBfwg Q/7Qy5Fxgj2GDSg== X-Received: by 2002:a1c:e444:: with SMTP id b65mr11312709wmh.65.1602505676784; Mon, 12 Oct 2020 05:27:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx41js+WBMb2MispfLdqaz4gLSVYW8awTTGLAgTHE5/rIMaRjQ/nDK3HficsiAXqvS9xlAYjw== X-Received: by 2002:a1c:e444:: with SMTP id b65mr11312685wmh.65.1602505676574; Mon, 12 Oct 2020 05:27:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Pavel Dovgalyuk , Juan Quintela , Max Reitz , Paolo Bonzini , Kevin Wolf , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , "Dr. David Alan Gilbert" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pavel Dovgalyuk Subject: [PATCH v2 2/3] migration: Make save_snapshot() return bool, not 0/-1 Date: Mon, 12 Oct 2020 14:27:42 +0200 Message-Id: <20201012122743.3390867-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012122743.3390867-1-philmd@redhat.com> References: <20201012122743.3390867-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Acked-by: Pavel Dovgalyuk Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/migration/snapshot.h | 9 ++++++++- migration/savevm.c | 16 ++++++++-------- replay/replay-debugging.c | 2 +- replay/replay-snapshot.c | 2 +- 4 files changed, 18 insertions(+), 11 deletions(-) diff --git a/include/migration/snapshot.h b/include/migration/snapshot.h index c85b6ec75b7..a40c34307b5 100644 --- a/include/migration/snapshot.h +++ b/include/migration/snapshot.h @@ -15,7 +15,14 @@ #ifndef QEMU_MIGRATION_SNAPSHOT_H #define QEMU_MIGRATION_SNAPSHOT_H =20 -int save_snapshot(const char *name, Error **errp); +/** + * save_snapshot: Save a snapshot. + * @name: path to snapshot + * @errp: pointer to error object + * On success, return %true. + * On failure, store an error through @errp and return %false. + */ +bool save_snapshot(const char *name, Error **errp); int load_snapshot(const char *name, Error **errp); =20 #endif diff --git a/migration/savevm.c b/migration/savevm.c index a52da440f4b..fd2e5e8b663 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2658,7 +2658,7 @@ int qemu_load_device_state(QEMUFile *f) return 0; } =20 -int save_snapshot(const char *name, Error **errp) +bool save_snapshot(const char *name, Error **errp) { BlockDriverState *bs; QEMUSnapshotInfo sn1, *sn =3D &sn1, old_sn1, *old_sn =3D &old_sn1; @@ -2671,29 +2671,29 @@ int save_snapshot(const char *name, Error **errp) AioContext *aio_context; =20 if (migration_is_blocked(errp)) { - return ret; + return false; } =20 if (!replay_can_snapshot()) { error_setg(errp, "Record/replay does not allow making snapshot " "right now. Try once more later."); - return ret; + return false; } =20 if (!bdrv_all_can_snapshot(errp)) { - return ret; + return false; } =20 /* Delete old snapshots of the same name */ if (name) { if (bdrv_all_delete_snapshot(name, errp) < 0) { - return ret; + return false; } } =20 bs =3D bdrv_all_find_vmstate_bs(errp); if (bs =3D=3D NULL) { - return ret; + return false; } aio_context =3D bdrv_get_aio_context(bs); =20 @@ -2702,7 +2702,7 @@ int save_snapshot(const char *name, Error **errp) ret =3D global_state_store(); if (ret) { error_setg(errp, "Error saving global state"); - return ret; + return false; } vm_stop(RUN_STATE_SAVE_VM); =20 @@ -2779,7 +2779,7 @@ int save_snapshot(const char *name, Error **errp) if (saved_vm_running) { vm_start(); } - return ret; + return ret =3D=3D 0; } =20 void qmp_xen_save_devices_state(const char *filename, bool has_live, bool = live, diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c index 8785489c02d..5458a73fced 100644 --- a/replay/replay-debugging.c +++ b/replay/replay-debugging.c @@ -327,7 +327,7 @@ void replay_gdb_attached(void) */ if (replay_mode =3D=3D REPLAY_MODE_PLAY && !replay_snapshot) { - if (save_snapshot("start_debugging", NULL) !=3D 0) { + if (!save_snapshot("start_debugging", NULL)) { /* Can't create the snapshot. Continue conventional debugging.= */ } } diff --git a/replay/replay-snapshot.c b/replay/replay-snapshot.c index e26fa4c892e..4f2560d1568 100644 --- a/replay/replay-snapshot.c +++ b/replay/replay-snapshot.c @@ -77,7 +77,7 @@ void replay_vmstate_init(void) =20 if (replay_snapshot) { if (replay_mode =3D=3D REPLAY_MODE_RECORD) { - if (save_snapshot(replay_snapshot, &err) !=3D 0) { + if (!save_snapshot(replay_snapshot, &err)) { error_report_err(err); error_report("Could not create snapshot for icount record"= ); exit(1); --=20 2.26.2