From nobody Tue Feb 10 01:34:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) client-ip=209.85.221.67; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f67.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602444771; cv=none; d=zohomail.com; s=zohoarc; b=Lk3VNNP2+VoGmdvq0k+JN73flu4QmNc20VOTbN+w0BSzQVHd/x/fAM5QJvCWGiW+TzPsy0SlqVgQPR49zcHt1uAmCLlpFnvaWtagScJcO73GZreM82kSQN8p6uGf56fRH73tRQPHrahJDAo9R/6Ke1Tyv3vpsuL7asWLAUOT+wc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602444771; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0jpaxMymalQzJe7nkt3fK37nWgDJARQE9RMKxlzHDKI=; b=aCDAdEz+g9hCtIPW6zoBO9lNcWTd3aNltH1ktlIA9n0tgePpwP56ZusCZvSnIXGe065M9QYzp5GXAB8StXQ3gnAz4g5RJLzmwZYyBzc2yNA9/oL2C9TAcKj0vZMz031kyA/n+ngcf08nn8D2suk3hM5xGPY0SdP57FQNW0qFDIM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.zohomail.com with SMTPS id 1602444771252109.08421635765569; Sun, 11 Oct 2020 12:32:51 -0700 (PDT) Received: by mail-wr1-f67.google.com with SMTP id b8so3351769wrn.0 for ; Sun, 11 Oct 2020 12:32:50 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id a81sm23030618wmf.32.2020.10.11.12.32.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2020 12:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0jpaxMymalQzJe7nkt3fK37nWgDJARQE9RMKxlzHDKI=; b=uz+5gg1wHDtPr/S5ORv4Td1PAh5DSIAfCQWuFHeFFoQsmiwviFwUO9X+mxPY4AcYvY dhEklevtq1PXGH+HkTxJ3yLLf65URD5rG/8a9FTAiShuYX4A5SYs+Zpqy8/3fNWflOhW fFtuldLo4fTV2TxhVgyaoxqkIYIocYWAKRKzwdax30CpjGi1oRo3ojqEFiby0OlDJjZr KtFy4Kq9WsGkvJUD6QfCL643E3hjiQvlQJ/121uiF/CEdiDItNOXUMYwBoE4wAv803Zo txC9m71bcSEWbXa3lSSaSve+AU8z6U8MKvjtXyToez1LfPTD3pMY9McEdi+ujrY0blKX yO6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=0jpaxMymalQzJe7nkt3fK37nWgDJARQE9RMKxlzHDKI=; b=SGZDk/NMHL3xXTEStfGIum9O+AqHJXI0fqU7YkG6zRofD/08zNgI64PY+bNi3dbY5v cAy+GC1Xkhm9IzvtkNzEQ8F7a4yGQCVuvQfZLvth0uqxyK7Cq1ACUxfJ2reey/rEEiLP frrpMhKdvKiDVpCZkN5EwpizXZiFzmDxBYgCfTPd/s0K7KER4Sdc8dtKr7esZQt+m6Ou lsam5J9URW8jF7+9aJJkKcNDg29Vjm8eKLJ5aQ6Kg3ik2KiE9mMkCF7qRpRcSCjiMWCG EUmVH3RFMa3+0WDBxDKbd6SAj/V0PXJqu2eYaO0TbvSdsZqwV5qRzUQQSugUwAHRuivn JCaw== X-Gm-Message-State: AOAM532rp5LSdz2t0Mi44KgQXwHMgFJqPGljxMbQDhPRuQo+L7F5Xwnx cIYTPPUFMC2MezGxZEGy5gY= X-Google-Smtp-Source: ABdhPJzhnI81QO4NuG8+dCiW+MMDXBui58TatPQ8g+Lc44KzsdSlLSS4QaC7ExFGWP3IQSy0YyDHJQ== X-Received: by 2002:adf:bacc:: with SMTP id w12mr16965624wrg.66.1602444769499; Sun, 11 Oct 2020 12:32:49 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Eduardo Habkost , Corey Minyard , Paolo Bonzini , Aurelien Jarno , Kevin Wolf , Mark Cave-Ayland , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Stefan Berger , qemu-ppc@nongnu.org, Marcel Apfelbaum , Max Reitz , "Michael S. Tsirkin" , Laurent Vivier , Thomas Huth , John Snow , Igor Mammedov , Richard Henderson , qemu-trivial@nongnu.org, Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jason Wang Subject: [PATCH 03/10] hw/isa: Add the ISA_IRQ_SER_DEFAULT definition Date: Sun, 11 Oct 2020 21:32:22 +0200 Message-Id: <20201011193229.3210774-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201011193229.3210774-1-f4bug@amsat.org> References: <20201011193229.3210774-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The first serial port uses IRQ #4 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/isa/isa.h | 1 + hw/sparc64/sun4u.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index e139b88c992..519296d5823 100644 --- a/include/hw/isa/isa.h +++ b/include/hw/isa/isa.h @@ -10,6 +10,7 @@ =20 enum IsaIrqNumber { ISA_IRQ_KBD_DEFAULT =3D 1, + ISA_IRQ_SER_DEFAULT =3D 4, ISA_NUM_IRQS =3D 16 }; =20 diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index d4c39490cd9..6e42467d5cc 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -619,7 +619,7 @@ static void sun4uv_init(MemoryRegion *address_space_mem, qdev_get_gpio_in_named(DEVICE(sabre), "pbm-irq", OBIO_KBD_IRQ)); qdev_connect_gpio_out_named(DEVICE(ebus), "isa-irq", 12, qdev_get_gpio_in_named(DEVICE(sabre), "pbm-irq", OBIO_MSE_IRQ)); - qdev_connect_gpio_out_named(DEVICE(ebus), "isa-irq", 4, + qdev_connect_gpio_out_named(DEVICE(ebus), "isa-irq", ISA_IRQ_SER_DEFAU= LT, qdev_get_gpio_in_named(DEVICE(sabre), "pbm-irq", OBIO_SER_IRQ)); =20 switch (vga_interface_type) { --=20 2.26.2