From nobody Fri May 10 11:59:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) client-ip=209.85.128.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1602443015; cv=none; d=zohomail.com; s=zohoarc; b=nwDnB+pqklW1w8ruBQzxZdfGc6POQOJTK0H++OdiHR6ypviN3QMQn8nbJa8wX1liGCsNMnw5NoVgQCOVR1UrbpZu28qNLg6mxBIlVxsdHk8VIstaujQbUAjuMbFcQxiF/Mgyz0RZl5P+PtlTitOwFIef58qWn8W6v6RxZqqgo7A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602443015; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=gco4YRR45nuH6XpEMRUFQ155EIRVvfJb2Vz7xg/mTBI=; b=R/Aeap+kuxdMkrg2Ws0NRlHlvTrJDP6RKZoR7hDYUrOGjSbWZyXBZOYAE1yW+PbSvJvM09Jmi9pJbQ7oEqHrKIFSGjF/kWdFDhiWfyayXDfrNcw3zyZzmyECIK4c7FnUJnPGkmOlz+LdaXQQQZjvD0qKGMb8i5ngDR/mB1ABf/4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.zohomail.com with SMTPS id 1602443015983116.00090450940104; Sun, 11 Oct 2020 12:03:35 -0700 (PDT) Received: by mail-wm1-f68.google.com with SMTP id f21so15159600wml.3 for ; Sun, 11 Oct 2020 12:03:35 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id 205sm6296620wme.38.2020.10.11.12.03.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2020 12:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gco4YRR45nuH6XpEMRUFQ155EIRVvfJb2Vz7xg/mTBI=; b=jnqfCER2SMbbh7QNuaSSSlXzdYrlGU+kKN+pXuJUsiCkAqFX0fAC4ICZV94hdYTH7k JIw/0qeiqy/JE5f/PBPTlIDaQmJ4IrXd+6d2dQlPNsvqZ0I3o6XdYsAz+taFTyt1+Zzd +5lPraLwnbo4s198UGa9nqQlteYLzF++Yq4SOFbzECe667zyZxtTU7N2Y0FUvLFS0TY3 +7f6oyPAd0enWKn+z1JYjIildJkZ/omM6NQg6Fy72l6e5M6H24vlJSyzMu3GdIJItfgp Khb00GYJCCADnIPAW4v88VoyskATp/y4HAtTbD9uzU1jdKCZPH0TJ+fzJ7WdOVR6CK+v s0PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=gco4YRR45nuH6XpEMRUFQ155EIRVvfJb2Vz7xg/mTBI=; b=fiNsKOVpu61M3VPltTqOr2WWNH+Avn8o/m/GlEQZoioI530+u16Wkxb5Jv6SsoKGkn u40hM9+o3JECoIJ5LwOVjbO3WkLW8ddbSuwd2Rl/FDdTimqKjY6WG+//U3p/tMn6mXoO JJ6oypkpkdhOoZ8OWvDKbx+EgNPnBW0+IqL06c5Fe3WtW5CxiBdKf8Nh8w/SMIOQlVf9 G4ZbvpgLlENGHb94drxQ8KchnRYjwMlV4xKmc/NuJ3pX9z1bGmSwGtTUc3DI2+bWJszG 5/CAY6Pav5R+9fKmpvnjiOqR5K6AbEpMMusYLS3RJJrB9GlR5lAjfCikJ4tyDCX6x9dG yyzQ== X-Gm-Message-State: AOAM532JWdJwiLGN1LXExG1tpYliNswWjuYXVUMUmpZI00hZZ4pmmoTy YKKw1KP1HfaDsUBW41gUpM8= X-Google-Smtp-Source: ABdhPJyWjIjyBHiz/my7Jc51ZC0lIv9DNchonPTQzSRjwoIFUe6NRYTa9J1XJrmJN8Hh2DkLGAa4dA== X-Received: by 2002:a1c:1f87:: with SMTP id f129mr7911564wmf.182.1602443014144; Sun, 11 Oct 2020 12:03:34 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Mark Cave-Ayland , David Gibson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set Date: Sun, 11 Oct 2020 21:03:32 +0200 Message-Id: <20201011190332.3189611-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The Grackle PCI host model expects the interrupt controller being set, but does not verify it is present. Add a check to help developers using this model. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/pci-host/grackle.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c index 57c29b20afb..20361d215ca 100644 --- a/hw/pci-host/grackle.c +++ b/hw/pci-host/grackle.c @@ -76,6 +76,10 @@ static void grackle_realize(DeviceState *dev, Error **er= rp) GrackleState *s =3D GRACKLE_PCI_HOST_BRIDGE(dev); PCIHostState *phb =3D PCI_HOST_BRIDGE(dev); =20 + if (!s->pic) { + error_setg(errp, TYPE_GRACKLE_PCI_HOST_BRIDGE ": 'pic' link not se= t"); + return; + } phb->bus =3D pci_register_root_bus(dev, NULL, pci_grackle_set_irq, pci_grackle_map_irq, --=20 2.26.2