From nobody Sun Nov 16 23:04:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1602404505; cv=none; d=zohomail.com; s=zohoarc; b=O6rrdGErklBtDvPfSaynfMUt2ou6qhvtQ+VWMC5fgFn86zb8hLrEUEBTsltZcJlpTixD4XTLppgxPx1EbeHFqKyMPIvh1FYc5J33p3WHYLWwLDG13p7o288Dz+QZimmV8YSe7TA0aMkeUmAAV0XiQImSvcfxLP4wtiR14hLvELQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602404505; h=Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=PwMuAV56c3w0tbgMQrXAkJqmThzPKmch5FLxqYvtlmw=; b=DwUx2T5TDxiG3lIkcFk3Js2L2UxxKT67hCpAH9Z1AHZY9h8FuV76z50L8Sm5+0cQHJ/lE+kSjB2TSMZx0aJZYf78okdEwaUPW9S9Mqeqnm2+QRNglUwxLF3y0KA7C4+incD+51PxjGj2Fr3f3jxNberM1wG/P9tJelfdTskOwt8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602404505071197.63124201580297; Sun, 11 Oct 2020 01:21:45 -0700 (PDT) Received: from localhost ([::1]:39262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRWbv-0004KO-Fp for importer@patchew.org; Sun, 11 Oct 2020 04:21:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRWaq-0003mh-D5 for qemu-devel@nongnu.org; Sun, 11 Oct 2020 04:20:36 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:48152 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRWao-0007kr-7X for qemu-devel@nongnu.org; Sun, 11 Oct 2020 04:20:36 -0400 Received: from host86-158-109-18.range86-158.btcentralplus.com ([86.158.109.18] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRWaj-0004IB-Bn; Sun, 11 Oct 2020 09:20:34 +0100 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, mst@redhat.com, marcel.apfelbaum@gmail.com Date: Sun, 11 Oct 2020 09:20:22 +0100 Message-Id: <20201011082022.3016-1-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.158.109.18 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH] pci: assert that irqnum is between 0 and bus->nirqs in pci_change_irq_level() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" These assertions similar to those in the adjacent pci_bus_get_irq_level() f= unction ensure that irqnum lies within the valid PCI bus IRQ range. Signed-off-by: Mark Cave-Ayland --- This would have immediately picked up on the sabre PCI bus IRQ overflow fix= ed by the patch I just posted. --- hw/pci/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 3c8f10b461..b1484b3747 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -258,6 +258,8 @@ static void pci_change_irq_level(PCIDevice *pci_dev, in= t irq_num, int change) break; pci_dev =3D bus->parent_dev; } + assert(irq_num >=3D 0); + assert(irq_num < bus->nirq); bus->irq_count[irq_num] +=3D change; bus->set_irq(bus->irq_opaque, irq_num, bus->irq_count[irq_num] !=3D 0); } --=20 2.20.1