From nobody Mon May 13 15:48:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1602404120; cv=none; d=zohomail.com; s=zohoarc; b=mmLpdxu8eX7JcHVtpaYW1VAbcSIgSFBXe/0rsSMKjAN2oSmQI6s9d4+3wxNJShG3DvAp2FBSlspbF2xPwwkCcuETUpn7LRlbwn6GpvlZokGbVFNDvzxMlqi9wUCS0yqIt2NG8xK9u6IwxP2XV4OZV4BOl7fHdbW13u1o12cRnVQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602404120; h=Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=JLMIjrJe4+PRiSSd4edQrYiRGs29qSOWvHJlpslKDPA=; b=BPcIi5vgkCAlXVyrsfD7ZU8EAkYd6kIHNcSDftu/m9Y+5n+jZoqGwEvxnsG6KBiHlXHjUS90wst3OqdJES5sFSt+A1OSZYwiNSwtCY54a7H49a8voiXfiodh7/XnQZ9noDmDixoTH0jhVihC7LBlOTr7akkZ2X31GxQepr6zknc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160240412027560.533874544182254; Sun, 11 Oct 2020 01:15:20 -0700 (PDT) Received: from localhost ([::1]:34770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRWVi-000282-A0 for importer@patchew.org; Sun, 11 Oct 2020 04:15:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRWUS-0001aV-UJ for qemu-devel@nongnu.org; Sun, 11 Oct 2020 04:14:00 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:48130 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRWUQ-00075f-LX for qemu-devel@nongnu.org; Sun, 11 Oct 2020 04:14:00 -0400 Received: from host86-158-109-18.range86-158.btcentralplus.com ([86.158.109.18] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRWUL-0004G4-9q; Sun, 11 Oct 2020 09:13:58 +0100 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, atar4qemu@gmail.com Date: Sun, 11 Oct 2020 09:13:47 +0100 Message-Id: <20201011081347.2146-1-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.158.109.18 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH] sabre: increase number of PCI bus IRQs from 32 to 64 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The rework of the sabre IRQs in commit 6864fa3897 "sun4u: update PCI topolo= gy to include simba PCI bridges" changed the IRQ routing so that both PCI and leg= acy OBIO IRQs are routed through the sabre PCI host bridge to the CPU. Unfortunately this commit failed to increase the number of PCI bus IRQs accordingly meaning that access to the legacy IRQs OBIO (irqnum >=3D 0x20) = would overflow the PCI bus IRQ array causing strange failures running qemu-system= -sparc64 in NetBSD. Reported-by: Harold Gutch Fixes: https://bugs.launchpad.net/qemu/+bug/1838658 Fixes: 6864fa3897 ("sun4u: update PCI topology to include simba PCI bridges= ") Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/pci-host/sabre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 5ac6283623..ffdba1d865 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -396,7 +396,7 @@ static void sabre_realize(DeviceState *dev, Error **err= p) pci_sabre_set_irq, pci_sabre_map_irq,= s, &s->pci_mmio, &s->pci_ioport, - 0, 32, TYPE_PCI_BUS); + 0, 0x40, TYPE_PCI_BUS); =20 pci_create_simple(phb->bus, 0, TYPE_SABRE_PCI_DEVICE); =20 --=20 2.20.1