From nobody Sun Nov 16 23:03:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602274465; cv=none; d=zohomail.com; s=zohoarc; b=LM5uzvwFlqAdVW3CmuBmRVWC/eNYBRsTnb2T4BOwTXfgImaiELtDyKn7t3OiZskE5HSo5ARk5lHNEla9Z9MuDt8ZMA//YwKHQXFSIVX9Aa2kGTSzoRIdMJFIBjaXbJzoWIwyiKlMcIAF92TvYawyaoPEaUdQSvGiAps/xY9/jpE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602274465; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Xh9nJS3bCn0qGVP8FsGlWpOpJZ1/8BJ4mYezCiWBNJM=; b=REl3Vuf0Q2tujBDzKrT7tV3Vl2hp09Q5XnJ4UbbhJ6vDnZSJSD2athiyfNMvta/8plKtPSeOGalxRTkkU/WAURQaJPWQIHlhesxHogjuo0lZHVy20Td434NHMbhoSRtABFPnfLGr1yh0wEmxZh8wJ72dEIAG1II56iE0delcig4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602274465310466.19696859847375; Fri, 9 Oct 2020 13:14:25 -0700 (PDT) Received: from localhost ([::1]:50162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQymV-0006Hq-VA for importer@patchew.org; Fri, 09 Oct 2020 16:14:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQyfb-0008Jl-Tm for qemu-devel@nongnu.org; Fri, 09 Oct 2020 16:07:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQyfW-0007Mf-W1 for qemu-devel@nongnu.org; Fri, 09 Oct 2020 16:07:15 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-T9Khud8sNCyQqPakLM-Puw-1; Fri, 09 Oct 2020 16:07:03 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51B0A2ED6; Fri, 9 Oct 2020 20:07:02 +0000 (UTC) Received: from localhost (ovpn-119-102.rdu2.redhat.com [10.10.119.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1085360BE2; Fri, 9 Oct 2020 20:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602274029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xh9nJS3bCn0qGVP8FsGlWpOpJZ1/8BJ4mYezCiWBNJM=; b=VB/6B2P04DvCe+BkBbFrVn22V84vcV2RHvU/HJFHgrYcOC8N2VMBgcuv/n5gJnC3tiiydd 9t310nvttWl3FqkfgQL34DpAJ4J4BZnZWyVHIloA/wXBLePCHJOa9vrxOB9oUHEQya6W9r MLVmPNkrMy1YYTA3dVQgyYBLHLKqAjY= X-MC-Unique: T9Khud8sNCyQqPakLM-Puw-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH] vmbus: Don't make QOM property registration conditional Date: Fri, 9 Oct 2020 16:07:01 -0400 Message-Id: <20201009200701.1830060-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/09 02:34:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Maciej S. Szmigiero" , Roman Kagan , Jon Doron Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Having properties registered conditionally makes QOM type introspection difficult. Instead of skipping registration of the "instanceid" property, always register the property but validate its value against the instance id required by the class. Signed-off-by: Eduardo Habkost Acked-by: Maciej S. Szmigiero --- Note: due to the lack of concrete vmbus-dev subclasses in the QEMU tree, this patch couldn't be tested. --- hw/hyperv/vmbus.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 896e981f85..481d7e8d3c 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -2371,6 +2371,14 @@ static void vmbus_dev_realize(DeviceState *dev, Erro= r **errp) =20 assert(!qemu_uuid_is_null(&vdev->instanceid)); =20 + if (!qemu_uuid_is_null(&vdc->instanceid)) { + /* Class wants to only have a single instance with a fixed UUID */ + if (!qemu_uuid_is_equal(&vdev->instanceid, &vdc->instanceid)) { + error_setg(&err, "instance id can't be changed"); + goto error_out; + } + } + /* Check for instance id collision for this class id */ QTAILQ_FOREACH(child, &BUS(vmbus)->children, sibling) { VMBusDevice *child_dev =3D VMBUS_DEVICE(child->child); @@ -2437,18 +2445,22 @@ static void vmbus_dev_unrealize(DeviceState *dev) free_channels(vdev); } =20 +static Property vmbus_dev_props[] =3D { + DEFINE_PROP_UUID("instanceid", VMBusDevice, instanceid), + DEFINE_PROP_END_OF_LIST() +}; + + static void vmbus_dev_class_init(ObjectClass *klass, void *data) { DeviceClass *kdev =3D DEVICE_CLASS(klass); + device_class_set_props(kdev, vmbus_dev_props); kdev->bus_type =3D TYPE_VMBUS; kdev->realize =3D vmbus_dev_realize; kdev->unrealize =3D vmbus_dev_unrealize; kdev->reset =3D vmbus_dev_reset; } =20 -static Property vmbus_dev_instanceid =3D - DEFINE_PROP_UUID("instanceid", VMBusDevice, instan= ceid); - static void vmbus_dev_instance_init(Object *obj) { VMBusDevice *vdev =3D VMBUS_DEVICE(obj); @@ -2457,8 +2469,6 @@ static void vmbus_dev_instance_init(Object *obj) if (!qemu_uuid_is_null(&vdc->instanceid)) { /* Class wants to only have a single instance with a fixed UUID */ vdev->instanceid =3D vdc->instanceid; - } else { - qdev_property_add_static(DEVICE(vdev), &vmbus_dev_instanceid); } } =20 --=20 2.26.2