From nobody Mon Nov 17 01:31:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1602239092; cv=none; d=zohomail.com; s=zohoarc; b=X/KI07VxrawyOVUgVepTsowBsGssRSdorEAQ0Tx0G9uHemr1hKAqbasDIkkcGJNm5MuTtcdK3pkIPWdW5fJcJlfn6rx0JSCV0JH6NM7D7bTaLiOCkzHC3ec0+/RaRD8sI6lCpYnsNHX4/voyu3M3g38gOQ84ZhdwkQ0cdLMbeJQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602239092; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RtpVMZrZjByfa5hgI1rCzp7hGJj1opQN2/yLy+zSUGo=; b=VVhgyGgDB31IYCAVCqNIPwcuiGzyMKmte6SUxXDsanA/Q+gHI5IkTYV5p5QE6985B6vbHenHExqLM7hwpQocxpmw6KWttdispLyDT/YNNyXFhG1J/IIC5Qh3I4P0Y0wXNeOwmbEHiKSERKUZgtjvq49esNffJ1LuTyI/CnqI5YY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602239092559670.4618222204339; Fri, 9 Oct 2020 03:24:52 -0700 (PDT) Received: from localhost ([::1]:55364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQpZz-000240-B2 for importer@patchew.org; Fri, 09 Oct 2020 06:24:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQpVU-0005FI-I9 for qemu-devel@nongnu.org; Fri, 09 Oct 2020 06:20:13 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:48777 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQpVQ-0001mc-HT for qemu-devel@nongnu.org; Fri, 09 Oct 2020 06:20:12 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4C73wX034Wz9sVM; Fri, 9 Oct 2020 21:19:55 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1602238796; bh=tQlKX5/6ah1tqzgovx914AmLnL9Dm4wGAwv93zwiCG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jco1EC4Jf9H51ruhYC8tnDnPSinPQEEOaVf3zfUURmzNIm3FO83w+x8g+h2j4jRLo P4xHpHcJu3ZFhjsRYcJDaz1OmIqluJ+IU+uPFmUFSJRBE4wpeIhlExFIioeY73uZ5j qZKPv0eJvOjFeIHdFtzFluFI7tbibNRy5o7DxReE= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 05/20] spapr: Simplify error handling in callers of ppc_set_compat() Date: Fri, 9 Oct 2020 21:19:36 +1100 Message-Id: <20201009101951.1569252-6-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201009101951.1569252-1-david@gibson.dropbear.id.au> References: <20201009101951.1569252-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/09 06:19:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , dbarboza@redhat.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nonngu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Greg Kurz Now that ppc_set_compat() indicates success/failure with a return value, use it and reduce error propagation overhead. Signed-off-by: Greg Kurz Message-Id: <20200914123505.612812-5-groug@kaod.org> Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: David Gibson --- hw/ppc/spapr.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 544a1947d9..0f82e657e3 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3817,10 +3817,9 @@ static void spapr_core_plug(HotplugHandler *hotplug_= dev, DeviceState *dev, */ if (hotplugged) { for (i =3D 0; i < cc->nr_threads; i++) { - ppc_set_compat(core->threads[i], POWERPC_CPU(first_cpu)->compa= t_pvr, - &local_err); - if (local_err) { - error_propagate(errp, local_err); + if (ppc_set_compat(core->threads[i], + POWERPC_CPU(first_cpu)->compat_pvr, + errp) < 0) { return; } } --=20 2.26.2