From nobody Sun Nov 16 23:16:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1602230349; cv=none; d=zohomail.com; s=zohoarc; b=NRDFajh7eF7wziR8baDauKh/FxULZtTI+Rg/iC/193wBVy5sWqKPWqNBTtJ4wtjzhTO0tRDOVJywqEwEtI2+dAfnMHdE3ShTnHvB2zqKa0bNpUYUxuhAbxCrgwyTZWDLyGR5q98pDppMalpgtIhMDiEOm7txjJ3XcHC3izJws0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602230349; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=08DnUjx6j2NB9kUi4ob13ugahpGL4DPy4y8FJYKzxnk=; b=TnWoLDgqG5wFLgtvS1d8C1rVW59whF5c09wZVkywBA5Cq3QqYo5wBehumYTRrq9dC+Kf+GXXuF6pgmL3RfkVrYEcZjGKquM1/rDws2uSkzA8xNsK9qIDT1QDvG97rEhyMX0lWvfVP2IR+OgQzRjkYYmECkUcn5P2fCVPx6NspYQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602230349761982.4621679895778; Fri, 9 Oct 2020 00:59:09 -0700 (PDT) Received: from localhost ([::1]:47078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQnIx-0007VQ-SN for importer@patchew.org; Fri, 09 Oct 2020 03:59:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQnI8-0006xj-3a; Fri, 09 Oct 2020 03:58:16 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:40920 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQnI5-00012V-JT; Fri, 09 Oct 2020 03:58:15 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 441313AAF4FEEA558ADA; Fri, 9 Oct 2020 15:57:58 +0800 (CST) Received: from huawei.com (10.174.185.47) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Fri, 9 Oct 2020 15:57:49 +0800 From: Yifei Jiang To: , Subject: [PATCH V2] target/riscv: raise exception to HS-mode at get_physical_address Date: Fri, 9 Oct 2020 15:57:40 +0800 Message-ID: <20201009075740.688-1-jiangyifei@huawei.com> X-Mailer: git-send-email 2.26.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.185.47] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=jiangyifei@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/09 02:46:07 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, sagark@eecs.berkeley.edu, kbastian@mail.uni-paderborn.de, victor.zhangxiaofeng@huawei.com, Yifei Jiang , Alistair.Francis@wdc.com, yinyipeng1@huawei.com, palmer@dabbelt.com, wu.wubin@huawei.com, dengkai1@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" VS-stage translation at get_physical_address needs to translate pte address by G-stage translation. But the G-stage translation error can not be distinguished from VS-stage translation error in riscv_cpu_tlb_fill. On migration, destination needs to rebuild pte, and this G-stage translation error must be handled by HS-mode. So introduce TRANSLATE_STAGE2_FAIL so that riscv_cpu_tlb_fill could distinguish and raise it to HS-mode. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/cpu.h | 1 + target/riscv/cpu_helper.c | 17 +++++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index de275782e6..8b856d518e 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -86,6 +86,7 @@ enum { #define TRANSLATE_FAIL 1 #define TRANSLATE_SUCCESS 0 #define MMU_USER_IDX 3 +#define TRANSLATE_G_STAGE_FAIL 4 =20 #define MAX_RISCV_PMPS (16) =20 diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 904899054d..096006dc00 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -451,7 +451,10 @@ restart: mmu_idx, false, true); =20 if (vbase_ret !=3D TRANSLATE_SUCCESS) { - return vbase_ret; + env->guest_phys_fault_addr =3D (base | + (addr & + (TARGET_PAGE_SIZE - 1))) >>= 2; + return TRANSLATE_G_STAGE_FAIL; } =20 pte_addr =3D vbase + idx * ptesize; @@ -730,12 +733,22 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, = int size, ret =3D get_physical_address(env, &pa, &prot, address, access_type, mmu_idx, true, true); =20 + /* + * A G-stage exception may be triggered during VS-stage translatio= n. + * And the env->guest_phys_fault_addr has already been set in + * get_physical_address(). + */ + if (ret =3D=3D TRANSLATE_G_STAGE_FAIL) { + first_stage_error =3D false; + access_type =3D MMU_DATA_LOAD; + } + qemu_log_mask(CPU_LOG_MMU, "%s 1st-stage address=3D%" VADDR_PRIx " ret %d physi= cal " TARGET_FMT_plx " prot %d\n", __func__, address, ret, pa, prot); =20 - if (ret !=3D TRANSLATE_FAIL) { + if (ret !=3D TRANSLATE_FAIL && ret !=3D TRANSLATE_G_STAGE_FAIL) { /* Second stage lookup */ im_address =3D pa; =20 --=20 2.19.1