From nobody Sun Nov 16 23:03:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602188962; cv=none; d=zohomail.com; s=zohoarc; b=Q04BsUvugSlahmXwaci4uD+PZ8ccuPpqBd+bRthea03pQ3lSeAGdkvaWF8P0Mv2tQzqQcbHxFyEkBkwvpFIr5ZTnLD4VmewAsxIIfh/76CZsV/+ipLZZq+5TFqaUSqjKu5Ysd/KMKQrRdhXVSql5dcfBUyBQmabeqfW71TXhop0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602188962; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yj12oITVEgWM3MNWR3Hu+YVNSz6iK8jlQxvhaPR1rew=; b=WSg7+126Xo90Z5IWG48L8La5G7JahMjHL6Vanr8NtYzH5pSXjw0i4WU0HRLV6y8UA/ZGam4zs1/KzYnF6V4yYDyWtLFwqsgfV3mu1BJJFnmLnq5bd8nnLXMTqzVolfCzcT2ZyOjjCG8JlaqWBxHLsdJdgaH7BxUZRKsNeMW3W/8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602188962524986.9327895707648; Thu, 8 Oct 2020 13:29:22 -0700 (PDT) Received: from localhost ([::1]:57602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQcXR-0004Rr-4N for importer@patchew.org; Thu, 08 Oct 2020 16:29:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQcVd-0003BU-N8 for qemu-devel@nongnu.org; Thu, 08 Oct 2020 16:27:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50496) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQcVc-0005uT-5A for qemu-devel@nongnu.org; Thu, 08 Oct 2020 16:27:29 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-MT3ppzEyN0qpShjqqiKMRQ-1; Thu, 08 Oct 2020 16:27:23 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C5731019626; Thu, 8 Oct 2020 20:27:22 +0000 (UTC) Received: from localhost (ovpn-119-102.rdu2.redhat.com [10.10.119.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 84516702E7; Thu, 8 Oct 2020 20:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602188847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yj12oITVEgWM3MNWR3Hu+YVNSz6iK8jlQxvhaPR1rew=; b=iyFdy8wUe04hBo/1jn6N+op9U+BKI1x9AtzlrnF93ur+hiJl0chJuHlK6FV6S+8QjjL6eM 34cuSUsRiqXrBuqRGYoCSoWwXYDusH8GONTm6sHEEoEV2vteDuwXkn2XSIgSI2EpuY/LvZ 0GZAJCtxfwseATiwa5l0NhP0WPx6gMA= X-MC-Unique: MT3ppzEyN0qpShjqqiKMRQ-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH 1/3] authz-list-file: Fix crash when filename is not set Date: Thu, 8 Oct 2020 16:27:11 -0400 Message-Id: <20201008202713.1416823-2-ehabkost@redhat.com> In-Reply-To: <20201008202713.1416823-1-ehabkost@redhat.com> References: <20201008202713.1416823-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/08 01:56:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vikram Garhwal , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Jason Wang , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pavel Pisa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Fix the following crash: $ qemu-system-x86_64 -object authz-list-file,id=3Dobj0 qemu-system-x86_64: -object authz-list-file,id=3Dobj0: GLib: g_file_get_c= ontents: assertion 'filename !=3D NULL' failed Segmentation fault (core dumped) Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Li Qiang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: "Daniel P. Berrang=C3=A9" Cc: qemu-devel@nongnu.org --- authz/listfile.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/authz/listfile.c b/authz/listfile.c index cd6163aa40..aaf930453d 100644 --- a/authz/listfile.c +++ b/authz/listfile.c @@ -122,6 +122,11 @@ qauthz_list_file_complete(UserCreatable *uc, Error **e= rrp) QAuthZListFile *fauthz =3D QAUTHZ_LIST_FILE(uc); gchar *dir =3D NULL, *file =3D NULL; =20 + if (!fauthz->filename) { + error_setg(errp, "filename not provided"); + return; + } + fauthz->list =3D qauthz_list_file_load(fauthz, errp); =20 if (!fauthz->refresh) { --=20 2.26.2 From nobody Sun Nov 16 23:03:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602189106; cv=none; d=zohomail.com; s=zohoarc; b=RdEVJX5SKYavhuIgySSlK5z/MQT5xnthjXIwr5FMtKz6dth8Mf4XZBfdO0PONsPFWauQEe5DQGYWUScqcoeXnK9onXxpg/KrbUUG8ykBmyJqoMn3OkPfrVDDtJV3nZaOGk/i0s1EC58OZq3HGQo5Eev1CiJzRcOcDbLqSmXYZKs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602189106; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NNOqED1OTgtVa+7GfujHrZJ0p5BpKzArXu8F733th+c=; b=alh0KjouHM0uSsjsC1WzRv2V5jvLChvu9Dj79k4+Nb0dRY9QFakdJngM3u6j5AAND7NmyFDxFtd21Vgyspy8L0/W9VNnvWsN32jkicAmSP9iNo8G1RR99QImIWC8ErWjhyjwdTJdkSlUmQQuE9k6AoZEigddpSFTh+bJHhZoHoQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602189106459963.1261180711311; Thu, 8 Oct 2020 13:31:46 -0700 (PDT) Received: from localhost ([::1]:34540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQcZk-0006bm-JE for importer@patchew.org; Thu, 08 Oct 2020 16:31:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQcVh-0003IX-Lb for qemu-devel@nongnu.org; Thu, 08 Oct 2020 16:27:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32195) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQcVf-0005un-TW for qemu-devel@nongnu.org; Thu, 08 Oct 2020 16:27:33 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-crnV9F94NcOw8SHubKmc_w-1; Thu, 08 Oct 2020 16:27:27 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1A8A57037; Thu, 8 Oct 2020 20:27:26 +0000 (UTC) Received: from localhost (ovpn-119-102.rdu2.redhat.com [10.10.119.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4D545D9E8; Thu, 8 Oct 2020 20:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602188850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NNOqED1OTgtVa+7GfujHrZJ0p5BpKzArXu8F733th+c=; b=e8sxtgU0yxFeRDLwt5dNVpNwkVUTBWaSxXEYDW2he/J1gqyd7lY80JjsVVtAFvqyZV8NJo rSMIYij/BKz4hYm4NTf65yTlQHFZxlHRRmFbDLmsStlCm2IzgZhcmSZANpzFXAmBZ19bF8 AmAnNaL/bO0bpLChyh3OdvFgkTXLs3c= X-MC-Unique: crnV9F94NcOw8SHubKmc_w-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH 2/3] can-host-socketcan: Fix crash when 'if' option is not set Date: Thu, 8 Oct 2020 16:27:12 -0400 Message-Id: <20201008202713.1416823-3-ehabkost@redhat.com> In-Reply-To: <20201008202713.1416823-1-ehabkost@redhat.com> References: <20201008202713.1416823-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/08 01:56:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vikram Garhwal , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Jason Wang , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pavel Pisa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Fix the following crash: $ qemu-system-x86_64 -object can-host-socketcan,id=3Dobj0 Segmentation fault (core dumped) Signed-off-by: Eduardo Habkost Acked-by: Pavel Pisa Reviewed-by: Li Qiang Reviewed-by: Vikram Garhwal --- Cc: Pavel Pisa Cc: Vikram Garhwal Cc: Jason Wang Cc: qemu-devel@nongnu.org --- net/can/can_socketcan.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c index 92b1f79385..4b68f60c6b 100644 --- a/net/can/can_socketcan.c +++ b/net/can/can_socketcan.c @@ -194,6 +194,11 @@ static void can_host_socketcan_connect(CanHostState *c= h, Error **errp) struct sockaddr_can addr; struct ifreq ifr; =20 + if (!c->ifname) { + error_setg(errp, "'if' property not set"); + return; + } + /* open socket */ s =3D qemu_socket(PF_CAN, SOCK_RAW, CAN_RAW); if (s < 0) { --=20 2.26.2 From nobody Sun Nov 16 23:03:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602189152; cv=none; d=zohomail.com; s=zohoarc; b=RKwsbV3vqEkizJbZmL9C7T3aYm1sks3mT5Jp3JrreGk0biW/KSiti9o15qxmp0slsXuDzs6T0Q+wO0xNEnZ8I19PbmpKSjAcP16BJmdUDd3c4xCQOLaKhA7w7F4RvL24yXDhvnE5aa0Hs3ctdcdOKcTX8baiA5Tbf3IPgote3dI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602189152; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+55CXXawNYtb20ChkObbYkrCRkauAWIFrii7iUH14No=; b=oFvEQeUFmzjOAVWLuc3YxrVewWIDZEI5cV49BcXYUEC3fN4VOE+o+fDrb0cAnkHYDGGKNlMycD5/N+/0+Aujes+GewIqngqOr0HhTqPvavk88MwugtqYxwYFFs3GT8pjIv3hF6F9zJPEQrN+zkH3IUMpJ6PNTBcWI0SgYqeSWRQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602189152197209.5821906357187; Thu, 8 Oct 2020 13:32:32 -0700 (PDT) Received: from localhost ([::1]:36918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQcaV-0007gJ-1a for importer@patchew.org; Thu, 08 Oct 2020 16:32:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQcVn-0003VO-LJ for qemu-devel@nongnu.org; Thu, 08 Oct 2020 16:27:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20094) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQcVl-0005wG-RM for qemu-devel@nongnu.org; Thu, 08 Oct 2020 16:27:39 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-bxDHFsg0PI2HMb21oynwlQ-1; Thu, 08 Oct 2020 16:27:31 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6EE218A8230; Thu, 8 Oct 2020 20:27:30 +0000 (UTC) Received: from localhost (ovpn-119-102.rdu2.redhat.com [10.10.119.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id E6D0D6EF4F; Thu, 8 Oct 2020 20:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602188857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+55CXXawNYtb20ChkObbYkrCRkauAWIFrii7iUH14No=; b=R7PR2twpfBHA1/bZfd983vj9at/sTCyS6CW/DWKOsA04z4nrCmijEtVz1Np+0u+bKJF3z4 AXVB2YED6S4Ok6RmsNkktm+hOBUtA976CYaL3BdKTotK4+aQAEAbrEMvlsVUgpX9F/WtSC tlX9t7Aiz8TAakZ+4w6VJcmZP3Yjc9s= X-MC-Unique: bxDHFsg0PI2HMb21oynwlQ-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH 3/3] tests/acceptance: Test case for detecting -object crashes Date: Thu, 8 Oct 2020 16:27:13 -0400 Message-Id: <20201008202713.1416823-4-ehabkost@redhat.com> In-Reply-To: <20201008202713.1416823-1-ehabkost@redhat.com> References: <20201008202713.1416823-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/08 02:56:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vikram Garhwal , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Jason Wang , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pavel Pisa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Add a simple test case that will run QEMU directly (without QMP) just to check for crashes when using `-object`. Signed-off-by: Eduardo Habkost --- Cc: Cleber Rosa Cc: "Philippe Mathieu-Daud=C3=A9" Cc: Wainer dos Santos Moschetta Cc: qemu-devel@nongnu.org --- tests/acceptance/object_option.py | 49 +++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 tests/acceptance/object_option.py diff --git a/tests/acceptance/object_option.py b/tests/acceptance/object_op= tion.py new file mode 100644 index 0000000000..2b8bd00db1 --- /dev/null +++ b/tests/acceptance/object_option.py @@ -0,0 +1,49 @@ +# Copyright (c) 2020 Red Hat, Inc. +# +# Author: +# Eduardo Habkost +# +# This work is licensed under the terms of the GNU GPL, version 2 or +# later. See the COPYING file in the top-level directory. + +import avocado_qemu +import subprocess +import shlex + +class ObjectOption(avocado_qemu.Test): + """Check if ``-object`` option behaves as expected""" + + def run(self, cmd, *args, **kwargs): + cmdstr =3D ' '.join(shlex.quote(c) for c in cmd) + self.log.info("Command: %s", cmdstr) + return subprocess.run(cmd, encoding=3D'utf-8', *args, **kwargs) + + def devices(self): + out =3D self.run([self.qemu_bin, '-object', 'help'], + check=3DTrue, stdout=3Dsubprocess.PIPE).stdout + lines =3D out.split('\n') + return [l.strip() for l in lines[1:] if l.strip()] + + def test_help(self): + """Check if ``-object ...,help`` behaves as expected""" + for device in self.devices(): + self.run([self.qemu_bin, '-object', '%s,help' % (device)], + check=3DTrue, + stdout=3Dsubprocess.DEVNULL) + + def test_crash(self): + """Check for crashes when using ``-object ...``""" + for device in self.devices(): + r =3D self.run([self.qemu_bin, '-object', + '%s,id=3Dobj0' % (device), + '-monitor', 'stdio'], + input=3D'quit\n', + stdout=3Dsubprocess.DEVNULL, + stderr=3Dsubprocess.PIPE) + if r.returncode not in (0, 1): + self.log.warn("QEMU stderr: %s", r.stderr) + self.log.warn("QEMU exit code: %d", r.returncode) + if r.returncode < 0: + self.fail("QEMU crashed") + else: + self.fail("Unexpected exit code") --=20 2.26.2