From nobody Sun Oct 5 17:38:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602183760; cv=none; d=zohomail.com; s=zohoarc; b=blRwdxd6yKl99DRh2rfdojO+eBkVWjcsXSaJyFD8uu7rbbQRzsoxlUsYaB9K6KT7atNNN4g5oKd0TFwu3Bo+1/6wTNzx3Jeb5QtkGrfGrAQDd1TOon1ybZdLPkvk7fDlguCqOdS3GuOHULha+If9/d+kOgCD9I3VcsL8u83OJzA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602183760; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rMbqo0xt+T/OQzwlre+9lBBzOy3KdXiaGhZEG3FlEfc=; b=KaXWc8J+OmYk6m8SP2M+9a1pdyy6gB5jJHAMAWgvjrbH1xzffRVVKqelJQdvdfd8tKz8jJ1Twvynp3QVqxG06+9Kvbd73lhaCc9aMp/TOF83edvRUmGH19Ik9yUaXz1GHJ2erZwZZRZBTK2KigvgBBdt2XcM553uCZsBfaIoslw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602183760739799.3504079316118; Thu, 8 Oct 2020 12:02:40 -0700 (PDT) Received: from localhost ([::1]:45410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQbBX-0001GF-Al for importer@patchew.org; Thu, 08 Oct 2020 15:02:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQb92-0007sa-Bm for qemu-devel@nongnu.org; Thu, 08 Oct 2020 15:00:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45975) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQb8y-0003eh-Q9 for qemu-devel@nongnu.org; Thu, 08 Oct 2020 15:00:03 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-DV8XQzGrMcikI7NI_t6FGQ-1; Thu, 08 Oct 2020 14:59:56 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0C131018F83; Thu, 8 Oct 2020 18:59:54 +0000 (UTC) Received: from blue.redhat.com (ovpn-113-14.phx2.redhat.com [10.3.113.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5FA0A5D9E8; Thu, 8 Oct 2020 18:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602183600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rMbqo0xt+T/OQzwlre+9lBBzOy3KdXiaGhZEG3FlEfc=; b=GOlWO45AinmphwLyCb+3Ii2AnZoJwgJT7RJoZ6FJPLdZVGonLZXVbtX8WrKh5OJdurUL1r CcQhGrj+FJH1qcZioSF5XyvswJuZiaW69p+mEyT0+l/s/fwcIKkDh4YW1Cot93RIXn2+nV Ij82l4gM6/QDkT+VfQ7ml9/QebZAVVA= X-MC-Unique: DV8XQzGrMcikI7NI_t6FGQ-1 From: Eric Blake To: qemu-devel@nongnu.org Subject: [PULL 1/8] nbd: silence maybe-uninitialized warnings Date: Thu, 8 Oct 2020 13:59:44 -0500 Message-Id: <20201008185951.1026052-2-eblake@redhat.com> In-Reply-To: <20201008185951.1026052-1-eblake@redhat.com> References: <20201008185951.1026052-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/08 02:56:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , "open list:Network Block Dev..." Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Christian Borntraeger gcc 10 from Fedora 32 gives me: Compiling C object libblock.fa.p/nbd_server.c.o ../nbd/server.c: In function =E2=80=98nbd_co_client_start=E2=80=99: ../nbd/server.c:625:14: error: =E2=80=98namelen=E2=80=99 may be used uninit= ialized in this function [-Werror=3Dmaybe-uninitialized] 625 | rc =3D nbd_negotiate_send_info(client, NBD_INFO_NAME, namel= en, name, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~ 626 | errp); | ~~~~~ ../nbd/server.c:564:14: note: =E2=80=98namelen=E2=80=99 was declared here 564 | uint32_t namelen; | ^~~~~~~ cc1: all warnings being treated as errors As I cannot see how this can happen, let uns silence the warning. Signed-off-by: Christian Borntraeger Message-Id: <20200930155859.303148-3-borntraeger@de.ibm.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake --- nbd/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/server.c b/nbd/server.c index f74766add7b7..f25cffa334fa 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -556,7 +556,7 @@ static int nbd_negotiate_handle_info(NBDClient *client,= Error **errp) NBDExport *exp; uint16_t requests; uint16_t request; - uint32_t namelen; + uint32_t namelen =3D 0; bool sendname =3D false; bool blocksize =3D false; uint32_t sizes[3]; --=20 2.28.0