From nobody Wed May 15 22:17:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602091873; cv=none; d=zohomail.com; s=zohoarc; b=awZ9+28c+lNmAzHEtXbNB3aefQlNeJPTRlN6Aecr0D4FxB2R4YUbO4Bu7VCMFea86C6x5YSfDsjIj2qnMZjQSVlgELMZBhNM88ESH/SN138qKb22/HLJvR8/E2lMWFMkFMV438Vv7NOsw9jVgei4S3mnNknqOX/yhzzHiJPR3bo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602091873; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dfy/YADIKVcZjL8rRBgnq8l2LIPnOgr/q3i/W+Gmr0E=; b=JMQdCRoM67vqfm8w6C1fK9uhM3E2d79LlP1pRUD6510cRQi2KOtbtHFn5AO9bPpo8LfKj0SjcXWk3uMpB9QK/MEDud2Rp1J0uuAr3CkGIQduSVGR4erZ4Kd6iPuFoWhwxCPpgRKH7KpTA6plk18U4Fcl7L7lmp+4Lom/Pq6qHmY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16020918735931005.9662343253; Wed, 7 Oct 2020 10:31:13 -0700 (PDT) Received: from localhost ([::1]:51950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQDHU-0007y0-AT for importer@patchew.org; Wed, 07 Oct 2020 13:31:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQDFP-0005x2-86; Wed, 07 Oct 2020 13:29:03 -0400 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]:42315) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQDFN-000079-GK; Wed, 07 Oct 2020 13:29:02 -0400 Received: by mail-qk1-x731.google.com with SMTP id v123so3732401qkd.9; Wed, 07 Oct 2020 10:29:00 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:5a9b:54fc:df2a:8a5e:989b]) by smtp.gmail.com with ESMTPSA id e39sm2080117qtk.32.2020.10.07.10.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 10:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dfy/YADIKVcZjL8rRBgnq8l2LIPnOgr/q3i/W+Gmr0E=; b=UR91BPCrOEO5XEt0US02Z+mm7v7/UyBDGshDccn0Sc0dMAABok6O8R7jPcrIFBDI+m j9CcRr6vM7aGqBQpspDc+Mp9SANxkiVBW/JeVm7r9jbWw81jtdNjIrzKMwtZQrG/e9sr U+Zc9zUz3te1JLRS8BnnycGzVgF6pOjrN2KnjEF9irOK7tEFpkh911ASB/haYYsaZY3D m+cx/vtmjHZsvlp2KQgPI1RBu1N7GZVhyZdQugcGXDnLhe9a2NJlK2N+2Txls1XzgOkb 1EQjQvoiSVvXgP7fi7kY/5eE+eTkB9bBFIw8ay33c6V4IvQoCyH3rWcmAYWxgALCfQIq iR1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dfy/YADIKVcZjL8rRBgnq8l2LIPnOgr/q3i/W+Gmr0E=; b=uMkEIuwUm5MT4J1f1w6B+HFWEK500cTWsQZioHXiCVPcnTjxG47IdK/yiRGF0tWrFg /OWuAYzlSe4ThUF8iB57CDdMittFSSMc58btcvFUBU92NOBTeuUSaMpNKKPiV8wErGDO jJLwoYpyWtr0mHq1Qbj5zAHm6qod9xvQ+LmKfd9ybw0OEX/DxNJpYY2lVl8CyBu0J6eK kqCObav+X7M6BqwyJziwAho1Mah9h3fwvqMVYhjkmkx0AKWAumnDjLHr7msOP5AKKAem cqmOiBfI5/iQjsqOzawgTGf0ysl+9DBdK0BzL5GMtkewbFO0+x5qDK7ol3g8NbSDhRz5 yMFA== X-Gm-Message-State: AOAM5307Yn9HDWj4f+0mubEuG0b4/bu4/wo42dS1BwDYWiH3gSLkJpuZ o8wE/Y6l6jpAQxRqR3GFpZENit4DWgTzJw== X-Google-Smtp-Source: ABdhPJyhm/64t2T7/On1W0KW3As/H/OeniK5eeHLHEGpRYOzh94OfLKjpNTPNJp32l3cemElLLnV6w== X-Received: by 2002:a37:a1cd:: with SMTP id k196mr3864858qke.409.1602091739870; Wed, 07 Oct 2020 10:28:59 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v4 1/5] spapr: add spapr_machine_using_legacy_numa() helper Date: Wed, 7 Oct 2020 14:28:45 -0300 Message-Id: <20201007172849.302240-2-danielhb413@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201007172849.302240-1-danielhb413@gmail.com> References: <20201007172849.302240-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::731; envelope-from=danielhb413@gmail.com; helo=mail-qk1-x731.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, Greg Kurz , david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The changes to come to NUMA support are all guest visible. In theory we could just create a new 5_1 class option flag to avoid the changes to cascade to 5.1 and under. The reality is that these changes are only relevant if the machine has more than one NUMA node. There is no need to change guest behavior that has been around for years needlesly. This new helper will be used by the next patches to determine whether we should retain the (soon to be) legacy NUMA behavior in the pSeries machine. The new behavior will only be exposed if: - machine is pseries-5.2 and newer; - more than one NUMA node is declared in NUMA state. Reviewed-by: Greg Kurz Reviewed-by: David Gibson Signed-off-by: Daniel Henrique Barboza --- hw/ppc/spapr.c | 12 ++++++++++++ include/hw/ppc/spapr.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 4256794f3b..63315f2d0f 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -294,6 +294,15 @@ static hwaddr spapr_node0_size(MachineState *machine) return machine->ram_size; } =20 +bool spapr_machine_using_legacy_numa(SpaprMachineState *spapr) +{ + MachineState *machine =3D MACHINE(spapr); + SpaprMachineClass *smc =3D SPAPR_MACHINE_GET_CLASS(machine); + + return smc->pre_5_2_numa_associativity || + machine->numa_state->num_nodes <=3D 1; +} + static void add_str(GString *s, const gchar *s1) { g_string_append_len(s, s1, strlen(s1) + 1); @@ -4519,8 +4528,11 @@ DEFINE_SPAPR_MACHINE(5_2, "5.2", true); */ static void spapr_machine_5_1_class_options(MachineClass *mc) { + SpaprMachineClass *smc =3D SPAPR_MACHINE_CLASS(mc); + spapr_machine_5_2_class_options(mc); compat_props_add(mc->compat_props, hw_compat_5_1, hw_compat_5_1_len); + smc->pre_5_2_numa_associativity =3D true; } =20 DEFINE_SPAPR_MACHINE(5_1, "5.1", false); diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h index bba8736269..bb47896f17 100644 --- a/include/hw/ppc/spapr.h +++ b/include/hw/ppc/spapr.h @@ -138,6 +138,7 @@ struct SpaprMachineClass { bool smp_threads_vsmt; /* set VSMT to smp_threads by default */ hwaddr rma_limit; /* clamp the RMA to this size */ bool pre_5_1_assoc_refpoints; + bool pre_5_2_numa_associativity; =20 void (*phb_placement)(SpaprMachineState *spapr, uint32_t index, uint64_t *buid, hwaddr *pio,=20 @@ -853,6 +854,7 @@ int spapr_max_server_number(SpaprMachineState *spapr); void spapr_store_hpte(PowerPCCPU *cpu, hwaddr ptex, uint64_t pte0, uint64_t pte1); void spapr_mce_req_event(PowerPCCPU *cpu, bool recovered); +bool spapr_machine_using_legacy_numa(SpaprMachineState *spapr); =20 /* DRC callbacks. */ void spapr_core_release(DeviceState *dev); --=20 2.26.2 From nobody Wed May 15 22:17:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602091888; cv=none; d=zohomail.com; s=zohoarc; b=NN+/lpDFwZy3hz+2+KC9nzUsx/wKdj63q1QCNhav05bLhH+WJK5TY+k6u3dXf5iD8G+Foh1YrdyVX2oXuSYD9js8qfSDW5TzQj6JpW5eVsuGBSxk9a6buw2/2O00opXiShwI3PByQhHOGmTvxIDcaFXXDdvN5vHorjVkWYHMA2s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602091888; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=R4x7UXQx3o9BKP7QdPkixkdBnA0FbHUH8NO4L6FHy/8=; b=VyC6Cibm4c4Awf1GBuk1mX8BDtyRRCdNprB/jHkkZz1qn/EYd6R5Gtyv80JwzWyJZpOWfjfs3AFGs2K134F49DiYTq1TVUJVeZX7BKn/+hLeDPKv80jWU1I3mLmgQ1ZCRAM8GWBFrr+S0oya7pM17i1sLR/eigY+T3XUK5FaAkg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602091888227829.4756727668877; Wed, 7 Oct 2020 10:31:28 -0700 (PDT) Received: from localhost ([::1]:53308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQDHi-000082-SY for importer@patchew.org; Wed, 07 Oct 2020 13:31:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQDFQ-00060M-WC; Wed, 07 Oct 2020 13:29:05 -0400 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]:41515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQDFP-00007Z-6P; Wed, 07 Oct 2020 13:29:04 -0400 Received: by mail-qk1-x742.google.com with SMTP id b69so3735591qkg.8; Wed, 07 Oct 2020 10:29:02 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:5a9b:54fc:df2a:8a5e:989b]) by smtp.gmail.com with ESMTPSA id e39sm2080117qtk.32.2020.10.07.10.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 10:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R4x7UXQx3o9BKP7QdPkixkdBnA0FbHUH8NO4L6FHy/8=; b=XWqqo/8da/pbFHfzh1iZKrT3bLl8cxBgfu4zDkq/Ja0FQKNd9WH6yNJ1pTApcAJG9b N7ngGEEgs1IqQnSAMbeQA6GTuU8+ZIuCzQg7AZ5nRmpwpoaDZJMXlqQJx2nHmBOfFdK3 AnmfJ9/vi66F6PSi5tOx/cPEZBTysq6C+8jep1QBvY969BZkKzuaaCC7RlSjq8TomEHs 7Sys0eAsy/iIU0pPOO7TX0L5zOm4l/gKYEM0Uq5+OpoQtiVGsMknzKh7ZiGAfbPbnzNs 0u/CvD8uf+2YBE360qIT+ICAI1ONxoE0L+hZ12j83rrbl2fPhwZ1+FQNJipMKAl9sL0C 4sWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R4x7UXQx3o9BKP7QdPkixkdBnA0FbHUH8NO4L6FHy/8=; b=d70ybMCzwe9+7Xx7ByjyaJdNi4k21tMLrvRA543otN/CcfJgolpbgleNSbzYrpncSA TnhKW6mi9+cZ4Kg0hvjxTyIVhqUyoi2N94COdeezgPbtIpdcX/Hjt1aq73643MWWxi6y OdrGND+Mx5DKVoPlVYleUxMNMA7ZSM6dnr8/4m664wuOUa0yN0HD8wxZqatFC5pcptvU v71omqfvxV9sG13JI1fcUf/OrZk0Yrwql+UTZlFscvwQUcaNfqaH5Yu4oRaLcbbialmj viwjh0nI0RG67d6nB1jdafFBS22G8kiBz3k6BE4BqcxWAytfd+ltBOv/ufK0XCc3FaIm ZatA== X-Gm-Message-State: AOAM5323yZjCpBxSESkVT6rtUvVS72dJdv+GxRF9YMf4CTDES/HrfSEl uESLz4rY7X3GtvR4Ll83qUxB6iew/AMPDQ== X-Google-Smtp-Source: ABdhPJw315qM/00DWZJ6RZ8orJxW5RZckmIUM4lA0UWxw3NLD/JhQ3f6ffK2KR3q1qXVAb6pUqBycQ== X-Received: by 2002:a37:b285:: with SMTP id b127mr3811451qkf.323.1602091741626; Wed, 07 Oct 2020 10:29:01 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v4 2/5] spapr_numa: forbid asymmetrical NUMA setups Date: Wed, 7 Oct 2020 14:28:46 -0300 Message-Id: <20201007172849.302240-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201007172849.302240-1-danielhb413@gmail.com> References: <20201007172849.302240-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::742; envelope-from=danielhb413@gmail.com; helo=mail-qk1-x742.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, Greg Kurz , david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The pSeries machine does not support asymmetrical NUMA configurations. This doesn't make much of a different since we're not using user input for pSeries NUMA setup, but this will change in the next patches. To avoid breaking existing setups, gate this change by checking for legacy NUMA support. Reviewed-by: Greg Kurz Reviewed-by: David Gibson Signed-off-by: Daniel Henrique Barboza --- hw/ppc/spapr_numa.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/hw/ppc/spapr_numa.c b/hw/ppc/spapr_numa.c index 64fe567f5d..fe395e80a3 100644 --- a/hw/ppc/spapr_numa.c +++ b/hw/ppc/spapr_numa.c @@ -19,6 +19,24 @@ /* Moved from hw/ppc/spapr_pci_nvlink2.c */ #define SPAPR_GPU_NUMA_ID (cpu_to_be32(1)) =20 +static bool spapr_numa_is_symmetrical(MachineState *ms) +{ + int src, dst; + int nb_numa_nodes =3D ms->numa_state->num_nodes; + NodeInfo *numa_info =3D ms->numa_state->nodes; + + for (src =3D 0; src < nb_numa_nodes; src++) { + for (dst =3D src; dst < nb_numa_nodes; dst++) { + if (numa_info[src].distance[dst] !=3D + numa_info[dst].distance[src]) { + return false; + } + } + } + + return true; +} + void spapr_numa_associativity_init(SpaprMachineState *spapr, MachineState *machine) { @@ -61,6 +79,22 @@ void spapr_numa_associativity_init(SpaprMachineState *sp= apr, =20 spapr->numa_assoc_array[i][MAX_DISTANCE_REF_POINTS] =3D cpu_to_be3= 2(i); } + + /* + * Legacy NUMA guests (pseries-5.1 and older, or guests with only + * 1 NUMA node) will not benefit from anything we're going to do + * after this point. + */ + if (spapr_machine_using_legacy_numa(spapr)) { + return; + } + + if (!spapr_numa_is_symmetrical(machine)) { + error_report("Asymmetrical NUMA topologies aren't supported " + "in the pSeries machine"); + exit(EXIT_FAILURE); + } + } =20 void spapr_numa_write_associativity_dt(SpaprMachineState *spapr, void *fdt, --=20 2.26.2 From nobody Wed May 15 22:17:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602091920; cv=none; d=zohomail.com; s=zohoarc; b=efbdAefdQGLZW0EFs8ouEdWnN3j3Oy8+ra1kLq0p0wc1Ckgs8HC0ljUSkAX/Lcb/hH+20pyJvSx+kKH4+ft6eN+BUlsuy+AAcmRaRI2XM2TWk4+ms3BG8HMO72XYsBOH25jaWiSDuv7nCc1OkY47fbqwX3hSRx3vwzmoBkwff7A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602091920; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lpsGtZ60cFvA7qd3INWQF05K0q47LnadRWDRZid09OA=; b=D0zFeFVWXX5kxlS5gMzgbGGxyuD4DO4heoRG95y5XtIPpZqi+57WeOZjfs7HtNCoBKxNqz+PQzaifCvjnRds6q3akFzUMy4iRBdkm0bdUyI3xvb3pRoMmAXT2qDoyJXS0RafNyBrtYljvKlkbjGmF3Z3jUHlIDAyrwDvkXQiEgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602091920741302.18852639201646; Wed, 7 Oct 2020 10:32:00 -0700 (PDT) Received: from localhost ([::1]:55096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQDIF-0000v7-Hk for importer@patchew.org; Wed, 07 Oct 2020 13:31:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQDFT-00064d-3b; Wed, 07 Oct 2020 13:29:10 -0400 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]:41517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQDFR-00007t-2e; Wed, 07 Oct 2020 13:29:06 -0400 Received: by mail-qk1-x743.google.com with SMTP id b69so3735746qkg.8; Wed, 07 Oct 2020 10:29:04 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:5a9b:54fc:df2a:8a5e:989b]) by smtp.gmail.com with ESMTPSA id e39sm2080117qtk.32.2020.10.07.10.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 10:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lpsGtZ60cFvA7qd3INWQF05K0q47LnadRWDRZid09OA=; b=c8ffZQR5F/tNv6y4AIs0q8JpuAeIjTTM8CyPfjDFpEneASmdq7Lv+9Ctrq/EIr/d5Y lv4vv5grGjt9lb1F27EIGVcIYHbQXLAhHxsB2MOw2LAmZIZQRdwO1PtgeHEfqS6wKkid oZu2RoWWgQKoEDa8VK3ulvUXNEkuy++4Dv+tvor4ulXRXtj2DNNo/AjFLpRnT4BaMZEH HWSb834vCqjgicxR7/YzPFVVbnw6tN6CRLSP3gh5FHItNARFKMK6OZr1JFd7VBH+HO5L Kau3PghRXAPCixiWzVw+Xx/POSLVERQVywKPPAT6s5I+uqNpcB0u9pvmvPHEaSJYbSt/ R3iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lpsGtZ60cFvA7qd3INWQF05K0q47LnadRWDRZid09OA=; b=mee1tN9/DjQnu2EAh9uczuTSipJwFq7z4HpyGn0K9pCCrFP8wrfY5TLvfzY0P/j9cE JZJJBDVDRmsbWgDq2XS9whhqJTIZRinXLq5ObpzDaIQ6YKrihmTIv9foxI4AS9bUXufB GvEAigICfFRU6OUD7/yPCE4NzJwlu4P4eC8B39ki08sY3qN9jbXzBwgGnAN1FkjAoIzb zqDl8zWeXqszbFfN2rrMwe09KSFLZEo52N9t6sjq68zLRgMVUstZFfGbGI7QhH/2tk6B up5nGqdr8Rpqn9xHiOM/UblJtjEdhk6QojLHrY1F3aHgifDXMCsbDNwyQ6acmP5JeKCU a3kw== X-Gm-Message-State: AOAM532piwWrq7w4gOnGpTMVN6e+qhgUk3KiZeSE+E7VC9IVYv75cdYv y+YxJOD4d4+WRkp2gBNVWMBHPTeAcZ9IYg== X-Google-Smtp-Source: ABdhPJzx3ij93kvLZoxbTbO4Wbzyh2kaav/ytc+FDEOc1O3zbCFFiHkP0lcZK2p4oju/D/pxj9ogGg== X-Received: by 2002:a37:d41:: with SMTP id 62mr3840323qkn.444.1602091743437; Wed, 07 Oct 2020 10:29:03 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v4 3/5] spapr_numa: change reference-points and maxdomain settings Date: Wed, 7 Oct 2020 14:28:47 -0300 Message-Id: <20201007172849.302240-4-danielhb413@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201007172849.302240-1-danielhb413@gmail.com> References: <20201007172849.302240-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::743; envelope-from=danielhb413@gmail.com; helo=mail-qk1-x743.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, Greg Kurz , david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This is the first guest visible change introduced in spapr_numa.c. The previous settings of both reference-points and maxdomains were too restrictive, but enough for the existing associativity we're setting in the resources. We'll change that in the following patches, populating the associativity arrays based on user input. For those changes to be effective, reference-points and maxdomains must be more flexible. After this patch, we'll have 4 distinct levels of NUMA (0x4, 0x3, 0x2, 0x1) and maxdomains will allow for any type of configuration the user intends to do - under the scope and limitations of PAPR itself, of course. Reviewed-by: Greg Kurz Reviewed-by: David Gibson Signed-off-by: Daniel Henrique Barboza --- hw/ppc/spapr_numa.c | 43 +++++++++++++++++++++++++++++++++++-------- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/hw/ppc/spapr_numa.c b/hw/ppc/spapr_numa.c index fe395e80a3..16badb1f4b 100644 --- a/hw/ppc/spapr_numa.c +++ b/hw/ppc/spapr_numa.c @@ -178,24 +178,51 @@ int spapr_numa_write_assoc_lookup_arrays(SpaprMachine= State *spapr, void *fdt, */ void spapr_numa_write_rtas_dt(SpaprMachineState *spapr, void *fdt, int rta= s) { + MachineState *ms =3D MACHINE(spapr); SpaprMachineClass *smc =3D SPAPR_MACHINE_GET_CLASS(spapr); uint32_t refpoints[] =3D { cpu_to_be32(0x4), - cpu_to_be32(0x4), + cpu_to_be32(0x3), cpu_to_be32(0x2), + cpu_to_be32(0x1), }; uint32_t nr_refpoints =3D ARRAY_SIZE(refpoints); - uint32_t maxdomain =3D cpu_to_be32(spapr->gpu_numa_id > 1 ? 1 : 0); + uint32_t maxdomain =3D ms->numa_state->num_nodes + spapr->gpu_numa_id; uint32_t maxdomains[] =3D { cpu_to_be32(4), - maxdomain, - maxdomain, - maxdomain, - cpu_to_be32(spapr->gpu_numa_id), + cpu_to_be32(maxdomain), + cpu_to_be32(maxdomain), + cpu_to_be32(maxdomain), + cpu_to_be32(maxdomain) }; =20 - if (smc->pre_5_1_assoc_refpoints) { - nr_refpoints =3D 2; + if (spapr_machine_using_legacy_numa(spapr)) { + uint32_t legacy_refpoints[] =3D { + cpu_to_be32(0x4), + cpu_to_be32(0x4), + cpu_to_be32(0x2), + }; + uint32_t legacy_maxdomain =3D spapr->gpu_numa_id > 1 ? 1 : 0; + uint32_t legacy_maxdomains[] =3D { + cpu_to_be32(4), + cpu_to_be32(legacy_maxdomain), + cpu_to_be32(legacy_maxdomain), + cpu_to_be32(legacy_maxdomain), + cpu_to_be32(spapr->gpu_numa_id), + }; + + G_STATIC_ASSERT(sizeof(legacy_refpoints) <=3D sizeof(refpoints)); + G_STATIC_ASSERT(sizeof(legacy_maxdomains) <=3D sizeof(maxdomains)); + + nr_refpoints =3D 3; + + memcpy(refpoints, legacy_refpoints, sizeof(legacy_refpoints)); + memcpy(maxdomains, legacy_maxdomains, sizeof(legacy_maxdomains)); + + /* pseries-5.0 and older reference-points array is {0x4, 0x4} */ + if (smc->pre_5_1_assoc_refpoints) { + nr_refpoints =3D 2; + } } =20 _FDT(fdt_setprop(fdt, rtas, "ibm,associativity-reference-points", --=20 2.26.2 From nobody Wed May 15 22:17:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602092093; cv=none; d=zohomail.com; s=zohoarc; b=h3nADEai6/zs7dqBoJVcjELJEXCwHisS4Itsyy+oJonRdZoTISy4MPKBJS0WNDp/AFARPUoE7h8QYz1mB0uWHl9xDTwBXRhYYN//rlQgvE7o0E5DpzRH8s22Tvccj/NbC+xgYtFMb9V1NFdf+uPrrJPfnqt5a4BpEmbcnTjCjVQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602092093; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iUBW/FZN4OUPJQhsvziAh5iqbYebZLNMaGJLcZL+gkY=; b=LEUPsBiV/msaOpl8qF7glIZrnuvB/rP5QokfH8g+tTGQg+e4H4dJmkZ7PTdSoRv0k4GKSBSdfGuCgiswx9uKzxpjzF4u7r5/frlHQDrXhfID/gnP/clc3x1BfokI3gE4F2QNm8LB7M32tS6P1tzDeU2H3fMpRwbT3aqqtQuUErc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602092093756232.73745971428286; Wed, 7 Oct 2020 10:34:53 -0700 (PDT) Received: from localhost ([::1]:60256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQDL1-0003FK-Rw for importer@patchew.org; Wed, 07 Oct 2020 13:34:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQDFZ-0006AO-05; Wed, 07 Oct 2020 13:29:13 -0400 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:35355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQDFS-00008E-Sw; Wed, 07 Oct 2020 13:29:12 -0400 Received: by mail-qk1-x72e.google.com with SMTP id 140so2020316qko.2; Wed, 07 Oct 2020 10:29:06 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:5a9b:54fc:df2a:8a5e:989b]) by smtp.gmail.com with ESMTPSA id e39sm2080117qtk.32.2020.10.07.10.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 10:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iUBW/FZN4OUPJQhsvziAh5iqbYebZLNMaGJLcZL+gkY=; b=JCFsUdRZMyui0itPAOV6qRQtrtMvSRd+PfoX/QVsn98mKrro3fBZrTD3dp3PjVR+OA qiWQbvVoisX1x2kn9bFdznITkWFsFMz17xH/rmsfe7E8ezkOUan6hL399ev5a9PYuVyF BxJqHEYTY8074SYLV1tEcqCYaJB6xyM7IHNmTnpDuXjh2/92FbpJPuSHhPRF9PmqUB5c eKkw0jkcCko6spknI42d7yBm5zUFXjWhlXr0rGUEbp7N5uJlO7YCX/IIUXSHxpWOQ8s6 2iBH58Z0ika6ET/gAoKp4hFSqK29No0Z49rVzFH8DzvR7PlyP0X6U04/SSquNsaXzaWE v1ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iUBW/FZN4OUPJQhsvziAh5iqbYebZLNMaGJLcZL+gkY=; b=jeVa/6n2iEjmaDHNWUCq9jySgyOrZ2vI44V/Mpt+KuRqMaoRPhXCsyV88wvDMaUIOp Hj9XOSh3YVn7f0O6j/mYBRxCO+zfMvV8iVe9W/5tkDhWvZ0ytEK8JaE73Z+q4KryI92J MBjkCAabvVWb50/uxvepXilhs2kV4rhGr95afHClTuQvu9xe8wRQVgroHshv4hauVsIq qwkDuOhtZGlcnAhHPSKsPqucCPYjdZvuMMiYq4uSbIfwoXCShOxr02WekPoKqiEzTGC8 PF1X+vmIMg5ErU9OO2BW4hGhUs1wv8nc5FPQ+B9CIx1E2dSJJrnthdPdrmEG3C7fcDaH 8rVw== X-Gm-Message-State: AOAM533LAjxG+WhotigyEMPmk+ZJCr4t+WoLcn8MWi3IxEtIUR9cDO7r 8c3sLuqo+1z4VT+aLqAGL1xlM0EJyw2dzA== X-Google-Smtp-Source: ABdhPJz5d/x3KXsYv2PC14Hws3Jg+jDfhqJXhpXpapl2wqcQMrtpDLs5tTPT7t+x1TConPNutZUzQw== X-Received: by 2002:a37:a495:: with SMTP id n143mr3946511qke.394.1602091745040; Wed, 07 Oct 2020 10:29:05 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v4 4/5] spapr_numa: consider user input when defining associativity Date: Wed, 7 Oct 2020 14:28:48 -0300 Message-Id: <20201007172849.302240-5-danielhb413@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201007172849.302240-1-danielhb413@gmail.com> References: <20201007172849.302240-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=danielhb413@gmail.com; helo=mail-qk1-x72e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" A new function called spapr_numa_define_associativity_domains() is created to calculate the associativity domains and change the associativity arrays considering user input. This is how the associativity domain between two NUMA nodes A and B is calculated: - get the distance D between them - get the correspondent NUMA level 'n_level' for D. This is done via a helper called spapr_numa_get_numa_level() - all associativity arrays were initialized with their own numa_ids, and we're calculating the distance in node_id ascending order, starting from node id 0 (the first node retrieved by numa_state). This will have a cascade effect in the algorithm because the associativity domains that node 0 defines will be carried over to other nodes, and node 1 associativities will be carried over after taking node 0 associativities into account, and so on. This happens because we'll assign assoc_src as the associativity domain of dst as well, for all NUMA levels beyond and including n_level. The PPC kernel expects the associativity domains of the first node (node id 0) to be always 0 [1], and this algorithm will grant that by default. Ultimately, all of this results in a best effort approximation for the actual NUMA distances the user input in the command line. Given the nature of how PAPR itself interprets NUMA distances versus the expectations risen by how ACPI SLIT works, there might be better algorithms but, in the end, it'll also result in another way to approximate what the user really wanted. To keep this commit message no longer than it already is, the next patch will update the existing documentation in ppc-spapr-numa.rst with more in depth details and design considerations/drawbacks. [1] https://lore.kernel.org/linuxppc-dev/5e8fbea3-8faf-0951-172a-b41a2138fb= cf@gmail.com/ Signed-off-by: Daniel Henrique Barboza --- capstone | 2 +- hw/ppc/spapr_numa.c | 110 +++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 110 insertions(+), 2 deletions(-) diff --git a/capstone b/capstone index f8b1b83301..22ead3e0bf 160000 --- a/capstone +++ b/capstone @@ -1 +1 @@ -Subproject commit f8b1b833015a4ae47110ed068e0deb7106ced66d +Subproject commit 22ead3e0bfdb87516656453336160e0a37b066bf diff --git a/hw/ppc/spapr_numa.c b/hw/ppc/spapr_numa.c index 16badb1f4b..b50796bbe3 100644 --- a/hw/ppc/spapr_numa.c +++ b/hw/ppc/spapr_numa.c @@ -37,12 +37,108 @@ static bool spapr_numa_is_symmetrical(MachineState *ms) return true; } =20 +/* + * This function will translate the user distances into + * what the kernel understand as possible values: 10 + * (local distance), 20, 40, 80 and 160, and return the equivalent + * NUMA level for each. Current heuristic is: + * - local distance (10) returns numa_level =3D 0x4, meaning there is + * no rounding for local distance + * - distances between 11 and 30 inclusive -> rounded to 20, + * numa_level =3D 0x3 + * - distances between 31 and 60 inclusive -> rounded to 40, + * numa_level =3D 0x2 + * - distances between 61 and 120 inclusive -> rounded to 80, + * numa_level =3D 0x1 + * - everything above 120 returns numa_level =3D 0 to indicate that + * there is no match. This will be calculated as disntace =3D 160 + * by the kernel (as of v5.9) + */ +static uint8_t spapr_numa_get_numa_level(uint8_t distance) +{ + if (distance =3D=3D 10) { + return 0x4; + } else if (distance > 11 && distance <=3D 30) { + return 0x3; + } else if (distance > 31 && distance <=3D 60) { + return 0x2; + } else if (distance > 61 && distance <=3D 120) { + return 0x1; + } + + return 0; +} + +static void spapr_numa_define_associativity_domains(SpaprMachineState *spa= pr) +{ + MachineState *ms =3D MACHINE(spapr); + NodeInfo *numa_info =3D ms->numa_state->nodes; + int nb_numa_nodes =3D ms->numa_state->num_nodes; + int src, dst, i; + + for (src =3D 0; src < nb_numa_nodes; src++) { + for (dst =3D src; dst < nb_numa_nodes; dst++) { + /* + * This is how the associativity domain between A and B + * is calculated: + * + * - get the distance D between them + * - get the correspondent NUMA level 'n_level' for D + * - all associativity arrays were initialized with their own + * numa_ids, and we're calculating the distance in node_id + * ascending order, starting from node id 0 (the first node + * retrieved by numa_state). This will have a cascade effect in + * the algorithm because the associativity domains that node 0 + * defines will be carried over to other nodes, and node 1 + * associativities will be carried over after taking node 0 + * associativities into account, and so on. This happens becau= se + * we'll assign assoc_src as the associativity domain of dst + * as well, for all NUMA levels beyond and including n_level. + * + * The PPC kernel expects the associativity domains of node 0 = to + * be always 0, and this algorithm will grant that by default. + */ + uint8_t distance =3D numa_info[src].distance[dst]; + uint8_t n_level =3D spapr_numa_get_numa_level(distance); + uint32_t assoc_src; + + /* + * n_level =3D 0 means that the distance is greater than our l= ast + * rounded value (120). In this case there is no NUMA level ma= tch + * between src and dst and we can skip the remaining of the lo= op. + * + * The Linux kernel will assume that the distance between src = and + * dst, in this case of no match, is 10 (local distance) doubl= ed + * for each NUMA it didn't match. We have MAX_DISTANCE_REF_POI= NTS + * levels (4), so this gives us 10*2*2*2*2 =3D 160. + * + * This logic can be seen in the Linux kernel source code, as = of + * v5.9, in arch/powerpc/mm/numa.c, function __node_distance(). + */ + if (n_level =3D=3D 0) { + continue; + } + + /* + * We must assign all assoc_src to dst, starting from n_level + * and going up to 0x1. + */ + for (i =3D n_level; i > 0; i--) { + assoc_src =3D spapr->numa_assoc_array[src][i]; + spapr->numa_assoc_array[dst][i] =3D assoc_src; + } + } + } + +} + void spapr_numa_associativity_init(SpaprMachineState *spapr, MachineState *machine) { SpaprMachineClass *smc =3D SPAPR_MACHINE_GET_CLASS(spapr); int nb_numa_nodes =3D machine->numa_state->num_nodes; int i, j, max_nodes_with_gpus; + bool using_legacy_numa =3D spapr_machine_using_legacy_numa(spapr); =20 /* * For all associativity arrays: first position is the size, @@ -56,6 +152,17 @@ void spapr_numa_associativity_init(SpaprMachineState *s= papr, for (i =3D 0; i < nb_numa_nodes; i++) { spapr->numa_assoc_array[i][0] =3D cpu_to_be32(MAX_DISTANCE_REF_POI= NTS); spapr->numa_assoc_array[i][MAX_DISTANCE_REF_POINTS] =3D cpu_to_be3= 2(i); + + /* + * Fill all associativity domains of non-zero NUMA nodes with + * node_id. This is required because the default value (0) is + * considered a match with associativity domains of node 0. + */ + if (!using_legacy_numa && i !=3D 0) { + for (j =3D 1; j < MAX_DISTANCE_REF_POINTS; j++) { + spapr->numa_assoc_array[i][j] =3D cpu_to_be32(i); + } + } } =20 /* @@ -85,7 +192,7 @@ void spapr_numa_associativity_init(SpaprMachineState *sp= apr, * 1 NUMA node) will not benefit from anything we're going to do * after this point. */ - if (spapr_machine_using_legacy_numa(spapr)) { + if (using_legacy_numa) { return; } =20 @@ -95,6 +202,7 @@ void spapr_numa_associativity_init(SpaprMachineState *sp= apr, exit(EXIT_FAILURE); } =20 + spapr_numa_define_associativity_domains(spapr); } =20 void spapr_numa_write_associativity_dt(SpaprMachineState *spapr, void *fdt, --=20 2.26.2 From nobody Wed May 15 22:17:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602092116; cv=none; d=zohomail.com; s=zohoarc; b=kfboH+Mc/u2kQRbPrsRb6W+O84Jw5eEktfy8iTHVri6dhzIWtIw+6+X4WqLUYF5SoOXGHzysnjWN3LnUvJBosyb1BgRC3rmEkPOhFsXA8eWLP1I8ab2DUeN2VbOYceSwfOwLUToXhBabEsNhcPTZkSAGSqowBFDmL/a0bjUgfnI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602092116; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mX8en2ZnBA7wWFUbbt4tWBoKqKjQ0RCgoRKeKF6SAp0=; b=DPQut//sYM2noFUNwh38QegFqudYhNXfJMBbU6hG9Loreq/RaatX2xUdIT+zFP3ZexU4pcfUVHaLZ2SjxB/Y7Ze4UvLD0BNb9Otf/fwSsScBN3m49F+UeaEHfss+5Hy4Yy4U/sVv0m/HkWu3M4JY/BBL8Z9h1qnfUDv43sYeztQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1602092116235189.38025745308425; Wed, 7 Oct 2020 10:35:16 -0700 (PDT) Received: from localhost ([::1]:60654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQDLO-0003Qv-Uf for importer@patchew.org; Wed, 07 Oct 2020 13:35:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQDFZ-0006Bp-FB; Wed, 07 Oct 2020 13:29:13 -0400 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:37736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQDFX-00008U-3O; Wed, 07 Oct 2020 13:29:13 -0400 Received: by mail-qt1-x82f.google.com with SMTP id s47so2619020qth.4; Wed, 07 Oct 2020 10:29:07 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:5a9b:54fc:df2a:8a5e:989b]) by smtp.gmail.com with ESMTPSA id e39sm2080117qtk.32.2020.10.07.10.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 10:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mX8en2ZnBA7wWFUbbt4tWBoKqKjQ0RCgoRKeKF6SAp0=; b=kc9BYMHv2unyLqhz1c6kdifxDybNK1O+tLAhig9joUcPZvsGomP6j1coWVzIvert69 w/7KJjI7+G3ssIG3OLbki9wt7XgzFIgEsYo33ls/V1DbkPGDTmhbWLAlcAY5ngd9YPA3 +GhSEZlR2uDaDCEGbKrgdx+VOo/3+ArFCNLOu7WeA5CdwGI5p+8I6kykan90RardSn71 Y7oW+FJr9vqTzvbYMozV1GNZsKtJz1Aw3jW+PVqOO0Icz8YxHJZAng47CbDg40U540QR l+gDDZDSVRTR8e+GG/YswZZfKkjcG7VMHYfdRgeH2Gn6KrTsV3ChJu+rGgP8ksqcxzL0 GL3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mX8en2ZnBA7wWFUbbt4tWBoKqKjQ0RCgoRKeKF6SAp0=; b=CmRzwpU9i6+8E3C1BcBr/wHVUp4LjhbJMRCt4tvIfI1SLw/PsMnT43EVWbfURWZf7p 5/749m9FMDYWtKdm9j4wm0GaVexrpTHgcT/1j3hOHxaSN2Dh7OEz7QnKXbLBXorUF3RK PWMsxuFeCIijuorcHMuZGl6A2XxrvBji3t7q5AFICLmzueFUPEwF+NAEpjnf12p1Ut/U j21sObyzDzE4evnswvIhnY3Otl3Sbu1vi29tyHNx2vHg8namkhuTv34c9OtDqr6r5eAK QOekj46jo0E4iT4f1GCXMh6jJ4VzDk2d/fy5nUKivFCd0cNbTESzb0QrlYwoCCyBEbtu Yh2A== X-Gm-Message-State: AOAM531A4Io6VzaitGDyfhsciCjHNg2Lktohsr7uGjAapi2ADDbqMJBj rEpu3L5LdJ0NJ1FAxCjZ4lGheywN4Wxjcg== X-Google-Smtp-Source: ABdhPJyPBtO3sdMT3g4E7E575Be7ZOtF2bUlOVpoxU3v2dXQn9uVmm3EaMkDVZG6UWXtXnHGb2vazA== X-Received: by 2002:ac8:3984:: with SMTP id v4mr4395631qte.240.1602091746685; Wed, 07 Oct 2020 10:29:06 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v4 5/5] specs/ppc-spapr-numa: update with new NUMA support Date: Wed, 7 Oct 2020 14:28:49 -0300 Message-Id: <20201007172849.302240-6-danielhb413@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201007172849.302240-1-danielhb413@gmail.com> References: <20201007172849.302240-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=danielhb413@gmail.com; helo=mail-qt1-x82f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This update provides more in depth information about the choices and drawbacks of the new NUMA support for the spapr machine. Signed-off-by: Daniel Henrique Barboza --- docs/specs/ppc-spapr-numa.rst | 235 ++++++++++++++++++++++++++++++++-- 1 file changed, 227 insertions(+), 8 deletions(-) diff --git a/docs/specs/ppc-spapr-numa.rst b/docs/specs/ppc-spapr-numa.rst index e762038022..5fca2bdd8e 100644 --- a/docs/specs/ppc-spapr-numa.rst +++ b/docs/specs/ppc-spapr-numa.rst @@ -158,9 +158,235 @@ kernel tree). This results in the following distances: * resources four NUMA levels apart: 160 =20 =20 -Consequences for QEMU NUMA tuning +pseries NUMA mechanics +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Starting in QEMU 5.2, the pseries machine considers user input when settin= g NUMA +topology of the guest. The overall design is: + +* ibm,associativity-reference-points is set to {0x4, 0x3, 0x2, 0x1}, allow= ing + for 4 distinct NUMA distance values based on the NUMA levels + +* ibm,max-associativity-domains supports multiple associativity domains in= all + NUMA levels, granting user flexibility + +* ibm,associativity for all resources varies with user input + +These changes are only effective for pseries-5.2 and newer machines that a= re +created with more than one NUMA node (disconsidering NUMA nodes created by +the machine itself, e.g. NVLink 2 GPUs). The now legacy support has been +around for such a long time, with users seeing NUMA distances 10 and 40 +(and 80 if using NVLink2 GPUs), and there is no need to disrupt the +existing experience of those guests. + +To bring the user experience x86 users have when tuning up NUMA, we had +to operate under the current pseries Linux kernel logic described in +`How the pseries Linux guest calculates NUMA distances`_. The result +is that we needed to translate NUMA distance user input to pseries +Linux kernel input. + +Translating user distance to kernel distance +-------------------------------------------- + +User input for NUMA distance can vary from 10 to 254. We need to translate +that to the values that the Linux kernel operates on (10, 20, 40, 80, 160). +This is how it is being done: + +* user distance 11 to 30 will be interpreted as 20 +* user distance 31 to 60 will be interpreted as 40 +* user distance 61 to 120 will be interpreted as 80 +* user distance 121 and beyond will be interpreted as 160 +* user distance 10 stays 10 + +The reasoning behind this aproximation is to avoid any round up to the loc= al +distance (10), keeping it exclusive to the 4th NUMA level (which is still +exclusive to the node_id). All other ranges were chosen under the developer +discretion of what would be (somewhat) sensible considering the user input. +Any other strategy can be used here, but in the end the reality is that we= 'll +have to accept that a large array of values will be translated to the same +NUMA topology in the guest, e.g. this user input: + +:: + + 0 1 2 + 0 10 31 120 + 1 31 10 30 + 2 120 30 10 + +And this other user input: + +:: + + 0 1 2 + 0 10 60 61 + 1 60 10 11 + 2 61 11 10 + +Will both be translated to the same values internally: + +:: + + 0 1 2 + 0 10 40 80 + 1 40 10 20 + 2 80 20 10 + +Users are encouraged to use only the kernel values in the NUMA definition = to +avoid being taken by surprise with that the guest is actually seeing in the +topology. There are enough potential surprises that are inherent to the +associativity domain assignment process, discussed below. + + +How associativity domains are assigned +-------------------------------------- + +LOPAPR allows more than one associativity array (or 'string') per allocated +resource. This would be used to represent that the resource has multiple +connections with the board, and then the operational system, when deciding +NUMA distancing, should consider the associativity information that provid= es +the shortest distance. + +The spapr implementation does not support multiple associativity arrays per +resource, neither does the pseries Linux kernel. We'll have to represent t= he +NUMA topology using one associativity per resource, which means that choic= es +and compromises are going to be made. + +Consider the following NUMA topology entered by user input: + +:: + + 0 1 2 3 + 0 10 40 20 40 + 1 40 10 80 40 + 2 20 80 10 20 + 3 40 40 20 10 + +All the associativity arrays are initialized with NUMA id in all associati= vity +domains: + +* node 0: 0 0 0 0 +* node 1: 1 1 1 1 +* node 2: 2 2 2 2 +* node 3: 3 3 3 3 + + +Honoring just the relative distances of node 0 to every other node, we fin= d the +NUMA level matches (considering the reference points {0x4, 0x3, 0x2, 0x1})= for +each distance: + +* distance from 0 to 1 is 40 (no match at 0x4 and 0x3, will match + at 0x2) +* distance from 0 to 2 is 20 (no match at 0x4, will match at 0x3) +* distance from 0 to 3 is 40 (no match at 0x4 and 0x3, will match + at 0x2) + +We'll copy the associativity domains of node 0 to all other nodes, based on +the NUMA level matches. Between 0 and 1, a match in 0x2, we'll also copy +the domains 0x2 and 0x1 from 0 to 1 as well. This will give us: + +* node 0: 0 0 0 0 +* node 1: 0 0 1 1 + +Doing the same to node 2 and node 3, these are the associativity arrays +after considering all matches with node 0: + +* node 0: 0 0 0 0 +* node 1: 0 0 1 1 +* node 2: 0 0 0 2 +* node 3: 0 0 3 3 + +The distances related to node 0 are accounted for. For node 1, and keeping +in mind that we don't need to revisit node 0 again, the distance from +node 1 to 2 is 80, matching at 0x1, and distance from 1 to 3 is 40, +match in 0x2. Repeating the same logic of copying all domains up to +the NUMA level match: + +* node 0: 0 0 0 0 +* node 1: 1 0 1 1 +* node 2: 1 0 0 2 +* node 3: 1 0 3 3 + +In the last step we will analyze just nodes 2 and 3. The desired distance +between 2 and 3 is 20, i.e. a match in 0x3: + +* node 0: 0 0 0 0 +* node 1: 1 0 1 1 +* node 2: 1 0 0 2 +* node 3: 1 0 0 3 + + +The kernel will read these arrays and will calculate the following NUMA to= pology for +the guest: + +:: + + 0 1 2 3 + 0 10 40 20 20 + 1 40 10 40 40 + 2 20 40 10 20 + 3 20 40 20 10 + +Note that this is not what the user wanted - the desired distance between +0 and 3 is 40, we calculated it as 20. This is what the current logic and +implementation constraints of the kernel and QEMU will provide inside the +LOPAPR specification. + +Users are welcome to use this knowledge and experiment with the input to g= et +the NUMA topology they want, or as closer as they want. The important thing +is to keep expectations up to par with what we are capable of provide at t= his +moment: an approximation. + +Limitations of the implementation --------------------------------- =20 +As mentioned above, the pSeries NUMA distance logic is, in fact, a way to = approximate +user choice. The Linux kernel, and PAPR itself, does not provide QEMU with= the ways +to fully map user input to actual NUMA distance the guest will use. These = limitations +creates two notable limitations in our support: + +* Asymmetrical topologies aren't supported. We only support NUMA topologie= s where + the distance from node A to B is always the same as B to A. We do not su= pport + any A-B pair where the distance back and forth is asymmetric. For exampl= e, the + following topology isn't supported and the pSeries guest will not boot w= ith this + user input: + +:: + + 0 1 + 0 10 40 + 1 20 10 + + +* 'non-transitive' topologies will be poorly translated to the guest. This= is the + kind of topology where the distance from a node A to B is X, B to C is X= , but + the distance A to C is not X. E.g.: + +:: + + 0 1 2 3 + 0 10 20 20 40 + 1 20 10 80 40 + 2 20 80 10 20 + 3 40 40 20 10 + + In the example above, distance 0 to 2 is 20, 2 to 3 is 20, but 0 to 3 is= 40. + The kernel will always match with the shortest associativity domain poss= ible, + and we're attempting to retain the previous established relations betwee= n the + nodes. This means that a distance equal to 20 between nodes 0 and 2 and = the + same distance 20 between nodes 2 and 3 will cause the distance between 0= and 3 + to also be 20. + + +Legacy (5.1 and older) pseries NUMA mechanics +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +In short, we can summarize the NUMA distances seem in pseries Linux guests= , using +QEMU up to 5.1, as follows: + +* local distance, i.e. the distance of the resource to its own NUMA node: = 10 +* if it's a NVLink GPU device, distance: 80 +* every other resource, distance: 40 + The way the pseries Linux guest calculates NUMA distances has a direct eff= ect on what QEMU users can expect when doing NUMA tuning. As of QEMU 5.1, this= is the default ibm,associativity-reference-points being used in the pseries @@ -180,12 +406,5 @@ as far as NUMA distance goes: to the same third NUMA level, having distance =3D 40 * for NVLink GPUs, distance =3D 80 from everything else =20 -In short, we can summarize the NUMA distances seem in pseries Linux guests= , using -QEMU up to 5.1, as follows: - -* local distance, i.e. the distance of the resource to its own NUMA node: = 10 -* if it's a NVLink GPU device, distance: 80 -* every other resource, distance: 40 - This also means that user input in QEMU command line does not change the NUMA distancing inside the guest for the pseries machine. --=20 2.26.2