From nobody Sat Oct 4 20:33:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601988992; cv=none; d=zohomail.com; s=zohoarc; b=O5tBfjco27R9M9L6D855CJ5vOX87IJViCtvXDJMJtc1yqxi9Aiz0xNjSO+b/Apd8ZqcTAhcMW2Un6H3pB3TgR/HXCQSQxWvox1E9ETPRw+Qys1KXxnRiAh4uLiDKp3CELfpyEOGn3dI6brLA+cLPPm2b7gdf0md2UTzKwFfS/mc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601988992; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=8XFQO4+C4ntP2b83qPWVKeB3auO8XBYBXJzdLRqnK/M=; b=FLlc8lmFUnSGMHJ2ThqimyziA7jPOZJZF61dWXNShUMV+ejpRhK7Lakd2eYynMFNSC+PYkeuLnPGpKYVVwxpvMzEX2Bvx0guT9IlR2eCBTYJrRL72JeFF6xJ8gv2CjQTrP2brecwmqJTUopt73TtnqBmP5LvmGxM6tuIGsAwdGE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 160198899264760.04523556867275; Tue, 6 Oct 2020 05:56:32 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-515-t8zLrrsMPXur_Nj4MBx8kw-1; Tue, 06 Oct 2020 08:56:26 -0400 Received: by mail-wm1-f71.google.com with SMTP id i9so665607wml.2 for ; Tue, 06 Oct 2020 05:56:26 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id c4sm3950738wme.27.2020.10.06.05.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 05:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601988990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8XFQO4+C4ntP2b83qPWVKeB3auO8XBYBXJzdLRqnK/M=; b=TDAd+Hz38sYDKEH94PD925lukEye7Q+208l03dTvRerck8BzFt8G5YoDLjlqckeZJ8VOf4 +l6Gi8bunA1Jwn0CQ8BG+zDnw6EgnzNZYgie0lZc38saQubXouIo3aQdajAXP3ECja9Q8d l/pgXooBgfVb+aZ5tiFk2nLAnUwvUqI= X-MC-Unique: t8zLrrsMPXur_Nj4MBx8kw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8XFQO4+C4ntP2b83qPWVKeB3auO8XBYBXJzdLRqnK/M=; b=CzHMwiNz4pWNl05+iC2Iy6Q4W8mFPRggmZo9YZCY2KsnFieEdU5l72weWMpxYJ25Yn /Eft4yJ/Bi0nD+NEiGrgJ1TTVaunyIuMvL72W60gaNJB6yZuIxRY/dyw+TmD94pEYFkg CoKCAlbnE3VsHg10uveJIBV2guUDUnoTl48xSI1TQwUu/rCi/zWeAxLknT75AGtRCGu0 QYUDgYTsgsdmv/o/rwykS+NeNbAi59gWulUfx7BqE6iOdxHdoVNBWZMGR7C9Ux5ET8jG y6xo/42YTxwx2SmSMNXMrJehn0+P+JjaSVag/nCmr4vMAmR5sdZKgeNW+h9NXyKuAbQL uDxA== X-Gm-Message-State: AOAM53011hHmrZXEsq5y22TMPlYjX2YpsR/Ws1+AsSFvKkthPI/9bdLH cV5l35WHD5CzeT20VG6zLUWwDXZvQ61Uq216le0I1I0/m5nghfYf/MyKk9I2pM4gS552KwhRW09 FjVVYiX4PBIB3sQ== X-Received: by 2002:a5d:6311:: with SMTP id i17mr4576643wru.243.1601988985346; Tue, 06 Oct 2020 05:56:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwp9TFYXdx8eKlKnz69xteHGW/NyBhHnCt25BlfDngVePi8xiWeZZb2/mGFxP6YCeosXeHWCw== X-Received: by 2002:a5d:6311:: with SMTP id i17mr4576632wru.243.1601988985189; Tue, 06 Oct 2020 05:56:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Dr. David Alan Gilbert" , Juan Quintela , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 4/9] chardev: Move the creation of the library to the main meson.build Date: Tue, 6 Oct 2020 14:55:57 +0200 Message-Id: <20201006125602.2311423-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201006125602.2311423-1-philmd@redhat.com> References: <20201006125602.2311423-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Be consistent creating all the libraries in the main meson.build file. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 7 +++++++ chardev/meson.build | 6 ------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index 47eb7d3709..3c0d7b4d44 100644 --- a/meson.build +++ b/meson.build @@ -1062,6 +1062,7 @@ sphinx_extn_depends =3D [ meson.source_root() / 'docs= /sphinx/depfile.py', blockdev_ss =3D ss.source_set() block_ss =3D ss.source_set() bsd_user_ss =3D ss.source_set() +chardev_ss =3D ss.source_set() common_ss =3D ss.source_set() linux_user_ss =3D ss.source_set() qmp_ss =3D ss.source_set() @@ -1346,6 +1347,12 @@ libqmp =3D static_library('qmp', qmp_ss.sources() + = genh, =20 qmp =3D declare_dependency(link_whole: [libqmp]) =20 +libchardev =3D static_library('chardev', chardev_ss.sources() + genh, + name_suffix: 'fa', + build_by_default: false) + +chardev =3D declare_dependency(link_whole: libchardev) + libhwcore =3D static_library('hwcore', sources: hwcore_files + genh, name_suffix: 'fa', build_by_default: false) diff --git a/chardev/meson.build b/chardev/meson.build index 54e88d0310..dd2699a11b 100644 --- a/chardev/meson.build +++ b/chardev/meson.build @@ -1,4 +1,3 @@ -chardev_ss =3D ss.source_set() chardev_ss.add(files( 'char-fe.c', 'char-file.c', @@ -25,11 +24,6 @@ chardev_ss.add(when: 'CONFIG_WIN32', if_true: files( )) =20 chardev_ss =3D chardev_ss.apply(config_host, strict: false) -libchardev =3D static_library('chardev', chardev_ss.sources() + genh, - name_suffix: 'fa', - build_by_default: false) - -chardev =3D declare_dependency(link_whole: libchardev) =20 softmmu_ss.add(files('chardev-sysemu.c', 'msmouse.c', 'wctablet.c', 'testd= ev.c')) softmmu_ss.add(when: ['CONFIG_SPICE', spice], if_true: files('spice.c')) --=20 2.26.2