From nobody Sun Nov 16 20:47:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601983160; cv=none; d=zohomail.com; s=zohoarc; b=TJ8SI+mCDOTmUXhun3sDuOU6gmVwVRVUZFRqyRB8lwXBIF0r22HAEkSWktgYQwvIGsThlesR7t1gQQBs+8+gTVtTlbBjS1fFdi6GVq7gmA3ItQVGwl9lFIH9GiHs+fRCCcJXN8zX3kMQaR1wfftn/wP83TAg55HNZVQkYxL8zLU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601983160; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ic2vxCTWvaa5xCA7uWFI0HhSc9dX39cw8PJZy9niXhw=; b=gZhYYFYgdS28mkJlPAGNWWQZlaBxM6VPke54v+J+BoPy9UGePBgstKCLCZjJLKRAEas4KafAADxUJViTn4voIIuHidFCEJv1nga43gscABgFn/5Cy8XiC7xX+Osgy/b8yy/sjtKIxDnbAegt2QYaUtDz3bTbMVk4QE8zoACud3Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1601983160658168.4784932358881; Tue, 6 Oct 2020 04:19:20 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-566-WFNTFN8QM_uChVVS3-SgRw-1; Tue, 06 Oct 2020 07:19:17 -0400 Received: by mail-wm1-f72.google.com with SMTP id r19so982367wmh.9 for ; Tue, 06 Oct 2020 04:19:17 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id i6sm4228136wra.1.2020.10.06.04.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 04:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601983159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ic2vxCTWvaa5xCA7uWFI0HhSc9dX39cw8PJZy9niXhw=; b=TQvwg41KKPB23jun2nsBVjjvgQFDG8U/cLvhiumKSEr7Uq08EEYByireWOkRyhsTM5t8oI ZKT2m/k9KxvbkiOT16gwxsus+2bunXNsoKWI4qZ1w/R2LrimZPnJF3Gq1SjbVYpS259ium wDNkhTb756kji77EUyg32AjAI8I0e2U= X-MC-Unique: WFNTFN8QM_uChVVS3-SgRw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ic2vxCTWvaa5xCA7uWFI0HhSc9dX39cw8PJZy9niXhw=; b=LstwrBzdXjIFvYH/d+2JV1x4byGIIsxo84uCVIcnNrd36QNgzDldysAfrUR3p5YZkP b30k7b7b+Kpxu4OBqzHqbv7cL95sL8qyIyA7xxuDMz1iaG70tRyxRU7BXvvtjTrdx19c a8ls4ag7FYUD6nsE8j/gi6HEN+08kD9vZ7eW852oD7SohRe2YmWKhGQ7zGmAqTMxDY4I txlFhnAzamowZRikAQJPUUsdNS9X2U52X1SdNSxb4KN6i0ji93a8FsLrgEhKSY5G3OHw I45MreoencsYghLh9/TjYtDduYjSr3DxKXaSjVQrN100ktSrjimWcxf59UNVQ6dGzFjg wDIg== X-Gm-Message-State: AOAM530hm/ZHFYT59dOC4/i4P3MmPwrSUauUFpc/Z0pizbyCACAXCaFc ZaCJVaqLofSqgl914aZn/VhNxU1sn+S9KUU/a/jdrl7ba7VOdPEus8J25lk53oTLZ7Oq1tB29iY wnrwEK6vUi5XVug== X-Received: by 2002:a5d:6290:: with SMTP id k16mr4600213wru.357.1601983156535; Tue, 06 Oct 2020 04:19:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyb6VpDed4QzyS4twvG46bTF33W5KIwJmq24y+kYdWhg91CLqv1OLrnkDI4TAMNPedoxIIpsg== X-Received: by 2002:a5d:6290:: with SMTP id k16mr4600192wru.357.1601983156341; Tue, 06 Oct 2020 04:19:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Daniel P . Berrange" , Kevin Wolf , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Paolo Bonzini , Laszlo Ersek , Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE Date: Tue, 6 Oct 2020 13:19:09 +0200 Message-Id: <20201006111909.2302081-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201006111909.2302081-1-philmd@redhat.com> References: <20201006111909.2302081-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed by a device only available using system-mode (fw_cfg), it is implemented by a crypto component (tls-cipher-suites) which is always available when crypto is used. Commit 69699f3055 introduced the following error in the qemu-storage-daemon binary: $ echo -e \ '{"execute": "qmp_capabilities"}\r\n{"execute": "qom-list-types"}\r\n{"= execute": "quit"}\r\n' \ | storage-daemon/qemu-storage-daemon --chardev stdio,id=3Dqmp0 --monit= or qmp0 {"QMP": {"version": {"qemu": {"micro": 50, "minor": 1, "major": 5}, "pack= age": ""}, "capabilities": ["oob"]}} {"return": {}} missing interface 'fw_cfg-data-generator' for object 'tls-creds' Aborted (core dumped) Since QOM dependencies are resolved at runtime, this issue could not be triggered at linktime, and we don't have test running the qemu-storage-daemon binary. Fix by always registering the QOM interface. Reported-by: Kevin Wolf Fixes: 69699f3055 ("crypto/tls-cipher-suites: Produce fw_cfg consumable blo= b") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laszlo Ersek Reviewed-by: Paolo Bonzini --- hw/nvram/fw_cfg-interface.c | 15 +++++++++++++++ hw/nvram/fw_cfg.c | 7 ------- MAINTAINERS | 2 +- hw/nvram/meson.build | 3 +++ 4 files changed, 19 insertions(+), 8 deletions(-) create mode 100644 hw/nvram/fw_cfg-interface.c diff --git a/hw/nvram/fw_cfg-interface.c b/hw/nvram/fw_cfg-interface.c new file mode 100644 index 0000000000..2b19502ffe --- /dev/null +++ b/hw/nvram/fw_cfg-interface.c @@ -0,0 +1,15 @@ +#include "qemu/osdep.h" +#include "hw/nvram/fw_cfg.h" + +static const TypeInfo fw_cfg_data_generator_interface_info =3D { + .parent =3D TYPE_INTERFACE, + .name =3D TYPE_FW_CFG_DATA_GENERATOR_INTERFACE, + .class_size =3D sizeof(FWCfgDataGeneratorClass), +}; + +static void fw_cfg_register_types(void) +{ + type_register_static(&fw_cfg_data_generator_interface_info); +} + +type_init(fw_cfg_register_types) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 0e95d057fd..08539a1aab 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -1360,18 +1360,11 @@ static const TypeInfo fw_cfg_mem_info =3D { .class_init =3D fw_cfg_mem_class_init, }; =20 -static const TypeInfo fw_cfg_data_generator_interface_info =3D { - .parent =3D TYPE_INTERFACE, - .name =3D TYPE_FW_CFG_DATA_GENERATOR_INTERFACE, - .class_size =3D sizeof(FWCfgDataGeneratorClass), -}; - static void fw_cfg_register_types(void) { type_register_static(&fw_cfg_info); type_register_static(&fw_cfg_io_info); type_register_static(&fw_cfg_mem_info); - type_register_static(&fw_cfg_data_generator_interface_info); } =20 type_init(fw_cfg_register_types) diff --git a/MAINTAINERS b/MAINTAINERS index b76fb31861..a45d908ebd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2054,7 +2054,7 @@ R: Laszlo Ersek R: Gerd Hoffmann S: Supported F: docs/specs/fw_cfg.txt -F: hw/nvram/fw_cfg.c +F: hw/nvram/fw_cfg*.c F: stubs/fw_cfg.c F: include/hw/nvram/fw_cfg.h F: include/standard-headers/linux/qemu_fw_cfg.h diff --git a/hw/nvram/meson.build b/hw/nvram/meson.build index 1f2ed013b2..fd2951a860 100644 --- a/hw/nvram/meson.build +++ b/hw/nvram/meson.build @@ -1,3 +1,6 @@ +# QOM interfaces must be available anytime QOM is used. +qom_ss.add(files('fw_cfg-interface.c')) + softmmu_ss.add(files('fw_cfg.c')) softmmu_ss.add(when: 'CONFIG_CHRP_NVRAM', if_true: files('chrp_nvram.c')) softmmu_ss.add(when: 'CONFIG_DS1225Y', if_true: files('ds1225y.c')) --=20 2.26.2