From nobody Sun Nov 16 23:00:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601928386; cv=none; d=zohomail.com; s=zohoarc; b=oK2klSDwD+lLQDBQEjwghDx5ao3q795AKEkk2/DkDlsRYeqNXtGdXDEeT3exmcEIaNPpgIpY8PzWldjgUWHU4w6K1mqw5plBUo7y5gH9IvQmq0pxjC74/Qo9CRpzmbpPTAcMyVo10W7ZmQlMi/Lp84aVywPOJcFS/rwUk0zo2FE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601928386; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G4m+pSzb0QAoGW4vRR2Fy171qT8Img5BTXCx79sxdPc=; b=KFWqaoHsZh27ksFjdLDQcgeJnSWAq5hVedsHENLfMWCiGy2h3HEfvKp4zpzW2fuSNFiOmidjL55bGWiuh40GuUblzCsmN3CwpkxB49yKZ1OadXJmoNe0/XjuMkNkXQ5/RkkHCzltAOf7rRLmmyZ0WRA9gEX075zTzwOtPurzScw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1601928386259309.85825385986277; Mon, 5 Oct 2020 13:06:26 -0700 (PDT) Received: from localhost ([::1]:47738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPWka-0001bP-Sq for importer@patchew.org; Mon, 05 Oct 2020 16:06:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPWXH-0000pt-SQ for qemu-devel@nongnu.org; Mon, 05 Oct 2020 15:52:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kPWXE-0007BR-Kk for qemu-devel@nongnu.org; Mon, 05 Oct 2020 15:52:39 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-DAzTZ6AtO22133fQPO7Esw-1; Mon, 05 Oct 2020 15:52:33 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4CB7B1084C86 for ; Mon, 5 Oct 2020 19:52:32 +0000 (UTC) Received: from scv.redhat.com (ovpn-120-38.rdu2.redhat.com [10.10.120.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADADD5C1BD; Mon, 5 Oct 2020 19:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601927555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G4m+pSzb0QAoGW4vRR2Fy171qT8Img5BTXCx79sxdPc=; b=MceAPwqfLl7/LJoQJAEGWQ9XB3ElQ7ElLdfG6szs+gd6Xck91Aiw7QJHS2rYoYKIu8Y85U U5PvzKImVGMZagFGTqlHMHbrAgWu9pGgSTp2++HtfyNlrzcyu9BdUXyksvmf2Eaf1EVQ1F 5UWcE8SbrQgQcJlrJkyqk2+8paLcQUk= X-MC-Unique: DAzTZ6AtO22133fQPO7Esw-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v5 21/36] qapi/commands.py: Don't re-bind to variable of different type Date: Mon, 5 Oct 2020 15:51:43 -0400 Message-Id: <20201005195158.2348217-22-jsnow@redhat.com> In-Reply-To: <20201005195158.2348217-1-jsnow@redhat.com> References: <20201005195158.2348217-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/05 01:25:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.733, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa , John Snow , Eduardo Habkost , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Mypy isn't a fan of rebinding a variable with a new data type. It's easy enough to avoid. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Reviewed-by: Markus Armbruster --- scripts/qapi/commands.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py index f67393f8713..586774a23c7 100644 --- a/scripts/qapi/commands.py +++ b/scripts/qapi/commands.py @@ -195,14 +195,12 @@ def gen_register_command(name, success_response, allo= w_oob, allow_preconfig): if not options: options =3D ['QCO_NO_OPTIONS'] =20 - options =3D " | ".join(options) - ret =3D mcgen(''' qmp_register_command(cmds, "%(name)s", qmp_marshal_%(c_name)s, %(opts)s); ''', name=3Dname, c_name=3Dc_name(name), - opts=3Doptions) + opts=3D" | ".join(options)) return ret =20 =20 --=20 2.26.2