From nobody Sun Feb 8 15:07:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601895298; cv=none; d=zohomail.com; s=zohoarc; b=PwyiJaLyy/V+TVU62gs8AMQBTSVve/1fK584tR6cc/eWQ5qffUom55A8yhkhbC3K4gIZs5mZ98hmlOfi//ERE5hSagyrFxXO9Fhkgybn3uY6Nq2BLNq2MG5nN3MWFlnfHShJSVgz7xXG/qJOezYiseVJRjyZwvuABgGi73PQwco= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601895298; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=m8MSMvH0EGCYLgtqlWbOI3p4RLhGZ+KMS1a1Fylf9ro=; b=Gt5TWLiVds+DS7DKwlz/cOT7MLB2kFyd8sQ0hUjeRQT1vyzy3XPAa28Gr9vpiyVBryUZl8MPUdDKJy5TcUXjBXB1nRSfKcEaIX97teq7tsvmNzBW3E/Dq9Gka0bXutqU9WCTw18y+qpmeJyIdGYge/F39XbsofFYmuXpHqcOdac= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1601895298541835.2369949152932; Mon, 5 Oct 2020 03:54:58 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-73ML_LfqOxiAfWk5aZSHPg-1; Mon, 05 Oct 2020 06:54:55 -0400 Received: by mail-wr1-f69.google.com with SMTP id v5so3869128wrr.0 for ; Mon, 05 Oct 2020 03:54:55 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id q2sm3640992wrw.40.2020.10.05.03.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 03:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601895297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m8MSMvH0EGCYLgtqlWbOI3p4RLhGZ+KMS1a1Fylf9ro=; b=i6kmcmEmhtdREccXEMG1fN4hO0neFMxnCyDwaC2xmyh5dDh8oFooilRb3YlrkDy2TNcpl9 G6GGYwh1ydFM0F7Tmfr42d+40RbCHihuyyEpuct20RoU4MG0+286HQAqcHkBv6sejWtg0g K1ztGUVKcvH94f3w4W4K95Jkz653mEU= X-MC-Unique: 73ML_LfqOxiAfWk5aZSHPg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m8MSMvH0EGCYLgtqlWbOI3p4RLhGZ+KMS1a1Fylf9ro=; b=RlsZ6+v5PHTVSwz3NTOWZYvl36Jxihuy3dlwCsk/w5gcuDGunGQNTpCp1fvwBgwPBe 1+zA1ECN8ax039fYUD0etCMuR4Ixn7Rq38FVkSz6St9VM2VLhSlKOfFuJaRW46++0FQi bgaPvSdvwsDn95L2bXndJ5asKLFCAjXbyN9P935kKENzT7M4Qat3lcJjQSDTAxjvUUhP 4bDfnzfp8EqgymNRzX1Zf+ALDTDOvsm/G2iLT4thId6lRKJTC9OluBMGHF98DLb3hKJV mvz8vZam8cYmP1pHtjWN/FhGf5aHqQwdaJUvuhdoB+hnLQhdFRK37DapQLKEn/LK61vH yuaQ== X-Gm-Message-State: AOAM5303ByGNzsOBibhTCwUx2Gl3BHAXnfXMdoIj3F1SbFAGuwC6Y2Mf 4eBfBHAUv1DsyCXjZ9vBhx4xvaOyasOL4wD8ZI+Br2ubTTng1GPvG97zxHrtYDR0Vx5C3tge4Lu V81Eykp84T1JGVQ== X-Received: by 2002:a5d:51ca:: with SMTP id n10mr17005547wrv.222.1601895294375; Mon, 05 Oct 2020 03:54:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5I1CyuSubTUSQDDYiGGWISM9QKMHHSJxB5MgymvpXAzBUx49+X69fI5+2zxRSaJqWgqK3YQ== X-Received: by 2002:a5d:51ca:: with SMTP id n10mr17005533wrv.222.1601895294236; Mon, 05 Oct 2020 03:54:54 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Kevin Wolf , "Daniel P . Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Eduardo Habkost , Paolo Bonzini , Laszlo Ersek , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann Subject: [RFC PATCH 2/3] tests: Only build socket_scm_helper when a softmmu target is available Date: Mon, 5 Oct 2020 12:54:41 +0200 Message-Id: <20201005105442.2093105-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201005105442.2093105-1-philmd@redhat.com> References: <20201005105442.2093105-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Do not try to build socket_scm_helper if not softmmu target is available. This fixes: $ make check-block Generating qemu-version.h with a meson_exe.py custom command make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper', = needed by 'check-block'. Stop. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index 40d909badc..d257777560 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -136,7 +136,9 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR) get-v= m-images check: =20 ifeq ($(CONFIG_TOOLS)$(CONFIG_POSIX),yy) +ifneq ($(TARGET_DIRS),) QEMU_IOTESTS_HELPERS-$(CONFIG_LINUX) =3D tests/qemu-iotests/socket_scm_hel= per$(EXESUF) +endif check: check-block check-block: $(SRC_PATH)/tests/check-block.sh qemu-img$(EXESUF) \ qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \ --=20 2.26.2