From nobody Mon Feb 9 07:30:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) client-ip=209.85.221.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1601747388; cv=none; d=zohomail.com; s=zohoarc; b=CEvACtsHMDuUU1q4eXae7F+/vgk2veriDtgF1d1qva+bF45QB7AIajwwwSs4nSXhsyKpuYufgH/VcxAPjDWLo+ijDq9N2J8pjoiLHxTxYQUYV8IHCjBuc5CZ6nGIc5n2rWKcQFgSK+SH5fagiRmDMkxFC+eOnzulfCc4kJD0VVc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601747388; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=N/XHuTYoUVTEHJUq0hcnsiyI1FEyMh7TUSpvqUeVj58=; b=X9xt9UFaRWJpAiWKT+wLz8DQ5B9/4ijTml61OvyOp557GkSorFD+vT35F45Cw3Ollq2B56Kvqa+XjSig0YriN8ZlFEM3HndiMT4akNbuKFwZP9GqePYh1yq9b5v7dxVv6BMJGIN33pQEXiyQK44LCJT7UCwwyPvP7Lr86JBgJ+A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.zohomail.com with SMTPS id 1601747388187824.2352484300127; Sat, 3 Oct 2020 10:49:48 -0700 (PDT) Received: by mail-wr1-f68.google.com with SMTP id x14so5187770wrl.12 for ; Sat, 03 Oct 2020 10:49:47 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id u8sm6010828wmj.45.2020.10.03.10.49.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2020 10:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=N/XHuTYoUVTEHJUq0hcnsiyI1FEyMh7TUSpvqUeVj58=; b=N2gVCk5Vis5ao5lQbQgHuhJGwBkE/5l0Jrq1hDcR4WIta5THX9KLOKEU1Eq/uqHUEZ 0ueOYOJOQmY+5KzK7BoN7nLEX4/5rc3P9Yq6QAbmrvR+Gv9ehvR8hD3DcChXV1y4dudW w6cjeNtBT0gNOKrPUDFBjYW/vI8XKsghKlLXh72ST1SNf4BZ4GSYSGNGTj0LvP/AwvX3 oarNcdaIRsMkSt5LYgCQaaqNkDfugWD9R2AaVKFE/bi2be0HKsMGdQZ9ipvzMICKVXJI XNCFwZ2DhMZymEYxb59PXG+QMKf+/2Jw59RwS2VZtS90DIHlce4dChwaAVyoAHFMZEG1 NWCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=N/XHuTYoUVTEHJUq0hcnsiyI1FEyMh7TUSpvqUeVj58=; b=OLoqazcau8lXGkH6uij1y6o63EjUkJ/PdxwX2k5PbvRXWEIr702l1y+UNYd/OwR6tn MP8VmfSRV8W+xJYN3sfzBJyKUwqrVPmIiGpSRM8CiQy6/K42qwKAopc12G0IA+Vr0VaN b/NWbp53mSYWG7UuRlMkC1doSg8IktT8Pws2AH3x2TnhpvxZ1BjyXbU8kvjxoGVoSUo8 Wb/2RofAz2cs+MwD4fTiPsQaGZy0pCwohMO+oLKx3QgpkBuAf7avXARnY1bsCJttvgua X8VQGrU92cp82ogGQlsw6UFiLrv+xQb9ygWf3sYSXfzAJbrgsNg63UkGDzXER/egaY2h b+og== X-Gm-Message-State: AOAM531wRYD2g1Lxm2zSuuTWT3K1ee0DaR4qjb84mwfNNayfszSBLbPN yMf1OU9bMUV9RxyxgOYzncA= X-Google-Smtp-Source: ABdhPJynm3oi1fhv3YF2kb1JpWRXK7yqS45casH4zdSmG1P5r7lINnBnu6uVBnHxmS2WltC2LfMlOg== X-Received: by 2002:adf:97cb:: with SMTP id t11mr3060245wrb.292.1601747386219; Sat, 03 Oct 2020 10:49:46 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Richard Henderson Cc: "Daniel P . Berrange" , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] linux-user/elfload: Avoid leaking interp_name using GLib memory API Date: Sat, 3 Oct 2020 19:49:44 +0200 Message-Id: <20201003174944.1972444-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Fix an unlikely memory leak in load_elf_image(). Fixes: bf858897b7 ("linux-user: Re-use load_elf_image for the main binary.") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/elfload.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index f6022fd704..1a3150df7c 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2584,13 +2584,13 @@ static void load_elf_image(const char *image_name, = int image_fd, info->brk =3D vaddr_em; } } else if (eppnt->p_type =3D=3D PT_INTERP && pinterp_name) { - char *interp_name; + g_autofree char *interp_name =3D NULL; =20 if (*pinterp_name) { errmsg =3D "Multiple PT_INTERP entries"; goto exit_errmsg; } - interp_name =3D malloc(eppnt->p_filesz); + interp_name =3D g_malloc(eppnt->p_filesz); if (!interp_name) { goto exit_perror; } @@ -2609,7 +2609,7 @@ static void load_elf_image(const char *image_name, in= t image_fd, errmsg =3D "Invalid PT_INTERP entry"; goto exit_errmsg; } - *pinterp_name =3D interp_name; + *pinterp_name =3D g_steal_pointer(&interp_name); #ifdef TARGET_MIPS } else if (eppnt->p_type =3D=3D PT_MIPS_ABIFLAGS) { Mips_elf_abiflags_v0 abiflags; @@ -2961,7 +2961,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct= image_info *info) if (elf_interpreter) { info->load_bias =3D interp_info.load_bias; info->entry =3D interp_info.entry; - free(elf_interpreter); + g_free(elf_interpreter); } =20 #ifdef USE_ELF_CORE_DUMP --=20 2.26.2