From nobody Tue Feb 10 05:45:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) client-ip=209.85.221.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1601656945; cv=none; d=zohomail.com; s=zohoarc; b=WWmVvVyEx1rXepNJMrO5zqDI5JxelPLQB1PLsT8vcM81fcUSFFyhrwT2UlU5yIi8lqjWbXGSulNm5bRAzas9F5viUbbPEdqsF+H/pqSvrg5kTx6h3LhOWT727zbfCHVRf6uRGroomOX5xn50ZD4D/7pipfBjKy+GuXGgCJE3Too= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601656945; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QJ73gD1Uc7sEkC9QbqMVDttq6asn/T6Kh/yxfjBEUp0=; b=H3M53tseLL7fp6peC5kFwAp4hJuAdLNULVldDQ6OIy+X8u2UW9VTiT1bsCtwR60SbI+VLxB6iIUv/RI5fqbZ28P9nLz3N30eOb+0sq1GG6BvlQ9N/0bcAU572PgQU3qHRwxceajUKVVIxBTo4dDVov4kydoQMDbJxoA3OO8/QrY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.zohomail.com with SMTPS id 1601656945370823.4369194220145; Fri, 2 Oct 2020 09:42:25 -0700 (PDT) Received: by mail-wr1-f68.google.com with SMTP id m6so2539963wrn.0 for ; Fri, 02 Oct 2020 09:42:24 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id t17sm2378673wrx.82.2020.10.02.09.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 09:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QJ73gD1Uc7sEkC9QbqMVDttq6asn/T6Kh/yxfjBEUp0=; b=KDh4pV1ceGZZTuxJs5aUhU91MGb4YjeVBG+mdh69E4f53aSZQpk2Ta8E9dvUBVXeLm +oya7gV69PW7WNIEKhAPgTLmNnCuDmPGAD1E66kMAYV5QU7/eHKslc7fdOCMKiTbbGvy 8mPvqGPw1H2pr+wA07HKTvYscP4yrj/viDkqRuc7HFtgVBPnvMugAmqUw5xFZ/yd788n g1mG8sspfPy3ZyvqQj8HejfJ/dMTODJ6lEOmxDqa/0UVJCcj2gNbNi/NhX/Kfmk7zeo4 HO4ipcOSdAgpvLRSsh263eLDg+8L911wWrwGytG5TM8Ju4cQqbdJ8g/MveOZyrYZ7jRZ 0ymw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=QJ73gD1Uc7sEkC9QbqMVDttq6asn/T6Kh/yxfjBEUp0=; b=j+cD1s+z8yZOVih8Hd+Z+XsREktwKJpaczZikQhCwQtmSwp668vLWz/MHun0hqh4Y9 6I2Slf6R7TBzMVwOkBFJQ7EH69YDlUJ930ydF10ni8kQGZcX7Iz+uAl5sQk1U7H99lZ1 LcU2Fl4R9xt+r4KI6hQJTmkVMz6RajKEXxztjLgTLX3cHvpOZ64TT74YIwDCthtyzn2m HGwZmLraok37N1lC9gMIXXWWuwHqQaYf/xBdoyidx4GpxJnxeITqOwoW6f+B9r/7wHH5 f+6viX/497mXSn9jyvqRIOvcQ3rtICeiIVVM1wtT24F76xlHf4K+wgKytZoP44rJUpdL hIVQ== X-Gm-Message-State: AOAM531YmfNVturaTdi2bTkafLRT/+nxdrj2s8EbHnvZPncno/KITZQd 4uI/2Ir2Nr7O/1d2pOaexjY= X-Google-Smtp-Source: ABdhPJydccUqaErHkbxPw5tJExtimzS0oH/uUzTQN4k89U5DRCsxarx2xO12IwWgAyZwBX+5RSLOyA== X-Received: by 2002:a5d:4104:: with SMTP id l4mr4078197wrp.396.1601656943473; Fri, 02 Oct 2020 09:42:23 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Paul Zimmerman , Andrew Baumann , Luc Michel , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Niek Linnenbank , Luc Michel Subject: [PATCH v3 4/4] hw/arm/bcm2835_peripherals: Correctly wire the SYS_timer IRQs Date: Fri, 2 Oct 2020 18:42:16 +0200 Message-Id: <20201002164216.1741110-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201002164216.1741110-1-f4bug@amsat.org> References: <20201002164216.1741110-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The SYS_timer is not directly wired to the ARM core, but to the SoC (peripheral) interrupt controller. Fixes: 0e5bbd74064 ("hw/arm/bcm2835_peripherals: Use the SYS_timer") Reviewed-by: Luc Michel Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/arm/bcm2835_peripherals.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 15c5c72e46..48909a43c3 100644 --- a/hw/arm/bcm2835_peripherals.c +++ b/hw/arm/bcm2835_peripherals.c @@ -171,8 +171,17 @@ static void bcm2835_peripherals_realize(DeviceState *d= ev, Error **errp) memory_region_add_subregion(&s->peri_mr, ST_OFFSET, sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->systmr), 0)); sysbus_connect_irq(SYS_BUS_DEVICE(&s->systmr), 0, - qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_ARM_IRQ, - INTERRUPT_ARM_TIMER)); + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, + INTERRUPT_TIMER0)); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->systmr), 1, + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, + INTERRUPT_TIMER1)); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->systmr), 2, + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, + INTERRUPT_TIMER2)); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->systmr), 3, + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, + INTERRUPT_TIMER3)); =20 /* UART0 */ qdev_prop_set_chr(DEVICE(&s->uart0), "chardev", serial_hd(0)); --=20 2.26.2